From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DDFFA04B1; Tue, 29 Sep 2020 20:51:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E61CF1D579; Tue, 29 Sep 2020 20:51:21 +0200 (CEST) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 112381BEEA for ; Tue, 29 Sep 2020 20:51:20 +0200 (CEST) Received: by mail-lj1-f194.google.com with SMTP id y4so4888749ljk.8 for ; Tue, 29 Sep 2020 11:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W1tOPzULe1/WDFle5drtqCilrzQhESyOxUtvJn7eGoQ=; b=T9ZZyyjBBIvwnZHUhpKp+h4mtn3tbHhrdhhD3U68cYI8Q7Dv6b8RFXX4+KWIbJHuFk ulDF0cUNYEWkfFhVZgLjIEQjFiKbfmwKVkilEENIm1ukpFfrck/xcT8h707FUuZinRCL mk/N7EY0LhKbdT89/9kwqpa3EYUVf9y6y3ggHBWwIEqDcWomu9WV2mVKwGBmk2tJT8kL UWXoZuhsWnl+RIfufA19s4cWO/2vHXUKEXVClnS5jTalEvzigszpB7kCCo8E/Q71bw/7 mZ86QhiM7fzYphMSoqZ01YVq4vi27ktanzyykUpY1Ye7b7gFdR1OYDvRi+5qkp7w4jZU 2GGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W1tOPzULe1/WDFle5drtqCilrzQhESyOxUtvJn7eGoQ=; b=ufQylTeP+8due9KvKgqvGnQI8bYv0fTOLa8SiTUQGYI7re/kOALCuZJNOGfMdTPQGz slmjGM/OWl0dSGRIrhT/nXwpF/LE0uwkeKID2qwnF13m2stZgjtSuk5HEgNFpWpVJCce UYsKnCm/i0SmOePf5uBtAwuUjDSjsBZCGDt7kIHhmuQol5BLj0/y8gq0gERjTkfU2V+a x9NMNqwzKFliETtKMMYaQYYaCOwHfEb8PcfJ0q0XUgaXw1+cfHvushjGdnVDuB5xS5gJ 3fvzP2JOQNsG1x/QFsBiwIS4f/huJWGPPvt65KnV1odEZ6H592s2V6ZqFhgEq5S6YGlU umHw== X-Gm-Message-State: AOAM533JV9nH1z5YV6qHwgk0qECtgoiKsnTwrvwbl6zzqMPw89KkayB9 b1D6PdgOY2YPcoLJpwXqZphuzrZlkCC1TkKDH+/HEw== X-Google-Smtp-Source: ABdhPJxN5Y4fo30gxTf6pWgUoa6pdCPYl8DlTTEIRB8mXNYoGRwo5rpf8IMGyhnhuAb00Hxvx9V9mkCrJgLgMIvApJ8= X-Received: by 2002:a2e:8810:: with SMTP id x16mr1475243ljh.21.1601405478580; Tue, 29 Sep 2020 11:51:18 -0700 (PDT) MIME-Version: 1.0 References: <20200804174147.64473-1-chenbo.xia@intel.com> <20200925053702.80367-1-chenbo.xia@intel.com> In-Reply-To: <20200925053702.80367-1-chenbo.xia@intel.com> From: Ed Czeck Date: Tue, 29 Sep 2020 14:51:07 -0400 Message-ID: To: Chenbo Xia Cc: dev@dpdk.org, Shepard Siegel , John Miller , ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, qiming.yang@intel.com, qi.z.zhang@intel.com, rmody@marvell.com, shshaikh@marvell.com, sbhosle@broadcom.com, kishore.padmanabha@broadcom.com, michael.baucom@broadcom.com, venkatkumar.duvvuru@broadcom.com, xiaoyun.li@intel.com, Ferruh Yigit , jingjing.wu@intel.com, irusskikh@marvell.com, wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, nikhil.rao@intel.com, konstantin.ananyev@intel.com, jerin.jacob@caviumnetworks.com, marko.kovacevic@intel.com, orika@nvidia.com, "Richardson, Bruce" , radu.nicolau@intel.com, akhil.goyal@nxp.com, tomasz.kantecki@intel.com, skori@marvell.com, pbhagavatula@marvell.com, John McNamara , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/3] net: fix variable size of ethdev port id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 25, 2020 at 1:41 AM Chenbo Xia wrote: > > The ethdev port id should be 16 bits now. This patch changes the > variable size of port id in some net drivers from 8 bits to 16 > bits. > > Fixes: cf18d4def295 ("net/ark: provide API for hardware modules UDM and DDM") > Fixes: 09b23f8b9df6 ("net/bnxt: fix port stop process and cleanup resources") > Fixes: 769de16872ab ("net/bnxt: fix port default rule create/destroy") > Fixes: 50370662b727 ("net/ice: support device and queue ops") > Fixes: a50d7cbbdad7 ("net/qede: support registers dump") > Cc: stable@dpdk.org > > Signed-off-by: Chenbo Xia > --- > drivers/net/ark/ark_udm.h | 2 +- > drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 2 +- > drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 6 +++--- > drivers/net/ice/ice_rxtx.h | 4 ++-- > drivers/net/qede/base/bcm_osal.h | 2 +- > drivers/net/qede/qede_regs.c | 2 +- > 6 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ark/ark_udm.h b/drivers/net/ark/ark_udm.h > index 5846c825b..32eb82faa 100644 > --- a/drivers/net/ark/ark_udm.h > +++ b/drivers/net/ark/ark_udm.h > @@ -19,7 +19,7 @@ > struct ark_rx_meta { > uint64_t timestamp; > uint64_t user_data; > - uint8_t port; > + uint16_t port; > uint8_t dst_queue; > uint16_t pkt_len; > }; NACK - this struct correlates with an identical structure in the hardware module. The C-level cannot be changed without a hardware update. For the net/ark driver we will be content with 8-bit port ids. Ed.