From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f196.google.com (mail-wj0-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id D482DF60C for ; Wed, 11 Jan 2017 08:55:08 +0100 (CET) Received: by mail-wj0-f196.google.com with SMTP id dh1so9411246wjb.3 for ; Tue, 10 Jan 2017 23:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lGZFIY0lfojCWOnJ7Ppi8KSckqPwfezI2C7TbXKsy+U=; b=b+YM8eQjHG1Cw6lbDOaaJ82ZIk6bD9OmOJ1cVNZb4Mjnuz4Kbb9Ua5CXc3mGKkBeaY R8nunrQiZpwAoW3uHGPIOLJFY09U0ZSnfA8FPp2FZJM0gNgvwVk+1KOC/Cbthp5SQPVJ DSzr07ZZBcAFTYMVRy5evjFEgyrgCeJwW8SEiEOuOGyoeYgTZOBk1PbPT6zVRuFblVpX kN4tpRI9h1hKQywCMhHUNQgCel/oAZJy8vQX6g3PpPufg8iBQurTTWteaLftwZok17ie 1MqFWTTfXZEescxfoNtLn7akYif+/1Sx9C1ZIHQhixnw0b6SzxIDpJUdiCjyxZB7p+lf WzlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lGZFIY0lfojCWOnJ7Ppi8KSckqPwfezI2C7TbXKsy+U=; b=uiDJEL0HVBYydfVRWPDhWXJs0ujIrFo4qEk2KtgtPrBrkUepDrrOXmR/HJ6/wfsWQg Gp+RXixjb7qqP8hdf0SIEJZrYkH/kVjaUcRkoq7q3+xEKHEWE7pJNjMmYJbq1BgWGy5S c2X5gsihM4dTaJB7pWrEpGRzutGuueir4jriM32cjCsdw8qH+zq6RAyY8udWpRvQAAMN IqRD92G5D8QF8ZSAItKj0AODuYt7ic/lRSHl2WkHe5MRGvMmyCs08/LY0pAAoj9dmwV6 Qw+mj2Tg5SiNPWwi5UxgJxZlCdLvYLMpOnkVxVJ8Rg6OgdUJFFSNwgZOdolwSfVlwDcp Z63Q== X-Gm-Message-State: AIkVDXKwce1D0TcXH7yAM4Tn8sra0KGIEMSql5NPAr4LE+tEVbOb0vssiwUbszuUImehEX5Zw3NIRuHlLl2QKg== X-Received: by 10.194.74.6 with SMTP id p6mr3962283wjv.39.1484121308449; Tue, 10 Jan 2017 23:55:08 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.63.83 with HTTP; Tue, 10 Jan 2017 23:55:07 -0800 (PST) In-Reply-To: <20170110095749.3cb00cab@xeon-e3> References: <20170107181756.1944-1-sthemmin@microsoft.com> <20170107181756.1944-3-sthemmin@microsoft.com> <20170110095749.3cb00cab@xeon-e3> From: Jan Blunck Date: Wed, 11 Jan 2017 08:55:07 +0100 X-Google-Sender-Auth: DhPq6S7EO5DgOotld9yJSXRtThU Message-ID: To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 2/8] i40e: don't refer to eth_dev->pci_dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 07:55:09 -0000 On Tue, Jan 10, 2017 at 6:57 PM, Stephen Hemminger wrote: > On Tue, 10 Jan 2017 13:08:30 +0100 > Jan Blunck wrote: > >> On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger >> wrote: >> > Later patches remove pci_dev from the ethernet device structure. >> > Fix the i40e code to just use it's own name when forming zone name. >> > >> > Signed-off-by: Stephen Hemminger >> > --- >> > drivers/net/i40e/i40e_fdir.c | 3 +-- >> > 1 file changed, 1 insertion(+), 2 deletions(-) >> > >> > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c >> > index 335bf15c..68a2523c 100644 >> > --- a/drivers/net/i40e/i40e_fdir.c >> > +++ b/drivers/net/i40e/i40e_fdir.c >> > @@ -250,8 +250,7 @@ i40e_fdir_setup(struct i40e_pf *pf) >> > } >> > >> > /* reserve memory for the fdir programming packet */ >> > - snprintf(z_name, sizeof(z_name), "%s_%s_%d", >> > - eth_dev->driver->pci_drv.driver.name, >> > + snprintf(z_name, sizeof(z_name), "i40e_%s_%d", >> >> The driver is called 'net_i40e'. > > It really doesn't matter. The memory name is just so that primary and secondary > find the same resources. Having net_ on the front doesn't change or help. I understand. Still David Marchand just recently went through the exercise to align all driver names and their usage. Is there a reason why you didn't choose to use eth_dev->data->drv_name?