From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id B9B691B1F2 for ; Thu, 5 Oct 2017 16:52:50 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id l10so1468199wre.3 for ; Thu, 05 Oct 2017 07:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ckVfIZUOFQ6AIIGUb7mSKsFzJ3LA2QBiJEshIkQzbDE=; b=qPi3xik6txN3ZuqK5YmS2xfCR+X1UA1JrTrxN4FYa+FH7WySTVCYLJujo2ZHJcMR79 0u7xMeIWk0ElvQYKAhCJmWcFExwFrYQAWU/An9qP8HX7OnE3oEu23lgtn1uz+/alaCq0 nMpYTK5lrTWsirxMdU8+84ybCGLXJHkzb1e2+wn6AJ45ogQ3pss4eSozlPizqmQor/E1 SfwlUMLMk4huITw9fopvjBVOmTwojwKy9G2Ofs8nbhaTEvDFmhhaafDVT1GwZ5ivGnfW xHURzfOz+hiTPCxHkH4PJkdeNt5paoVxJO685G5AUSoavRi+QFwTF2gk7MncQ1uLt0yz m8Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ckVfIZUOFQ6AIIGUb7mSKsFzJ3LA2QBiJEshIkQzbDE=; b=LFpt9mLSPysS5N2xrzixM2JEIKeNBzPQkEIOpHCorhYKKRg7lDq36c53Ooe+1zSO+W gLxoSn5xrvRVcmu7aFbXJRCka4JFLsCiT4o1Zp7+nsTURaH2yd1e8dHfwXC7TAuSuSNS U4NTZKv11bQQ/EnWLCj3/JHJe5y2Y0bMJ5sYdq+bJvBfO8MDxPPA6xoexZBDLjAs8/9S oh/gwKRd6xYyaszQt+vq8a1qYcoL2ZwhSKhlCSlFIhG+NwGnX17+BkC3E7ngnA1vhnii BNPhwKYJ/iSPhdht7uXDs/c1qvAqYp4ZFYWi/3NRuMtR5ipnCEemBEEjvWyBaI//cOBI QcFA== X-Gm-Message-State: AHPjjUgq9Sv9iivNCvIyU10nmja8H27sCzMyryKjgxO78quRVA7NPYGG KI72oBudnW4ue4ixANifjup2v2rzCSZhWqh0Hds= X-Google-Smtp-Source: AOwi7QBa7hCW+zWFuFOw8KaLtDngRXuMB25Jr3u2eIFMr+IQZZS5iMZf9EgPvdP5ZwZMu902DKhLQsIwH4jhsLqxgsE= X-Received: by 10.223.156.129 with SMTP id d1mr25881185wre.166.1507215170192; Thu, 05 Oct 2017 07:52:50 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.140.196 with HTTP; Thu, 5 Oct 2017 07:52:49 -0700 (PDT) In-Reply-To: References: <20170712075940.58559-1-jblunck@infradead.org> <20170712195846.65286-1-jblunck@infradead.org> <20170712195846.65286-4-jblunck@infradead.org> From: Jan Blunck Date: Thu, 5 Oct 2017 16:52:49 +0200 X-Google-Sender-Auth: RuAwoMzKzTbfVLsOGyJSrCg2FjA Message-ID: To: "De Lara Guarch, Pablo" Cc: "dev@dpdk.org" , "Doherty, Declan" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 14:52:50 -0000 On Mon, Sep 4, 2017 at 4:32 PM, De Lara Guarch, Pablo wrote: > Hi Jan, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, >> Pablo >> Sent: Saturday, July 15, 2017 12:05 PM >> To: Jan Blunck ; dev@dpdk.org >> Cc: Doherty, Declan >> Subject: Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to not >> require rte_vdev.h >> >> Hi >> >> > -----Original Message----- >> > From: Jan Blunck [mailto:jblunck@gmail.com] On Behalf Of Jan Blunck >> > Sent: Wednesday, July 12, 2017 8:59 PM >> > To: dev@dpdk.org >> > Cc: Doherty, Declan ; De Lara Guarch, Pablo >> > >> > Subject: [PATCH v2 3/4] cryptodev: rework PMD init to not require >> > rte_vdev.h >> > >> > The rte_cryptodev_vdev_pmd_init() is a helper for vdev-based drivers. >> > By moving the helper to the header we don't require rte_vdev.h at >> > build- time of the librte_cryptodev library. This is a preparation to >> > move the vdev bus into a standalone library. >> > >> > Signed-off-by: Jan Blunck >> >> I am seeing some clang errors when applying this patch: >> >> lib/librte_cryptodev/rte_cryptodev_vdev.h:88:14: error: implicit >> declaration of function 'rte_cryptodev_pmd_allocate' is invalid in C99 [- >> Werror,-Wimplicit-function-declaration] >> cryptodev = rte_cryptodev_pmd_allocate(name, socket_id); >> ^ >> lib/librte_cryptodev/rte_cryptodev_vdev.h:88:12: error: incompatible >> integer to pointer conversion assigning to 'struct rte_cryptodev *' from 'int' >> [-Werror,-Wint-conversion] >> cryptodev = rte_cryptodev_pmd_allocate(name, socket_id); >> Pablo, I can not reproduce this. There is already an include for rte_cryptodev_pmd_allocate() in rte_cryptodev_vdev.h. >> Also, looks like git commit title is not correct, according to check-git-log.sh: >> >> Wrong headline format: >> cryptodev: rework PMD init to not require rte_vdev.h > This script complains about underscores ... Tell me what you think, Jan