From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 42B8AFA31 for ; Mon, 27 Mar 2017 09:43:04 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id p52so7419315wrc.2 for ; Mon, 27 Mar 2017 00:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/H3LJLqO+b6L3OtjA5uaVAoYyiZHjJNJ0hEzZnLjP28=; b=olWt6+i+QIwcE7JeAYuaiK3Y4+Ho1MMcdcC/qeY1YbRahK8+EhpPzh8DRJfr/poWQt eBONBNEU9iT6kfWJTR3mw9FmT/tz3fDzg7aDGLH8YcCr1EIQqlcwghTO4IjPJ3uT9yS+ /cAjozW3SL+6aHlfewczy86A7GjcgaNBuPAad+sbQ2cGh7myO7PJCCZbmXCcLliV3lvH nIwtg3Eg+6mQvOeKKJnUNXy1vpxY+0asyEU2H6J+EKrEEWcOFWKFCL0UtJ8Rb+77pvMi WKnoDCWhGx2kwIfY79I39YJ2QQHevXMfI71lnxqbDkkfVUSbwnzmQA8AxJ9eN7NcvlKo 2pLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/H3LJLqO+b6L3OtjA5uaVAoYyiZHjJNJ0hEzZnLjP28=; b=SnGwF5cXW057PdmftqX5s+tX7xEQLiHqJ6HuwMlKeSBBk6Q7ccidVfuzZZpN9lLUWN r9flXE8wm4VFddTDrhPJpWVYLSl0lBwdExFX6jaIOcaROtVsjkfHNGHhju733wwY2MlG /VAuhH4jWZiqHbMz/Y4YKi/gdQKASKAoBZO9GUeDY6my9wItQLN90rlXQbuBLRzj/gy2 mVIstqH2Uzu9TA++cvYD5bIcQsWSFGhCUq0vWK+heppjNNfDZV7IqW+dVLIV5SrOJxVT 70K/YGcQWA4rnsi4v8ZfqjahI16SSBe8PGInMUi6dhM2+ocD9idP9BKMX0FhhpCkxMP2 70cQ== X-Gm-Message-State: AFeK/H1c8LPmDXDhcKfZAKk0aZ1VskoUE8UCErGBsT1PCkyBnXgu1lAD6MH8leZy4Sj/9njMaruAGg3YXAA8Qg== X-Received: by 10.223.162.212 with SMTP id t20mr18071245wra.122.1490600584014; Mon, 27 Mar 2017 00:43:04 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.221.213 with HTTP; Mon, 27 Mar 2017 00:43:03 -0700 (PDT) In-Reply-To: <3920281.Or2amWcIZo@xps13> References: <1488797809-12917-1-git-send-email-jblunck@infradead.org> <1488797809-12917-10-git-send-email-jblunck@infradead.org> <3920281.Or2amWcIZo@xps13> From: Jan Blunck Date: Mon, 27 Mar 2017 09:43:03 +0200 X-Google-Sender-Auth: 2kYswYhfHQ9-XxmIqdxFqdeCl-4 Message-ID: To: Thomas Monjalon Cc: dev , David Marchand , Shreyansh Jain , Ferruh Yigit Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v4 09/10] eal: make virtual bus use rte_vdev_device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 07:43:04 -0000 On Mon, Mar 13, 2017 at 6:51 PM, Thomas Monjalon wrote: > 2017-03-06 11:56, Jan Blunck: >> This allows the virtual bus to be rescanned and probed by tracking the >> creation of rte_vdev_device. >> >> Signed-off-by: Jan Blunck >> Tested-by: Ferruh Yigit >> Acked-by: Shreyansh Jain > > There are a lot of strcmp in this patch. Are you sure that you are referring to this patch? There is a single strcmp added here in the find_vdev() helper. > Maybe it should be abstracted in a "match" function. > It would allow bringing new vdev rules in future. Technically that is possible. If I remember correctly we agreed that matching based on the alias is scheduled for removal in a future release. Therefore I believe it is better to keep this in the virtual bus layer implementation instead of moving it down to the PMDs by introducing a driver specific "match" function.