From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f193.google.com (mail-wj0-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id A99CBFA48 for ; Fri, 23 Dec 2016 11:50:27 +0100 (CET) Received: by mail-wj0-f193.google.com with SMTP id hb5so6504192wjc.2 for ; Fri, 23 Dec 2016 02:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=+8tOFgu1MvFJuOBY6UNyjuEWoXf3Bgh5eJjx1aoq26s=; b=Oa7KF8XZUFEGpbS2QI5/Ahr6FxgUYBN4NROLJ9AbjJ4zCb5hmOOgzfKWAd1zYPUHzh YQ1FRVjwxLxBz2mrzUVChNXd4G9EtV4r2KqeC0a8tLHogsl4fb8ThV5ytzu4pyj8zJBp QOl7DGccCXFyaTi6bNuOqLjclaZi4d6/JCzDgf22SYU+pBKpgot05fr1TvA6FwMV2ahq jN3+a97ho52Qb7+APFORkUoVOc6+QyMSEYjng1rPiYsClbK1g6lsWmeiUVUrFicsP2Z+ h0g2ZgNdjWU9yOiUxWxMQBy4mBPzY8PKHLxcj0AXdJCjjyUhW/ChaU/dM0Tp18/GiLjQ FXJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+8tOFgu1MvFJuOBY6UNyjuEWoXf3Bgh5eJjx1aoq26s=; b=APEx5gMh1qwB1BHPg6gOINkeOdwE7VNYHIlaXmqAi4EAOM8o48pbbvFwNiH/V43IFe PLh21KfJj8xQhApZh/dvHP8iwaFHpEWpF9b4xpcqyAvhgeFhtqMcMH7E+ASZMw4MtII4 zJjEatipfvDkRAWYH8iI+bNFjKB8bAhPwmtYm3GmTjxr+HItgn1mUfaWMWxLfyxi7oJq dLEsliEP63bVAi9K+11Wy/FjG/dGstTsUrLFCo7EHQsJf5+tB0HF04JPTY2/8bHISqb0 eWmTLyvgpZ532bCdFVxTid6HSSKNHQRm4N7Ir6ZeQ9iT5ftkCv+zDi/CdqcFHW3LMryC EAwQ== X-Gm-Message-State: AIkVDXLrJ9/guH4Sca4syAI9Kltcsb7Watq4CRanq70BXPcQwL2S5dYylIMf5aPcT62xi8k9htYay0aSoT2wjg== X-Received: by 10.195.30.165 with SMTP id kf5mr12757569wjd.41.1482490227343; Fri, 23 Dec 2016 02:50:27 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.63.83 with HTTP; Fri, 23 Dec 2016 02:50:26 -0800 (PST) In-Reply-To: References: <1482332986-7599-1-git-send-email-jblunck@infradead.org> <1482332986-7599-22-git-send-email-jblunck@infradead.org> <20161221120953.0282b531@xeon-e3> From: Jan Blunck Date: Fri, 23 Dec 2016 11:50:26 +0100 X-Google-Sender-Auth: amA_6UWeaAqKI-43fnQUcDy3GrQ Message-ID: To: Shreyansh Jain Cc: Stephen Hemminger , dev@dpdk.org, David Marchand Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v4 21/23] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 10:50:27 -0000 On Thu, Dec 22, 2016 at 9:11 AM, Shreyansh Jain wrote: > On Thursday 22 December 2016 01:39 AM, Stephen Hemminger wrote: >> >> On Wed, 21 Dec 2016 16:09:44 +0100 >> Jan Blunck wrote: >> >>> Only the device itself can decide its PCI or not. >>> >>> Signed-off-by: Jan Blunck >>> Acked-by: Shreyansh Jain >>> --- >> >> >> I would still like to kill dev_pci from the dev_info API. >> I'm fine with that too. > > +1. It should be rte_dev reference instead. > Only if you can give use-cases for what users should be able to do with it. If that is the case we need to clearly define what that means. Do we want to enable users to control the low-level EAL device directly and shortcut the ethdev driver? If that is necessary we need to give control to the driver first to decide if it is safe to do so.