From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id F086A2A5D for ; Mon, 21 Nov 2016 17:34:45 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id g23so3465266wme.1 for ; Mon, 21 Nov 2016 08:34:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=G2bAAY37e5Oa/Mrv6Z7b6AVmlbK6TTonyNuTcWNl8hQ=; b=d6MCMa754j5By9F94cnfZuLcYXBdC4cR4q8IosL9zIs+SBoJPZOeW35I9s8nRu4OKE rdvia/AC4X1fFPPeC007QpMAyok9//rbmSVhLg/H+AK2bGbbPBUrSgvwrMqWHiiWLU42 T0mZM6xQxq50M8XrRmLMMg/CamcZxhG1SNzmfVrCNxcSuZOInaOK4f9pK+5f8cWsDLHL dBRG+hHKTS9pSzgATP6NHcgijpFMNSzWazPXr3/Z1IoAI5xRqQXOBj3V4TtUmI7wjNlZ BHgLA5O0C1WH+Eklc07bSwP/Io0v5gaix/J46tfP/4Y3d46KOq1feIZHLCLBJyKoq0SE CELA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=G2bAAY37e5Oa/Mrv6Z7b6AVmlbK6TTonyNuTcWNl8hQ=; b=PSA7JNBv7rymLMcRYrIpOQoKKPAu6qT+ViTYqC+CyeVv7JY86KjSaWtfc03q6Darfd oYs/JEb4lgQpJ9c71EH9RZdXCl4e7g0mgezNmAHnMyPJJKtHwT9A1UxTRRt9GQePIOAZ /kt5g8Q4p+tbJcas7oqQ2DXt5tkzNnyTj+NdakoUt6nHr4DroAVQD0NQrSCZE90RNATN kRX9vVIeNVNRAjLSNr+LoOddaDIe/Dep0MDhRzhIM4kFBMIc/f75dOECEO9Z/EwvStQw J1D1/KyPnt9G8KVTvIWbVUk25ipJ80oyJTgLwQNyftzMns8VoZqdFk7HrBc9d5p233WY w3Zw== X-Gm-Message-State: AKaTC03sD1b69oKrWEx08O0QGa3xwUDkZFyST3ISUWvFpWhLxLa3eL/YJDckPITHt7VWL7bINxebZwXo6oNOBg== X-Received: by 10.28.66.194 with SMTP id k63mr16869656wmi.140.1479746085627; Mon, 21 Nov 2016 08:34:45 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.191.8 with HTTP; Mon, 21 Nov 2016 08:34:44 -0800 (PST) In-Reply-To: References: <1479636327-4166-1-git-send-email-jblunck@infradead.org> <1479636327-4166-4-git-send-email-jblunck@infradead.org> From: Jan Blunck Date: Mon, 21 Nov 2016 17:34:44 +0100 X-Google-Sender-Auth: o9KelBPRlJ00w9sWdjqYNWO4_8g Message-ID: To: David Marchand Cc: "dev@dpdk.org" , Shreyansh Jain Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 4/7] virtio: Don't fill dev_info->driver_name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 16:34:46 -0000 On Sun, Nov 20, 2016 at 4:22 PM, David Marchand wrote: > On Sun, Nov 20, 2016 at 11:05 AM, Jan Blunck wrote: >> This is overwritten in rte_eth_dev_info_get(). >> >> Signed-off-by: Jan Blunck >> --- >> drivers/net/virtio/virtio_ethdev.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >> index 079fd6c..741688e 100644 >> --- a/drivers/net/virtio/virtio_ethdev.c >> +++ b/drivers/net/virtio/virtio_ethdev.c >> @@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) >> uint64_t tso_mask; >> struct virtio_hw *hw = dev->data->dev_private; >> >> - if (dev->pci_dev) >> - dev_info->driver_name = dev->driver->pci_drv.driver.name; >> - else >> - dev_info->driver_name = "virtio_user PMD"; >> dev_info->max_rx_queues = >> RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES); >> dev_info->max_tx_queues = >> -- >> 2.7.4 >> > > I posted something similar [1], so looks good to me :-) > > [1]: http://dpdk.org/dev/patchwork/patch/16991/ > Thanks for reviewing. Do we go with your proposal then? Do you plan to follow up on the comments?