From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 2AD2E8E79 for ; Mon, 12 Oct 2015 11:28:37 +0200 (CEST) Received: by wicgb1 with SMTP id gb1so42719873wic.1 for ; Mon, 12 Oct 2015 02:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=xHjdnMACUvopcZ4kmzTEFRZKXStiefJJaFfp9W+0xKM=; b=yKF5NoZrsbLdLv+7J9G+bFoyX7mq0lCIiqhhMsvfM2zmADTu4db3srwDgEj0/U0yyQ Tx5UuGt8nFFsZj5DOOnTXED/2pmc/JZuYeLmGvMe6r5786yezacvzurEmxhhEhObluLD 5tkXrie24v/wjyJy5zAYBG1EFM6z8RE8IeL4V3PAkJ7tAiU38QWl3It/07+r/sO9ZVk/ 0c08PtRorhcf70GWeDM5GXwdXPSk5TA0G7o/m+ZcQ9+v4ebTQJ5Io+tbsMhcy8iep8iK sKc5LUvAiwpXfHjgLQNTqDNX6UoUYJ4gXi2+EzAQTSVSIi2XAuZDCJ7mQhs/yyIpi8Rb 2pPw== MIME-Version: 1.0 X-Received: by 10.194.93.35 with SMTP id cr3mr28521805wjb.46.1444642116927; Mon, 12 Oct 2015 02:28:36 -0700 (PDT) Sender: jblunck@gmail.com Received: by 10.194.234.164 with HTTP; Mon, 12 Oct 2015 02:28:36 -0700 (PDT) In-Reply-To: <560E6751.6090901@redhat.com> References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1443658313-11045-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1443658313-11045-9-git-send-email-mario.alfredo.c.arevalo@intel.com> <560E6751.6090901@redhat.com> Date: Mon, 12 Oct 2015 10:28:36 +0100 X-Google-Sender-Auth: qMwVanRIedLTaSRBbw9z4R0BFHg Message-ID: From: Jan Blunck To: Panu Matilainen Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 8/8] mk: Add rule for installing runtime files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2015 09:28:37 -0000 On Fri, Oct 2, 2015 at 12:15 PM, Panu Matilainen wrote: > On 10/01/2015 03:11 AM, Mario Carrillo wrote: >> >> Add hierarchy-file support to the DPDK libraries, modules, >> binary files, nic bind files and documentation, >> when invoking "make install-fhs" (filesystem hierarchy standard) >> runtime files will be by default installed in: >> $(DESTDIR)/$(BIN_DIR) where BIN_DIR=/usr/bin (binary files) >> $(DESTDIR)/$(SBIN_DIR) where SBIN_DIR=/usr/sbin/dpdk_nic_bind (nic bind >> files) >> $(DESTDIR)/$(DOC_DIR) where DOC_DIR=/usr/share/doc/dpdk (documentation) >> $(DESTDIR)/$(LIB_DIR) (libraries) >> if the architecture is 64 bits then LIB_DIR=/usr/lib64 >> else LIB_DIR=/usr/lib >> $(DESTDIR)/$(KERNEL_DIR) (modules) >> if RTE_EXEC_ENV=linuxapp then >> KERNEL_DIR=/lib/modules/$(uname -r)/build >> else KERNEL_DIR=/boot/modules >> All directory variables mentioned above can be overridden. >> This hierarchy is based on: >> http://www.freedesktop.org/software/systemd/man/file-hierarchy.html >> > > Hmm, I think there's a slight misunderstanding here. > > What I meant earlier by install-sdk and install-fhs is to preserve the > current behavior of "make install" as "make install-sdk" and have "make > install-fhs" behave like normal OSS app on "make install", which installs > everything (both devel and runtime parts) >>From my point of view it would make sense let 'make install' do the right thing from a user perspective (application, library, distribution). The standard workflow of 'make install' is well known and supported by many build environments. One way that could work is to detect the fact that the SDK files are already installed (e.g. via $RTE_SDK != $(pwd) ) and in that case skipping the install of them. Thanks, Jan > This patch series eliminates the current behavior of "make install" > entirely. I personally would not miss it at all, but there likely are people > relying on it since its quite visibly documented and all. So I think the > idea was to introduce a separate FHS-installation target and then deal with > the notion of default behaviors etc separately. > > I guess it was already this way in v2 of the series, apologies for missing > it there. > > - Panu -