From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f194.google.com (mail-wj0-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 943DF2C4F for ; Thu, 15 Dec 2016 22:36:20 +0100 (CET) Received: by mail-wj0-f194.google.com with SMTP id j10so11826263wjb.3 for ; Thu, 15 Dec 2016 13:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=YubEMW1Grm4a8UbOX2wrWDGXFkmjHdVVEqQ2KsFiW1g=; b=rgHM8KiSKUOfFtwpMZNuXlCjMAlLglw9Hoptl7EKEKBxNgfYEVIsKTywAm1D6zGwZn /0gvhBamqlbZMwoN6b+pcwaT1XdoxA0BiTeCKFNRmLpmTdwAC9GA+c+kX+wyXNE6Z2Hc h0nBn6Y4K7EuXMTD5MHHr140jbANR9Qh7tLCnalvmhMp9lBLr9bczylwU2VvvUFNS2Lk bxZ/IvB+uNInaaX8UvGejlD3FfjPi4jGWdl+SzoIaone0W1mvq5LYr61goiMk3XxVp0C qQVnInyQnga2yiQDsHdeutPgB8tW0ssOZHsg1NZA1Fh+dx4/bO6kIVOgZbbwBPgx0BA0 I5Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=YubEMW1Grm4a8UbOX2wrWDGXFkmjHdVVEqQ2KsFiW1g=; b=Cm5QBhN6poc23erfvIXhz8IHuKRomkkKgdezoYAtYS/RaSJnT8sgehcsJOGt3+DwQN euHFpMhhrQAPZ34SerPhjOQP+357ZDy4/cp58I07DPM83nxxP90PfT7EwT3ME+kL1EHO gFqvOKAg+lxmML1QSsAmG39CU9M9gkflRQUJjJsdPIz1hgZRk92Ms32InDTE0Z0IaCjW tSryyaSSdSWi8mJtMzaP8VXNRld6nOTeJiPqcWiyuNPld5dk6F/T+nO8bqADH4fAo0vs HtjGC+F5mto2//ylFazXtI6/Ehh377gJcmsx1srocYxRxZh8gdpmdLkF1EY6u+LiYFJk oSsw== X-Gm-Message-State: AKaTC01rrtaGhmbj6ZHB/OdRpmUcpFfUYDez/3i3o92CsLSkZlOAZDONxIeHufO2qhjsIZ3FJMnUk6C6aOjjJQ== X-Received: by 10.194.127.104 with SMTP id nf8mr3303861wjb.39.1481837780232; Thu, 15 Dec 2016 13:36:20 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.63.83 with HTTP; Thu, 15 Dec 2016 13:36:19 -0800 (PST) In-Reply-To: References: <1480846288-2517-1-git-send-email-shreyansh.jain@nxp.com> <1481636232-2300-1-git-send-email-shreyansh.jain@nxp.com> <1481636232-2300-13-git-send-email-shreyansh.jain@nxp.com> From: Jan Blunck Date: Thu, 15 Dec 2016 22:36:19 +0100 X-Google-Sender-Auth: RWTgCn0qzoV14gg9OqJkO-mc4Fw Message-ID: To: Shreyansh Jain Cc: dev@dpdk.org, David Marchand , Thomas Monjalon , Ferruh Yigit , jianbo.liu@linaro.org Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v2 12/12] drivers: update PMDs to use rte_driver probe and remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 21:36:20 -0000 On Wed, Dec 14, 2016 at 10:49 AM, Shreyansh Jain wrote: > On Tuesday 13 December 2016 07:07 PM, Shreyansh Jain wrote: >> >> These callbacks now act as first layer of PCI interfaces from the Bus. >> Bus probe would enter the PMDs through the rte_driver->probe/remove >> callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the >> drivers are rte_pci_driver). >> >> Signed-off-by: Shreyansh Jain >> --- >> drivers/net/bnx2x/bnx2x_ethdev.c | 8 ++++++++ >> drivers/net/bnxt/bnxt_ethdev.c | 4 ++++ >> drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++++ >> drivers/net/e1000/em_ethdev.c | 4 ++++ >> drivers/net/e1000/igb_ethdev.c | 8 ++++++++ >> drivers/net/ena/ena_ethdev.c | 4 ++++ >> drivers/net/enic/enic_ethdev.c | 4 ++++ >> drivers/net/fm10k/fm10k_ethdev.c | 4 ++++ >> drivers/net/i40e/i40e_ethdev.c | 4 ++++ >> drivers/net/i40e/i40e_ethdev_vf.c | 4 ++++ >> drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++ >> drivers/net/mlx4/mlx4.c | 4 +++- >> drivers/net/mlx5/mlx5.c | 1 + >> drivers/net/nfp/nfp_net.c | 4 ++++ >> drivers/net/qede/qede_ethdev.c | 8 ++++++++ >> drivers/net/szedata2/rte_eth_szedata2.c | 4 ++++ >> drivers/net/thunderx/nicvf_ethdev.c | 4 ++++ >> drivers/net/virtio/virtio_ethdev.c | 2 ++ >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++++ >> 19 files changed, 86 insertions(+), 1 deletion(-) >> > > > drivers/crypto/qat/rte_qat_cryptodev.c should also be changed for this. It > seems to be only PCI registered PMD. All others are VDEV. > > I will send a v3 soon to fix this. > > @Jan, would you be looking in the VDEV part or should I start with that? [1] > Yes, I am doing that. Will send out early next week. Thx, Jan > [1] http://dpdk.org/ml/archives/dev/2016-November/050443.html >