From: Jan Blunck <jblunck@infradead.org>
To: Wen Chiu <wchiu@brocade.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] dpdk 0005-net-bonding-reconfigure-all-slave-queues-every-time.patch issue
Date: Fri, 10 Mar 2017 17:16:25 +0100 [thread overview]
Message-ID: <CALe+Z01_MO5=11TH32OCp7XxSR7Rfe6RbRC3HG8wLByjGJWp2A@mail.gmail.com> (raw)
In-Reply-To: <17a10461-122b-c6ad-ca44-f25b4cdb36c8@brocade.com>
On Thu, Mar 9, 2017 at 3:22 AM, Wen Chiu <wchiu@brocade.com> wrote:
> Hi,
>
> 0005-net-bonding-reconfigure-all-slave-queues-every-time.patch is now
> officially in dpdk 17.02.
This is commit 1e2eff64f554 ("net/bonding: reconfigure all slave
queues every time").
> But, it caused segmentation fault every time when
> I configured bonding. In slave_configure(), "Setup Tx Queues" logic change
> from for q_id=old_nb_tx_queues to qid=0 which always enters the for loop and
> calls rte_eth_tx_queue_setup. After that, rte_eth_dev_start() is called to
> start the device. In rte_eth_dev_start(), vmxnet3_dev_start() is called
> which calls vmxnet3_dev_rxtx_init(). In vmxnet3_dev_rxtx_init(), after for
> loop for rx_queues; dev->data->tx_queues[0] is override with value like
> 0x121b20600 which is an invalid memory address that caused the fault.
>
> Without this 0005 patch, looks like rte_eth_tx_queue_setup() is never called
> as q_id=old_nb_tx_queues never < nb_tx_queues. So, I suspect the calls to
> queue_setup() somehow makes the queues to be setup incorrectly or
> incompletely which causes the fault.
So did the slave_configure() actually return an error?
> Has anyone else encounters the same
> issue?
No, not with the device I tested with.
> Regards,
>
> Wen Chiu
>
>
>
prev parent reply other threads:[~2017-03-10 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 2:22 Wen Chiu
2017-03-10 16:16 ` Jan Blunck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALe+Z01_MO5=11TH32OCp7XxSR7Rfe6RbRC3HG8wLByjGJWp2A@mail.gmail.com' \
--to=jblunck@infradead.org \
--cc=dev@dpdk.org \
--cc=wchiu@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).