From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 12578325B for ; Sun, 9 Jul 2017 09:54:19 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id k67so17447356wrc.1 for ; Sun, 09 Jul 2017 00:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lzA7MxxhQMnZyejBAygfG0wcZtEAVpCPfGJNCSJ0tdc=; b=nrY6K8iDq6TvKDqsvRATnm2xUv3X47aumtM2lEhGCS2bG0aH65YdABmUpLr8tmaVbp ZSITiDwebpI8BYHAdLzlEmRtPNr+2NuGwXVy2r5q8jq+n6wAhV3J2gjbSs24oCG5zAaa FFR4bxisupmUupc63/RtVU7a2L4UwbLITRF37BF17mWZ++Prs7UiF689wqZdq3ihSQGu 7EmYg4o8o1eSODn8fCUq2bjW2vvspXPceBJPc0DR01wYJpvRSZEBe9JNf2WBTeTIGpEu 4XlqRmMIAN+95jmjugxE7Wxegj765+e2Paj2ZUNgUiXAlTgkMWn8b6XDruN2yJ5Hq/L7 fCIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lzA7MxxhQMnZyejBAygfG0wcZtEAVpCPfGJNCSJ0tdc=; b=C8yGXhHiDpbDdonZf5LhdhDkJCEDZiAQnjobiRyYvyoLnnyY/L8NQLCG1V+Ix58M3e qn4/0bU0ePJJZ+qdgp8PswsdVrYPQs2whf7/mfMpd0byRBRogS5VJKAur80aJ+nnZ9X+ fsNsmQhxkAEj6lKgGQN+HWzcNgeYnDPYUcUzT0jmw0H6a3bnyzlrxXXs2XCphAw9ha2y 5+PKqD08R7huC3hCwXhdECBdg7CmOybhsT8icejDRQlBx8ELsv4UHKj40WGK7uGQ0ISP AB8R3JBYBOuk3DOeJy4Me1IX0pxrCEx/Ifovz9WhKNf32Vp1hcc16PC8czS334PqJie7 SH4Q== X-Gm-Message-State: AIVw110DfGtEUFTUoWO++te/rdnu6c3hK8y7RiveIcc0m4jgdwqG5Vqr eAJV+OYjWcruQLjPmGiwDYmJOQSAtQ== X-Received: by 10.223.142.143 with SMTP id q15mr4330169wrb.180.1499586858767; Sun, 09 Jul 2017 00:54:18 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.45.210 with HTTP; Sun, 9 Jul 2017 00:54:18 -0700 (PDT) In-Reply-To: <23043433.nqfcUMGdDr@xps> References: <20170510110104.70838-1-ferruh.yigit@intel.com> <136091512.oDuubpNRB2@xps> <1eae2dda-3fb3-1d46-5d45-1493c1fe1cd4@intel.com> <23043433.nqfcUMGdDr@xps> From: Jan Blunck Date: Sun, 9 Jul 2017 03:54:18 -0400 X-Google-Sender-Auth: vb9J5r7ZIXJli3RIBJrk2G8j_lM Message-ID: To: Thomas Monjalon Cc: dev , Ferruh Yigit , Gaetan Rivet , Tetsuya Mukawa , Declan Doherty Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: remove vdev probe by dev args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 07:54:19 -0000 On Fri, Jun 16, 2017 at 10:20 AM, Thomas Monjalon wrote: > Please Jan, could you comment? > My intention was to provide a way that devices can have arbitrary names. Ferruh correctly pointed out that this is undocumented and hidden functionality. Lets apply this and I can rework this if it becomes necessary later. > 09/06/2017 11:21, Ferruh Yigit: >> On 6/8/2017 9:45 PM, Thomas Monjalon wrote: >> > 10/05/2017 13:01, Ferruh Yigit: >> >> Virtual device/driver probing done via name. >> >> >> >> A new alternative method introduced to probe the device with providing >> >> driver name in devargs as "driver=". >> >> >> >> This patch removes alternative method and fixes virtual device usages >> >> with proper device names. >> >> >> >> Fixes: 87c3bf29c642 ("test: do not short-circuit null device creation") >> >> Fixes: d39670086a63 ("eal: parse driver argument before probing drivers") >> >> >> >> Signed-off-by: Ferruh Yigit >> >> --- >> > [...] >> >> static int >> >> vdev_probe_all_drivers(struct rte_vdev_device *dev) >> >> { >> >> const char *name; >> >> - char *drv_name; >> >> struct rte_vdev_driver *driver; >> >> int ret = 1; >> >> >> >> - drv_name = parse_driver_arg(rte_vdev_device_args(dev)); >> >> - name = drv_name ? drv_name : rte_vdev_device_name(dev); >> >> + name = rte_vdev_device_name(dev); >> > >> > It seems you are reverting the commit d39670086a63: >> > eal: parse driver argument before probing drivers >> >> Mostly yes. >> >> > >> > In some cases the virtual device name should be totally different than >> > the driver being used for the device. Therefore lets parse the devargs for >> > the "driver" argument before probing drivers in vdev_probe_all_drivers(). >> > >> > Is this "driver" option useless? >> >> There is already a generic way to probe, why need another method, I >> didn't get the motivation but this looks like a hack, only place I found >> used is in bonding unit test, which can be switched to generic way >> without this support. >> >> And this is a hidden / an undocumented feature. >> >> Thanks, >> ferruh >> > > >