From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 066362BA1 for ; Thu, 8 Jun 2017 13:40:47 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id x3so6876781wme.0 for ; Thu, 08 Jun 2017 04:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=qXY4cVafhwjiN+JM7aYQipR63ZpF5YL5CAyS2BX0Bns=; b=mULDcXW8c4QnyQX0iRE3CG9D30yHlO1Dt9r3sjj5yHEtF04WXwQYLT9kGqkl6dmUYP qzezf/M3FI2lHuuH2QOVM6NCeWdrl0f2Vb3isUy+jJOSnQMWxJrKPaybsCKaFbHwjSLX dyD6g1UnqQLm+boqVN+mX3p+qccCET0Cv8PEKfoA3+lR7MmTWeVcJCw6rQkhCJkeEsjm 6idzGiF0x+VkiJccNNcBpwiqOgELK/hTRaVH2BchaFT8hN/Bx/BXyZwBLuDfppWhvLvG u//Np2uYBjhDjQa/yXUmd4sq6WYyHe6y75E8LTe5JYQ89/7bHX9IMmzBxF61nZHDOfuR dFZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=qXY4cVafhwjiN+JM7aYQipR63ZpF5YL5CAyS2BX0Bns=; b=t+aYVl4+uBTXUC6gYgltNefN3a0+6QTDVP7tqg05OGwHtHH+PYzLoNgBMaIQa7gejQ PUQShqgbHHk97r4ZH//m4Cb7jrjVdRAcPv/brzrh/eiL2SVRTMvwsElgfcw3Bf7+P800 OtQgnVfdssp+FDLXlttar64Q/NT15zRMYdn/sHeOTbHRa26n30cocZTtfqJ3Ut6GusC8 Gruc3OZFj+LXvS5yB5xKyPupwP4o79FwPukh9n1o3n0T5q6A8FN31rE59s0zbRk9/pRb OJ8zcMChfFzkCtQOMl+iHVENzt6IbN7jyT/kA4xikFpUq1FuFMNX3ZwST6uoLvt/4BkK MdNA== X-Gm-Message-State: AODbwcDKnfGyvb7+3RjHHJ6SNOee9UpE3HVRmtQDm2x4Pk7K7YZmzF1J 1HNr14jGE4SSP2XGPwMOio84dy3pNA== X-Received: by 10.28.150.149 with SMTP id y143mr3088004wmd.108.1496922047503; Thu, 08 Jun 2017 04:40:47 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.25.65 with HTTP; Thu, 8 Jun 2017 04:40:46 -0700 (PDT) In-Reply-To: <20170608113630.GB18840@bidouze.vm.6wind.com> References: <1a54f0dd79200960921ca495aa7381817a599bc0.1495629122.git.gaetan.rivet@6wind.com> <20170607200331.GU18840@bidouze.vm.6wind.com> <20170608113630.GB18840@bidouze.vm.6wind.com> From: Jan Blunck Date: Thu, 8 Jun 2017 13:40:46 +0200 X-Google-Sender-Auth: 2HG_yhdpsgXi7lQ_rQBKwWx4h98 Message-ID: To: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= Cc: dev , Stephen Hemminger , Maxime Coquelin , Jerin Jacob , David Marchand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 7/9] bus: add helper to find a bus from a device name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 11:40:48 -0000 On Thu, Jun 8, 2017 at 1:36 PM, Ga=C3=ABtan Rivet = wrote: > On Thu, Jun 08, 2017 at 12:45:17PM +0200, Jan Blunck wrote: >> On Wed, Jun 7, 2017 at 10:03 PM, Ga=C3=ABtan Rivet wrote: >> > On Wed, Jun 07, 2017 at 07:28:07PM +0200, Jan Blunck wrote: >> >> On Wed, May 24, 2017 at 5:12 PM, Gaetan Rivet wrote: >> >> > Find which bus should be able to parse this device name into an int= ernal >> >> > device representation. >> >> > >> >> >> >> No, please don't add this. One should know to what bus a device >> >> belongs to before plugging it. Artificially encoding the parent bus >> >> into the device name is not the right thing to do. Please keep those >> >> things separate. >> >> >> > >> >> When plugging a device the users know about: >> - bus name >> - device name >> >> Its not the case that the users invent the device names out of thin >> air. The EAL shouldn't codify what the users of the EAL already know >> about. >> >> > > Yes, but in that case the user is forced to explicitly name the bus used > for a device. > > I think it might be sufficient to have this as a private function to the > EAL, as it is currently only used within the rte_devargs parsing. > Applications could use this helper to recognize a bus from a device > name, but this is contrived. > Just remove it. Putting the knowledge of what bus a device name could be for into code has failed before (e.g. biosdevname etc.). If the application doesn't know what bus the device is living on we have a different problem. >> > The EAL has no way to know this currently. As you noted, it has to kno= w >> > onto which bus a device belongs before plugging it. >> > >> >> > Signed-off-by: Gaetan Rivet >> >> > --- >> >> > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + >> >> > lib/librte_eal/common/eal_common_bus.c | 15 +++++++++++++= ++ >> >> > lib/librte_eal/common/include/rte_bus.h | 12 ++++++++++++ >> >> > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + >> >> > 4 files changed, 29 insertions(+) >> >> > >> >> > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/li= brte_eal/bsdapp/eal/rte_eal_version.map >> >> > index 3517d74..04fa882 100644 >> >> > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map >> >> > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map >> >> > @@ -202,5 +202,6 @@ DPDK_17.08 { >> >> > global: >> >> > >> >> > rte_bus_from_name; >> >> > + rte_bus_from_dev; >> >> > >> >> > } DPDK_17.05; >> >> > diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_ea= l/common/eal_common_bus.c >> >> > index 7977190..08fff60 100644 >> >> > --- a/lib/librte_eal/common/eal_common_bus.c >> >> > +++ b/lib/librte_eal/common/eal_common_bus.c >> >> > @@ -242,3 +242,18 @@ rte_bus_from_name(const char *str) >> >> > return NULL; >> >> > return rte_bus_find(bus_cmp_name, str); >> >> > } >> >> > + >> >> > +static int >> >> > +bus_can_parse(const struct rte_bus *bus, const void *_name) >> >> > +{ >> >> > + const char *name =3D _name; >> >> > + >> >> > + return (bus->parse && !bus->parse(name, NULL)); >> >> > +} >> >> > + >> >> > +/* find a bus capable of parsing a device description */ >> >> > +struct rte_bus * >> >> > +rte_bus_from_dev(const char *str) >> >> > +{ >> >> > + return rte_bus_find(bus_can_parse, str); >> >> > +} >> >> > diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_e= al/common/include/rte_bus.h >> >> > index 5b87ac4..0b48e66 100644 >> >> > --- a/lib/librte_eal/common/include/rte_bus.h >> >> > +++ b/lib/librte_eal/common/include/rte_bus.h >> >> > @@ -251,6 +251,18 @@ struct rte_bus *rte_bus_find_by_device(const s= truct rte_device *dev); >> >> > struct rte_bus *rte_bus_from_name(const char *str); >> >> > >> >> > /** >> >> > + * Find a bus capable of identifying a device. >> >> > + * >> >> > + * @param str >> >> > + * A device identifier (PCI address, virtual PMD name, ...). >> >> > + * >> >> > + * @return >> >> > + * A valid bus structure if found. >> >> > + * NULL if no bus is able to parse this device. >> >> > + */ >> >> > +struct rte_bus *rte_bus_from_dev(const char *str); >> >> > + >> >> > +/** >> >> > * Helper for Bus registration. >> >> > * The constructor has higher priority than PMD constructors. >> >> > */ >> >> > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/= librte_eal/linuxapp/eal/rte_eal_version.map >> >> > index 6607acc..a5127d6 100644 >> >> > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map >> >> > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map >> >> > @@ -206,5 +206,6 @@ DPDK_17.08 { >> >> > global: >> >> > >> >> > rte_bus_from_name; >> >> > + rte_bus_from_dev; >> >> > >> >> > } DPDK_17.05; >> >> > -- >> >> > 2.1.4 >> >> > >> > >> > -- >> > Ga=C4=97tan Rivet >> > 6WIND > > -- > Ga=C3=ABtan Rivet > 6WIND