From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f196.google.com (mail-wj0-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 422CC28F3 for ; Tue, 10 Jan 2017 13:12:49 +0100 (CET) Received: by mail-wj0-f196.google.com with SMTP id qs7so49761878wjc.1 for ; Tue, 10 Jan 2017 04:12:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=t6ACWFlDJyAXuRyp4mnEeBh48Qqz/m4iIspfoQg/KOQ=; b=Eq+ifuKNuUdSrfnTkZ1mUIFOLBuZJDpSkAHFA0gCChHSUUZEjIuWwJsXZuOWfH1L8Y OD4XG5P8kR7O0gyF+o9/A2BNgg36HpXHwQ3dLgMH4uHzFfE4eD22ou228GfGQx1kWgho 3RjpmJxg3Q3Gbzph8zAoB67LHXPa37dnWJOyyD9WbAIlBW7sNveTLVemhHJVnlskM353 VOdbTiecDBG5P6OwxPpy8pABV4OKXRnbkqdRVbH4QpUcOPewGz3xW3UoCQZGcb49QpeP 3YkS/myxsTcYEVP1kOQFVWjj9U5LA5RIvbFQUzuzGVm4da1YLsXnRM6mSW3zMQQUSiYJ P/SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=t6ACWFlDJyAXuRyp4mnEeBh48Qqz/m4iIspfoQg/KOQ=; b=gAN/DNAuCUiN9tscW4x+dEunhrFewhv1EBvUxB+bm6fTfBmFSqLIa+k0M8nUH7jDn6 lBD8IhIbfM/Sw07Za307QpO/UU/BT+mCg6CexfROOYimpVoXwFMMaBd5xdk7cqZ/wzWi O2NHNSb0V5YcRGn8eHqP8JWtLF3p2iBFds8lErzZKeej7PmYeGgyK83vGYB0A6o27l4B m2i59qwTdxpxuuyJfHawOPNsyYU1y0zw6QGUp+MPz2OD8c+oLDomyRLD1rPm1crBusP6 cZ9vy8m1CTdLJA4elkcRHqiY2kD6y+4/YzXGDEWinICZCDJ86HQJfNWQ45aEbd4fjf+d 5ZYQ== X-Gm-Message-State: AIkVDXKqu+FkCVeNQBjExfBtyhGet7aoOB2MesP4yx3MNOaslR7p/h8+Yr4dWJ6QgXXDAQrZO5kusHWYc40RTg== X-Received: by 10.194.74.6 with SMTP id p6mr1599449wjv.39.1484050368954; Tue, 10 Jan 2017 04:12:48 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.63.83 with HTTP; Tue, 10 Jan 2017 04:12:48 -0800 (PST) In-Reply-To: <20170107181756.1944-5-sthemmin@microsoft.com> References: <20170107181756.1944-1-sthemmin@microsoft.com> <20170107181756.1944-5-sthemmin@microsoft.com> From: Jan Blunck Date: Tue, 10 Jan 2017 13:12:48 +0100 X-Google-Sender-Auth: 3OyRrEH2ogCZxVMHA9xN-oI_yFw Message-ID: To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 4/8] cxgbe: don't refer to eth_dev->pci_dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 12:12:49 -0000 On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger wrote: > Later patches remove pci_dev from the ethernet device structure. > Fix the cxgbe code to just use it's own name when forming zone name. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/cxgbe/sge.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c > index 736f08ce..e935dc42 100644 > --- a/drivers/net/cxgbe/sge.c > +++ b/drivers/net/cxgbe/sge.c > @@ -1644,8 +1644,7 @@ int t4_sge_alloc_rxq(struct adapter *adap, struct sge_rspq *iq, bool fwevtq, > /* Size needs to be multiple of 16, including status entry. */ > iq->size = cxgbe_roundup(iq->size, 16); > > - snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d", > - eth_dev->driver->pci_drv.driver.name, > + snprintf(z_name, sizeof(z_name), "cxgbe_%s_%d_%d", The driver is called 'net_cxgbe'. > fwevtq ? "fwq_ring" : "rx_ring", > eth_dev->data->port_id, queue_id); > snprintf(z_name_sw, sizeof(z_name_sw), "%s_sw_ring", z_name); > @@ -1697,8 +1696,7 @@ int t4_sge_alloc_rxq(struct adapter *adap, struct sge_rspq *iq, bool fwevtq, > fl->size = s->fl_starve_thres - 1 + 2 * 8; > fl->size = cxgbe_roundup(fl->size, 8); > > - snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d", > - eth_dev->driver->pci_drv.driver.name, > + snprintf(z_name, sizeof(z_name), "cxgbe_%s_%d_%d", > fwevtq ? "fwq_ring" : "fl_ring", > eth_dev->data->port_id, queue_id); > snprintf(z_name_sw, sizeof(z_name_sw), "%s_sw_ring", z_name); > @@ -1893,8 +1891,7 @@ int t4_sge_alloc_eth_txq(struct adapter *adap, struct sge_eth_txq *txq, > /* Add status entries */ > nentries = txq->q.size + s->stat_len / sizeof(struct tx_desc); > > - snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d", > - eth_dev->driver->pci_drv.driver.name, "tx_ring", > + snprintf(z_name, sizeof(z_name), "cxgbe_%d_%d", > eth_dev->data->port_id, queue_id); > snprintf(z_name_sw, sizeof(z_name_sw), "%s_sw_ring", z_name); > > -- > 2.11.0 >