From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 4AC5047CD for ; Thu, 16 Feb 2017 16:55:53 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id c85so3799239wmi.1 for ; Thu, 16 Feb 2017 07:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=CpQYJLemdRhpXbg2v5/etOSZhXrDfrR75XdaSSsN/Eo=; b=dXsG54OtPGkc4QlYKno1G2oLiXYKjCl05MuWynHGOyd/iy+H7V83ksexc6HhJ1Xb+N O4kfCCOmQtErqvWGJcNCTZIuUCKXJz6wL/LLhHe0+5Y3Q8W+EkjdDHywCm1vyAkT4qCt DPYWg+yiGf6zG/QH2XT3LlRIQ6Z+O52xbaQwD+dfVd+Nolgw4bV9Jnscegwzy0rGDP6t wEw/Y4IeyzmNLyCehM+jq1cI4s5OFoYUbKwuOXcdJ75R3jwQkkmBY4avVmkzVhXYkjLy Rh5nU6rrQNlFq7U77ssaonCnvo0hvPMyphOwf4yNdy9FZ92xd6vNgLI2lNPIGzRJKnQD +hyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=CpQYJLemdRhpXbg2v5/etOSZhXrDfrR75XdaSSsN/Eo=; b=GPKOLVIojVCXnF/afQUj2v+yYfW96qy0TC47RDuBZc7+hWELPSsi3/xqct0NlKXV+Z gZiOpwnU/ABrTzVZV+kL7aOBOZTAcF8zvROk6NeE6VCAyG8pNdLaC7F79zQUDxJmqqKy jYbGUvBRyAOA46m6qV+qbPX2qXRo11skTXuSj3toCiN8eByKgmB3Rbg/zJH81lml3YrX 4Td8lA559t6Y7FjrL+Lh21BVH/VL3pOwTLBchzfWur9YoZ2DeTsevv1+CwtcpdO2cdmQ NPOCcjdnYgzm9cXdMeb8REzuFqSW1//pJQtmutjwo0EfAhFfIBkV3ONUE+afiz/bHbLN l9sQ== X-Gm-Message-State: AMke39mRa3WbqZTTXxFEdeEeLS3qAF9ZGZuKQcHkUPPqlh8apbQbVv4jB4yE0mMoQgDnkOtFttlZlqjNYPZk7Q== X-Received: by 10.28.13.16 with SMTP id 16mr3010646wmn.101.1487260553000; Thu, 16 Feb 2017 07:55:53 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.211.20 with HTTP; Thu, 16 Feb 2017 07:55:52 -0800 (PST) In-Reply-To: References: <1487152929-23627-1-git-send-email-jblunck@infradead.org> <1487152929-23627-7-git-send-email-jblunck@infradead.org> From: Jan Blunck Date: Thu, 16 Feb 2017 16:55:52 +0100 X-Google-Sender-Auth: 3KiRc_pWehRTU1_7oDcf7rKWdRs Message-ID: To: Ferruh Yigit Cc: dev , Shreyansh Jain Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 6/7] eal: add struct rte_vdev_device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 15:55:53 -0000 On Wed, Feb 15, 2017 at 6:11 PM, Ferruh Yigit wrote: > On 2/15/2017 10:02 AM, Jan Blunck wrote: >> This adds the rte_vdev_device structure which embeds a generic rte_device. >> >> Signed-off-by: Jan Blunck > > <...> > >> >> +struct rte_vdev_device { >> + TAILQ_ENTRY(rte_vdev_device) next; /**< Next attached vdev */ >> + struct rte_device device; /**< Inherit core device */ > > What do you think adding a name field here ? > > "dev->device.devargs->virt.drv_name" used a few times, since probing > virtual devices done based on name. > > This is device name, and accessing it via "devargs->virt.drv_name" is > not that clear. It is possible to create a name field here, set it > during probe or init to point devargs field and use it wherever > required, does it make sense? > Why don't we add such a thing to the generic rte_device instead? While we are at it we might want to also add a driver private data field. Thoughts?