From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 955329109 for ; Thu, 27 Jul 2017 21:31:55 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id 184so24904501wmo.3 for ; Thu, 27 Jul 2017 12:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=PVgoh35kYYwq9tM/DmSA4y0KbCHhWOnTCaFbM3TvHp8=; b=CGTFTMR4oJLmAWHW9vhGKz8aCsZx1CDtm4b7MOaaP3Bv37r8LArLkLdvuC3a+EW2Q/ au3CmqBagY+BmxluOpA1sMXZhLK98DTSgjp4eNWv3op7Do/m7v6Qo4GwC9k+4Inj+y1H /5N+xBH1OfYYdLUVKHmunygITBrS/IRmBw7m41HMYYL2tcUpUa1Xdwfh251w0zz3Uiid 0wRo1YT+U1xkU/ZB7sqUAHH04C2/Ber+PpvXBNZ2TyGtQiGomwXUd6jHUZ6uOVZ1XHhg LOwj34cFGhKadZ0Yszj6YcoRUDRwAxLCMUPxvlM4QCzZpYjsBUPIdyz0uafGWUbiCTXP R+lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=PVgoh35kYYwq9tM/DmSA4y0KbCHhWOnTCaFbM3TvHp8=; b=uIKOKCP9xWRCfA7ymzROtzov8nUdGWA4scKC2gwonB56MZD7nLii6ytaskSC+ESwk9 YoiW/5W1nwEKKV3VoRApvL11mjVFnxKHI9NUQaIfAyGym+HtBUyBhIKkcu7EJT1HJRZY LLPbpLXrCfiiYXYXYfzB+xJfGakQXCoREoLQ7uEnG3Pa9OkeH96/0ofNXahfMUzzMJYX f7/kcMGZ8TGQe7Z/jIlyBlnMTMyDqIZNaqAMvLEERJP1FZ75WZW02bkd6M3k4pJvE+LK SssTeUVya1enMzANrfxFiJkNiofZLkwtJPS4ilk4FRDBA+002rPQRwz45AKDf587urBj VVoA== X-Gm-Message-State: AIVw110usRjEYgC3sLAQArM87PNXzaRX06Es0Rp8Y3W+1g5P1zot/pw7 Tsju2N5Nnmq7Ze10Yd3Z+u6AkjVwnQ== X-Received: by 10.28.29.2 with SMTP id d2mr3770631wmd.152.1501183915012; Thu, 27 Jul 2017 12:31:55 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.135.149 with HTTP; Thu, 27 Jul 2017 12:31:54 -0700 (PDT) In-Reply-To: References: <20170712075940.58559-1-jblunck@infradead.org> <20170712195846.65286-1-jblunck@infradead.org> From: Jan Blunck Date: Thu, 27 Jul 2017 15:31:54 -0400 X-Google-Sender-Auth: Cbr5d9PE9_fdX4hsxqRM9IlgQ8M Message-ID: To: "De Lara Guarch, Pablo" Cc: "dev@dpdk.org" , "Doherty, Declan" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 0/4] cryptodev vdev changes for -rc2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2017 19:31:55 -0000 On Wed, Jul 19, 2017 at 9:31 AM, De Lara Guarch, Pablo wrote: > > > > > -----Original Message----- > > From: Jan Blunck [mailto:jblunck@gmail.com] On Behalf Of Jan Blunck > > Sent: Wednesday, July 12, 2017 8:59 PM > > To: dev@dpdk.org > > Cc: Doherty, Declan ; De Lara Guarch, Pablo > > > > Subject: [PATCH v2 0/4] cryptodev vdev changes for -rc2 > > > > This series is a preparation to move the vdev bus out of librte_eal. For that > > the newly added cryptodev vdev functions need to change signature to not > > require the rte_vdev.h header. > > > > Changes since v1: > > - move params parsing into new header > > - make rte_cryptodev_vdev_pmd_init() static inline > > > > Jan Blunck (4): > > cryptodev: remove obsolete include > > cryptodev: move initialization > > cryptodev: rework PMD init to not require rte_vdev.h > > cryptodev: move parameter parsing to its own header > > > > lib/librte_cryptodev/Makefile | 1 + > > lib/librte_cryptodev/rte_cryptodev.c | 3 + > > lib/librte_cryptodev/rte_cryptodev.h | 1 - > > lib/librte_cryptodev/rte_cryptodev_pmd.c | 37 +--------- > > lib/librte_cryptodev/rte_cryptodev_vdev.h | 71 ++++++++----------- > > lib/librte_cryptodev/rte_cryptodev_vdev_params.h | 89 > > ++++++++++++++++++++++++ > > lib/librte_cryptodev/rte_cryptodev_version.map | 1 - > > 7 files changed, 122 insertions(+), 81 deletions(-) create mode 100644 > > lib/librte_cryptodev/rte_cryptodev_vdev_params.h > > > > -- > > 2.13.2 > > Hi Jan, > > Since there are some issues in this patchset and knowing that these changes are required > for work to be done in 17.11 (vdev moving out of EAL), let's postpone this for the next release, > as also there is no API breakage in this (correct me if I am wrong). Unexporting a function does require a soname change. So this is affecting ABI.