From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id 5A7E1276C for ; Wed, 12 Jul 2017 10:09:47 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id 77so22699273wrb.1 for ; Wed, 12 Jul 2017 01:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1oMHtjtsMu8C8eUlTe9JsTOYCGPMNFn9T2QFCDmUNEk=; b=R5iH5mrtPpci2tUG2zoeDETIgB4+Kfg/VvJcpoAv6Vu7kPjjniZoujvFl7rQKSBlVr Fn82ohK13/YubakoLVFCx1IZCEJUSIo6WZncndy4PsaojALD4ciynpECVwKtWpuOd6VC WFY96XKNvhgAUeBVHU1T0cI7BdyVtcMeS1F091iZRLRqJAjPfc/6CtRmv7NrCEkRM39l dwvId67j0m7w2LySfchv/lGmPdOmVFx7H81x+2rFDAYTAOXqAMrLfViooOmosznaHbbr OyQG9nffKJ0L+5uV7/NQR7JLaNbKn0xKbqELpjwN9Wx1a2Q1UgM0VGA+krLIfzg+KtMB vWSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=1oMHtjtsMu8C8eUlTe9JsTOYCGPMNFn9T2QFCDmUNEk=; b=WCtk800FMJUw+k2u85Eu1YIFXalyg4Fp24fpxAnQThLGF65nCQ8/fP2vy2V6DcrzEQ Tj1Bt3xceUV+6EmBNvarDlzSBN/ShzO0pGXcwr5KAFKokqTeOvoatF64uO2LMNICy68f uIPJuPUX8k3cYIiSgYNL++L6XLR20Q2CQhUY49AjTfeL/sUswUcoQ8lqplzv4tAGmeFc lN0SOi0xzXvz9ZIoMxJHKm9zh1k0gBs3MVIPLHKioTIjKywUjAT/+mN3N8ZoLwP6kWwA t0Zb+ziJGFwWzRtsay7DPAyPDloRc9BgQTAQFge0w0JyBANiSVA4TH9YKS12OL7RaL7i OuFw== X-Gm-Message-State: AIVw112yU7Rm11/ERQK+SIQqxsRUamAggX0ixrHJI2VQIHOW8pu787Vh B4CSvBMUtYWoS0KLyVl/RDFWrUkGAg== X-Received: by 10.28.64.85 with SMTP id n82mr1547387wma.54.1499846986952; Wed, 12 Jul 2017 01:09:46 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.45.210 with HTTP; Wed, 12 Jul 2017 01:09:46 -0700 (PDT) In-Reply-To: <3538101.lyQKiAFUpY@xps> References: <20170711232512.54641-1-jblunck@infradead.org> <3538101.lyQKiAFUpY@xps> From: Jan Blunck Date: Wed, 12 Jul 2017 04:09:46 -0400 X-Google-Sender-Auth: 5lM1_zJHOlluvHBKV9pjrv6n5MU Message-ID: To: Thomas Monjalon Cc: dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 00/13] devargs fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 08:09:47 -0000 On Wed, Jul 12, 2017 at 3:29 AM, Thomas Monjalon wrote: > 12/07/2017 01:24, Jan Blunck: >> The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking >> API without prior notice. This series is reworking the rte_devargs changes >> in a way hopefully compliant to the new failover PMD and still keeping API >> compatible with earlier releases. > > I have not reviewed this series yet. > I have just seen that your are introducing "bus=" in devargs. > Do you keep compatibility with old scheme without "bus=" option? > We need to keep this compat for 17.08 and deprecate it for 17.11. The old scheme which got introduced with 17.08-rc1 is using the concatenation of bus name, a one character separator and the device name: rte_eal_devargs_parse( "busname*devname,args" ) The new scheme I propose is changing this to take an explicit 'bus=' argument into account. In case the 'bus=' argument isn't given but the device is found by iterating the devices on the buses this will also work. > Please, could you also review the fixes from Gaetan and ack those > which are relevant from your point of view? > We cannot progress if we don't apply the fixes we agree on. Yes, will do today. > Last note: we should make RC2 in few days (hopefully on Sunday), > so please reply quickly. > Thanks >