From: Jan Blunck <jblunck@infradead.org>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev <dev@dpdk.org>, Shreyansh Jain <shreyansh.jain@nxp.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/9] fix hotplug API
Date: Sun, 9 Jul 2017 06:38:52 -0400 [thread overview]
Message-ID: <CALe+Z03506UgkQQjSwsA8pkr9sxc7TyppMgX=7rsVHEW+oOXZw@mail.gmail.com> (raw)
In-Reply-To: <cover.1499563730.git.gaetan.rivet@6wind.com>
On Sat, Jul 8, 2017 at 9:45 PM, Gaetan Rivet <gaetan.rivet@6wind.com> wrote:
> Sending those fixes as separate patches as they stand on their own.
> This series improves usability of the hotplug API and fixes a few issues
> with existing implementations.
>
Interesting that you send this series as fixes. From what I can tell
this is a collection of changes that you have proposed before and I
have commented on and requested changes for. But I don't see that they
have been addressed at all:
- you still concatenate the bus and device name just to pass it down
to the buses and parse it into its components again
- you still delegate the devargs parsing to the buses
Please fix this issues. If you really want to return a device handle
from the hotplug API please present the use-case and in which cases
this solves a real-world problem.
> The hotplug API can be tested with the fail-safe PMD[1]. Its
> documentation describes how to declare slaves and how to use it.
>
> [1]: http://dpdk.org/ml/archives/dev/2017-July/070529.html
>
> Gaetan Rivet (9):
> eal: return device handle upon plugin
> eal: fix hotplug add
> devargs: introduce removal function
> eal: release devargs on device removal
> pci: use given name as generic name
> pci: fix generic driver pointer on probe error
> pci: fix hotplug operations
> vdev: implement plug operation
> bus: remove useless plug parameter
>
> lib/librte_eal/bsdapp/eal/eal_pci.c | 4 +-
> lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
> lib/librte_eal/common/eal_common_dev.c | 83 +++++++++++++++++++++----
> lib/librte_eal/common/eal_common_devargs.c | 18 ++++++
> lib/librte_eal/common/eal_common_pci.c | 49 +++++++--------
> lib/librte_eal/common/eal_common_vdev.c | 12 ++--
> lib/librte_eal/common/eal_private.h | 5 ++
> lib/librte_eal/common/include/rte_bus.h | 6 +-
> lib/librte_eal/common/include/rte_dev.h | 10 +--
> lib/librte_eal/common/include/rte_devargs.h | 18 ++++++
> lib/librte_eal/common/include/rte_vdev.h | 7 +++
> lib/librte_eal/linuxapp/eal/eal_pci.c | 4 +-
> lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 +
> 13 files changed, 162 insertions(+), 56 deletions(-)
>
> --
> 2.1.4
>
next prev parent reply other threads:[~2017-07-09 10:38 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 1:45 Gaetan Rivet
2017-07-09 1:45 ` [dpdk-dev] [PATCH 1/9] eal: return device handle upon plugin Gaetan Rivet
2017-07-09 1:45 ` [dpdk-dev] [PATCH 2/9] eal: fix hotplug add Gaetan Rivet
2017-07-09 1:45 ` [dpdk-dev] [PATCH 3/9] devargs: introduce removal function Gaetan Rivet
2017-07-09 1:45 ` [dpdk-dev] [PATCH 4/9] eal: release devargs on device removal Gaetan Rivet
2017-07-09 1:45 ` [dpdk-dev] [PATCH 5/9] pci: use given name as generic name Gaetan Rivet
2017-07-09 1:45 ` [dpdk-dev] [PATCH 6/9] pci: fix generic driver pointer on probe error Gaetan Rivet
2017-07-09 1:45 ` [dpdk-dev] [PATCH 7/9] pci: fix hotplug operations Gaetan Rivet
2017-07-09 1:45 ` [dpdk-dev] [PATCH 8/9] vdev: implement plug operation Gaetan Rivet
2017-07-09 1:45 ` [dpdk-dev] [PATCH 9/9] bus: remove useless plug parameter Gaetan Rivet
2017-07-09 10:38 ` Jan Blunck [this message]
2017-07-09 12:19 ` [dpdk-dev] [PATCH 0/9] fix hotplug API Gaëtan Rivet
2017-07-09 14:19 ` Thomas Monjalon
[not found] ` <20170711160211.GW11154@bidouze.vm.6wind.com>
[not found] ` <CALe+Z00Rc_6cn_ckWrK1cD2RsdWENM3s+ytOpxNymTmaqh8e0g@mail.gmail.com>
2017-07-11 19:21 ` Gaëtan Rivet
2017-07-10 23:18 ` [dpdk-dev] [PATCH v2 0/8] " Gaetan Rivet
2017-07-10 23:19 ` [dpdk-dev] [PATCH v2 1/8] vdev: implement plug operation Gaetan Rivet
2017-07-10 23:19 ` [dpdk-dev] [PATCH v2 2/8] devargs: introduce removal function Gaetan Rivet
2017-07-10 23:19 ` [dpdk-dev] [PATCH v2 3/8] devargs: introduce insert function Gaetan Rivet
2017-07-11 22:13 ` Thomas Monjalon
2017-07-10 23:19 ` [dpdk-dev] [PATCH v2 4/8] eal: fix hotplug add / remove Gaetan Rivet
2017-07-11 22:18 ` Thomas Monjalon
2017-07-10 23:19 ` [dpdk-dev] [PATCH v2 5/8] pci: use given name as generic name Gaetan Rivet
2017-07-11 22:05 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2017-07-10 23:19 ` [dpdk-dev] [PATCH v2 6/8] pci: fix generic driver pointer on probe error Gaetan Rivet
2017-07-10 23:19 ` [dpdk-dev] [PATCH v2 7/8] pci: fix hotplug operations Gaetan Rivet
2017-07-10 23:19 ` [dpdk-dev] [PATCH v2 8/8] bus: remove useless plug parameter Gaetan Rivet
2017-07-11 23:25 ` [dpdk-dev] [PATCH v3 0/8] fix hotplug API Gaetan Rivet
2017-07-11 23:25 ` [dpdk-dev] [PATCH v3 1/8] vdev: implement plug operation Gaetan Rivet
2017-07-11 23:25 ` [dpdk-dev] [PATCH v3 2/8] devargs: introduce removal function Gaetan Rivet
2017-07-12 8:27 ` Jan Blunck
2017-07-12 17:22 ` Gaëtan Rivet
2017-07-11 23:25 ` [dpdk-dev] [PATCH v3 3/8] devargs: introduce insert function Gaetan Rivet
2017-07-12 8:20 ` Jan Blunck
2017-07-12 17:20 ` Gaëtan Rivet
2017-07-13 19:44 ` Jan Blunck
2017-07-11 23:25 ` [dpdk-dev] [PATCH v3 4/8] eal: fix hotplug add / remove Gaetan Rivet
2017-07-12 8:44 ` Jan Blunck
2017-07-12 17:33 ` Gaëtan Rivet
2017-07-11 23:25 ` [dpdk-dev] [PATCH v3 5/8] pci: use given name as generic name Gaetan Rivet
2017-07-11 23:25 ` [dpdk-dev] [PATCH v3 6/8] pci: fix generic driver pointer on probe error Gaetan Rivet
2017-07-11 23:25 ` [dpdk-dev] [PATCH v3 7/8] pci: fix hotplug operations Gaetan Rivet
2017-07-11 23:25 ` [dpdk-dev] [PATCH v3 8/8] bus: remove useless plug parameter Gaetan Rivet
2017-07-15 17:56 ` [dpdk-dev] [PATCH v4 0/8] fix hotplug API Gaetan Rivet
2017-07-15 17:56 ` [dpdk-dev] [PATCH v4 1/8] vdev: implement plug operation Gaetan Rivet
2017-07-15 17:56 ` [dpdk-dev] [PATCH v4 2/8] devargs: introduce removal function Gaetan Rivet
2017-07-15 17:56 ` [dpdk-dev] [PATCH v4 3/8] devargs: introduce insert function Gaetan Rivet
2017-07-15 17:56 ` [dpdk-dev] [PATCH v4 4/8] eal: fix hotplug add / remove Gaetan Rivet
2017-07-15 17:56 ` [dpdk-dev] [PATCH v4 5/8] pci: use given name as generic name Gaetan Rivet
2017-07-15 17:56 ` [dpdk-dev] [PATCH v4 6/8] pci: fix generic driver pointer on probe error Gaetan Rivet
2017-07-15 17:56 ` [dpdk-dev] [PATCH v4 7/8] pci: fix hotplug operations Gaetan Rivet
2017-07-15 17:56 ` [dpdk-dev] [PATCH v4 8/8] bus: remove useless plug parameter Gaetan Rivet
2017-07-19 21:27 ` [dpdk-dev] [PATCH v4 0/8] fix hotplug API Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALe+Z03506UgkQQjSwsA8pkr9sxc7TyppMgX=7rsVHEW+oOXZw@mail.gmail.com' \
--to=jblunck@infradead.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=shreyansh.jain@nxp.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).