From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 876AE5699 for ; Sun, 9 Jul 2017 12:38:53 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id 77so101510613wrb.1 for ; Sun, 09 Jul 2017 03:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Kjbn2ofTQOkVBfRvkiRrkUVo8dlGx3k+VNv7bMooV0I=; b=k/hCr1ORYrwm2kOvHD071ut2wge4XA26y55gV8QNIIy6DwREzrNM15BjSXPrYH0o/k 7x60zlsdKqLGH6JUn+b9KFD/H5+TPtbvf4x8BcIdDMSIkZmSE8eJ35K/tdFKacyMJaZ/ muO3OD+Lct9CP+28weo4NxodFOHRsQlQ1T64fHeMH1VTlmMZ5of2RKzXuPowczqDbZ5v bwY9kACUIVRsqK32SeFhcIIuOQraXcmZin0eHMMWXlYnUMgKMaXumZNOq/73blXi846O rLRVAcAqZXBZ12bFgzTHq2yMpodKjatnFPJViNHnSclJN33SQEpcCKAw6XBTuP9IONdT GjXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Kjbn2ofTQOkVBfRvkiRrkUVo8dlGx3k+VNv7bMooV0I=; b=kF2H3yaEzJRctZrgjtElSqH2Jpy2p9/mngaIKbMwIsZ9+fpC9JKD32ULgUJdOkFhKL WSdZB0vTYxUcb5DSlulU74VzhC2VaTTw0J2xUCSTtsvao/1EyHmVeJmGEMWDH54Acfvk 0j3VctwdBBlD6DkROLbdN6pt/uuvwxpuSJjPLBCJxzAtVYDmscssqQW9A51cSbB8ptPR pxdXwYrunUITIF97WNP242k78GT8Rre7X/dupcwQ1FJuECEezfRrDJO36T2ATBfdv8bq XugQQJ4ZyUY3oo/5cMiHWJTeQw8tuEkD9rh0PXEBSEPeSTi8KsdPdBr+28WC8KrnWyuD 8HMg== X-Gm-Message-State: AIVw111LBa3mLoerzUyMcYqtWjKBeaP3FaJ/h9LQh+myHgc0eQhRFGWt kj+rhHKJEMq0C6kMqUXmvcOmqIaBPw== X-Received: by 10.223.133.211 with SMTP id 19mr4690607wru.27.1499596733236; Sun, 09 Jul 2017 03:38:53 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.45.210 with HTTP; Sun, 9 Jul 2017 03:38:52 -0700 (PDT) In-Reply-To: References: From: Jan Blunck Date: Sun, 9 Jul 2017 06:38:52 -0400 X-Google-Sender-Auth: DcESn-78ulqLJoA8H8_nlKcGZCg Message-ID: To: Gaetan Rivet Cc: dev , Shreyansh Jain , Stephen Hemminger , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 0/9] fix hotplug API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 10:38:53 -0000 On Sat, Jul 8, 2017 at 9:45 PM, Gaetan Rivet wrote: > Sending those fixes as separate patches as they stand on their own. > This series improves usability of the hotplug API and fixes a few issues > with existing implementations. > Interesting that you send this series as fixes. From what I can tell this is a collection of changes that you have proposed before and I have commented on and requested changes for. But I don't see that they have been addressed at all: - you still concatenate the bus and device name just to pass it down to the buses and parse it into its components again - you still delegate the devargs parsing to the buses Please fix this issues. If you really want to return a device handle from the hotplug API please present the use-case and in which cases this solves a real-world problem. > The hotplug API can be tested with the fail-safe PMD[1]. Its > documentation describes how to declare slaves and how to use it. > > [1]: http://dpdk.org/ml/archives/dev/2017-July/070529.html > > Gaetan Rivet (9): > eal: return device handle upon plugin > eal: fix hotplug add > devargs: introduce removal function > eal: release devargs on device removal > pci: use given name as generic name > pci: fix generic driver pointer on probe error > pci: fix hotplug operations > vdev: implement plug operation > bus: remove useless plug parameter > > lib/librte_eal/bsdapp/eal/eal_pci.c | 4 +- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > lib/librte_eal/common/eal_common_dev.c | 83 +++++++++++++++++++++---- > lib/librte_eal/common/eal_common_devargs.c | 18 ++++++ > lib/librte_eal/common/eal_common_pci.c | 49 +++++++-------- > lib/librte_eal/common/eal_common_vdev.c | 12 ++-- > lib/librte_eal/common/eal_private.h | 5 ++ > lib/librte_eal/common/include/rte_bus.h | 6 +- > lib/librte_eal/common/include/rte_dev.h | 10 +-- > lib/librte_eal/common/include/rte_devargs.h | 18 ++++++ > lib/librte_eal/common/include/rte_vdev.h | 7 +++ > lib/librte_eal/linuxapp/eal/eal_pci.c | 4 +- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > 13 files changed, 162 insertions(+), 56 deletions(-) > > -- > 2.1.4 >