From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 59A8D2BA1 for ; Tue, 22 Mar 2016 11:42:13 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id p65so28920603wmp.1 for ; Tue, 22 Mar 2016 03:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=BCiOgNZu1aX67PWv7IFayEZtROOUzu1/WTFuUIUmmOE=; b=xkK5SCaVn5SkBKctuuG1LLTPyRnzMSuHGdNa1DPg4WJ63NxAAdJTm85t/iepVqa69q PjcA3fSGIkrIWe9BDKuD5QTpqvsM92xCVFo31546WJS4SZn3noOaeCxP+Sx/wIXN1Nxc t7NNq8FS5G26WASAdjNMmKOGDLE5XMOhm0xzhjlBExkOIzSUf8GVtX21oX9nQuGFpDqg 3bvVvpCFvvxgD6JyH4BBiW03z3lwu8kT1JL7M7mXIFq5DzBg4Zq/knSViTBddf+MZIWP 0IR2AVaZTwVwXeoPfPKAZ84Ik8r20sk807pu1r4wuvyHkrE/NJOZRhhAxp6lqOjspvHl P1WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=BCiOgNZu1aX67PWv7IFayEZtROOUzu1/WTFuUIUmmOE=; b=kLDWzXNiruHyN29/NH8fBHrYJGmRRAcqKgmOeMEO9rZ2LER3N7drnHeCw3X7kvUltm 8p+AkWmR1OL0cQeAV4DzLU7XiO1C2a9KUbG32nNXt+hxvLicWlqYcVz7KIvEkqMJG+45 +VhvyDE9M9dTGWnhrZXzD/RS3UtVbjZE9/2ig06Y92BDKr0ueQmxAt6MwSHE8RoPTUcs qaE/y0ACIm8H2HNiPS4dJxhFgRf9kvjiqVJkdtIebMiVgY2ntL219U6W3Rw1oW4ujpuj 5+rmrYxVtxHtd+L+wKVslcOTpu+dSEB6hTb8JtRcOJ1i43t44sAot4RzjGs06OMn9x/B 9q3Q== X-Gm-Message-State: AD7BkJKhWJXk3/OehxFSvWwNh2s2S3+yVPI9RQWxdWYipsxJMh/FnOjYG75QBowT3rSvZ8i2Tob2mHQVqHz9EQ== MIME-Version: 1.0 X-Received: by 10.194.122.138 with SMTP id ls10mr35190256wjb.51.1458643333106; Tue, 22 Mar 2016 03:42:13 -0700 (PDT) Sender: jblunck@gmail.com Received: by 10.194.249.9 with HTTP; Tue, 22 Mar 2016 03:42:13 -0700 (PDT) In-Reply-To: References: <1424013889-2226-4-git-send-email-shemming@brocade.com> <1458640529-9183-1-git-send-email-jblunck@infradead.org> <1458640529-9183-3-git-send-email-jblunck@infradead.org> Date: Tue, 22 Mar 2016 11:42:13 +0100 X-Google-Sender-Auth: Hv99oB5SQE4yMHYiIMSuh3BzXD0 Message-ID: From: Jan Blunck To: David Marchand Cc: "dev@dpdk.org" , jblunck@brocade.com, Stephen Hemminger , Stephen Hemminger Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v3 2/3] xen: Add netfront poll mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 10:42:13 -0000 On Tue, Mar 22, 2016 at 11:07 AM, David Marchand wrote: > Hello, > > On Tue, Mar 22, 2016 at 10:55 AM, Jan Blunck wrote: >> +static struct eth_dev_ops xen_eth_dev_ops = { >> + /*dev*/ >> + .dev_configure = xen_dev_configure, >> + .dev_close = xen_dev_close, >> + .dev_start = xen_dev_start, >> + .dev_stop = xen_dev_stop, >> + .dev_infos_get = xen_dev_info_get, >> + .link_update = xen_dev_link_update, >> + /*rxtx*/ >> + .stats_get = xen_dev_stats_get, >> + .stats_reset = xen_dev_stats_reset, >> + .rx_queue_setup = xen_dev_rx_queue_setup, >> + .rx_queue_release = xen_dev_rx_queue_release, >> + .tx_queue_setup = xen_dev_tx_queue_setup, >> + .tx_queue_release = xen_dev_tx_queue_release, >> +}; > > Is there anything preventing it from being const ? > I don't think so. Will constify it for the next round. Thanks, Jan > > -- > David Marchand