From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 39D9041BB3;
Fri, 3 Feb 2023 00:00:36 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1B21940DDA;
Fri, 3 Feb 2023 00:00:36 +0100 (CET)
Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com
[209.85.221.170])
by mails.dpdk.org (Postfix) with ESMTP id A657E40A79
for <dev@dpdk.org>; Fri, 3 Feb 2023 00:00:33 +0100 (CET)
Received: by mail-vk1-f170.google.com with SMTP id v81so1708424vkv.5
for <dev@dpdk.org>; Thu, 02 Feb 2023 15:00:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=iyMvxPafFgMx/gbNIWUO00HTkyjNWLbnjDiKaHrG9sc=;
b=D9qAvtrkcp8rbWtpjSuuGEaDA/EM+ExMwyyvULKQgeAJaC2lCEyPDcnp2xNLfAkpxK
jserf53q7D1LYJvz9c7qshrzE3m0VTo6WrZMh5BAQbk5F/8Nw5tEiPpl9NWLLYl781AE
oSQzGhV5lgBXwS8x0QA6uU7P+dZLYlIqSe9X6OhDsPDkiw7Xw+iSsP+m/09Fns+c/ioP
9xld3yMuTl9yClLlHG4jnwec1zeZC5p3O/uwIcnMGRKuj7NNCD6nDhtmqFDL6BrdXwsO
+K+Jtowqb8YeZSqz8OPGqogLPHZrr4rzKZo27P9Z3p8DptnkXyg/LZCjTPCz/tmGLlw5
ej3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=iyMvxPafFgMx/gbNIWUO00HTkyjNWLbnjDiKaHrG9sc=;
b=Rwzm5ggz0WE5xfAvdGevIDQ/hzUBrfLaGs6GxdFxktu+GwQjGw4YYQ7YsGhOTH7Czh
uRjRYm4uvShgraux9NWy097w5Q8lfQ1p2KAD4iJPHXO4dL5kwe9iB0uBl7MUpQiPqThs
nro9zjk02DYlaKaU30btw0cftAghUOKKX4uuFMWQ8mf4BiZEVpuuc2KLWIh6V03DzDKn
CI03r4jHt+jiK8Zpe2Gj6k6Lak/0893atec4Ng+NPrFHUm8iMag6xtyJ6CmlRoqi3Ekt
8FWAkwo0lsQ5DpVIBuK7WDLIrKl4CE9uXuEpzRkwfUmAmefT7/EF7AYlmM86o+ccSKow
vYrQ==
X-Gm-Message-State: AO0yUKXhXwdHXGslMn+pXkFAxQXt2/VMZw1rzRAoW68ZvRHMNRUVQaaa
Ab5i8dmrin6w3gGrZJayaTestshMFQmNfi/kFeOKWA==
X-Google-Smtp-Source: AK7set+hIPy+80F6UNcOpCSzaagdSTEic3545zoU1HNZbALgLZRM9VCRXUgH4+TPb/yB3kA57VVsrW64xS6z9UmvN7E=
X-Received: by 2002:a1f:fece:0:b0:3ea:1a72:aad6 with SMTP id
l197-20020a1ffece000000b003ea1a72aad6mr1214189vki.15.1675378832929; Thu, 02
Feb 2023 15:00:32 -0800 (PST)
MIME-Version: 1.0
References: <20221124073335.3985214-1-junfeng.guo@intel.com>
<fa58bec0-c7e7-3c9f-fb03-7c4b773bc4be@amd.com>
<20221207083948.22af7cae@hermes.local>
<CANzqiF5eu9D4jWvNfFPp8vB2NESbkZiNk+N2suCrqH23H7gqhQ@mail.gmail.com>
<CALuQH+V1US5Op2A-zvzLKX2MORYqh8P7d2KBrG6fFHtQuh+S=g@mail.gmail.com>
<78fcfa68-120b-af64-fb42-aa2031d45592@amd.com>
<CALuQH+WaAR_dZ0ECdKLH8u4grv2Z3mfzogvDVnakGu5NQY80sA@mail.gmail.com>
<a440ab60-9624-f21e-396a-239bdf2aa1a1@amd.com>
In-Reply-To: <a440ab60-9624-f21e-396a-239bdf2aa1a1@amd.com>
From: Joshua Washington <joshwash@google.com>
Date: Thu, 2 Feb 2023 15:00:21 -0800
Message-ID: <CALuQH+V60GJFY0UkS3ZyM+L_HD_ZvFMoRhS=sXaV1m8LtAsjzQ@mail.gmail.com>
Subject: Re: [PATCH] net/gve: add support for basic stats
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Rushil Gupta <rushilg@google.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Junfeng Guo <junfeng.guo@intel.com>, qi.z.zhang@intel.com,
jingjing.wu@intel.com,
beilei.xing@intel.com, dev@dpdk.org, jeroendb@google.com, jrkim@google.com,
Xiaoyun Li <xiaoyun.li@intel.com>
Content-Type: multipart/alternative; boundary="00000000000033c11105f3bf8848"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
--00000000000033c11105f3bf8848
Content-Type: text/plain; charset="UTF-8"
Tested-by: Joshua Washington <joshwash@google.com>
On Tue, Jan 31, 2023 at 2:05 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> On 1/31/2023 1:51 AM, Joshua Washington wrote:
> > Hello,
> >
> > I tested it out, and the updates to testpmd seem to work.
> >
>
> Hi Joshua,
>
> Thanks for testing, I will send a patch soon.
>
> But this was testpmd issue, do you have any objection with the net/gve
> patch, if not can you please record this with ack/review/tested-by tags,
> so I can proceed with it.
>
> > Before applying the second patch:
> > ---------------------- Forward statistics for port 0
> > ----------------------
> > RX-packets: 0 RX-dropped: 0 RX-total: 0
> > TX-packets: 43769238 TX-dropped: 62634 TX-total: 43831872
> >
> >
> ----------------------------------------------------------------------------
> >
> > ---------------------- Forward statistics for port 1
> > ----------------------
> > RX-packets: 0 RX-dropped: 0 RX-total: 0
> > TX-packets: 43761119 TX-dropped: 70753 TX-total: 43831872
> >
> >
> ----------------------------------------------------------------------------
> >
> > +++++++++++++++ Accumulated forward statistics for all
> > ports+++++++++++++++
> > RX-packets: 0 RX-dropped: 0 RX-total: 0
> > TX-packets: 87530357 TX-dropped: 157302 TX-total: 87687659
> >
> >
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > 62634 + 70753 = 133387 != 157302
> >
> > After applying the second patch:
> > ---------------------- Forward statistics for port 0
> > ----------------------
> > RX-packets: 0 RX-dropped: 0 RX-total: 0
> > TX-packets: 12590721 TX-dropped: 36638 TX-total: 12627359
> >
> >
> ----------------------------------------------------------------------------
> >
> > ---------------------- Forward statistics for port 1
> > ----------------------
> > RX-packets: 0 RX-dropped: 0 RX-total: 0
> > TX-packets: 12596255 TX-dropped: 31746 TX-total: 12628001
> >
> >
> ----------------------------------------------------------------------------
> >
> > +++++++++++++++ Accumulated forward statistics for all
> > ports+++++++++++++++
> > RX-packets: 0 RX-dropped: 0 RX-total: 0
> > TX-packets: 25186976 TX-dropped: 68384 TX-total: 25255360
> >
> >
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > Thanks,
> > Josh
> >
> > On Wed, Jan 18, 2023 at 8:22 AM Ferruh Yigit <ferruh.yigit@amd.com
> > <mailto:ferruh.yigit@amd.com>> wrote:
> >
> > On 12/19/2022 7:38 PM, Joshua Washington wrote:
> > > Hello,
> > >
> > > As it turns out, this error actually propagates to the "total"
> > stats as
> > > well, which I assume is just calculated by adding TX-packets and
> > > TX-dropped. Here are the full stats from the example that Rushil
> > mentioned:
> > >
> > > ---------------------- Forward statistics for port 0
> > > ----------------------
> > > RX-packets: 2453802 RX-dropped: 0 RX-total:
> > 2453802
> > > TX-packets: 34266881 TX-dropped: 447034 TX-total:
> > 34713915
> > >
> > >
> >
> ----------------------------------------------------------------------------
> > >
> > > ---------------------- Forward statistics for port 1
> > > ----------------------
> > > RX-packets: 34713915 RX-dropped: 0 RX-total:
> > 34713915
> > > TX-packets: 2453802 TX-dropped: 0 TX-total:
> > 2453802
> > >
> > >
> >
> ----------------------------------------------------------------------------
> > >
> > > +++++++++++++++ Accumulated forward statistics for all
> > > ports+++++++++++++++
> > > RX-packets: 37167717 RX-dropped: 0 RX-total:
> > 37167717
> > > TX-packets: 36720683 TX-dropped: 807630 TX-total:
> > 37528313
> > >
> > >
> >
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> > > It can be seen that the stats for the individual ports are
> consistent,
> > > but the TX-total and TX-dropped are not consistent with the stats
> for
> > > the individual ports, as I believe that the TX-total and RX-total
> > > accumulated stats should be equal.
> > >
> >
> > Hi Joshua, Rushil,
> >
> > As I checked for it, issue may be related to testpmd stats display,
> >
> > While displaying per port TX-dropped value, it only takes
> > 'ports_stats[pt_id].tx_dropped' into account,
> > but for accumulated TX-dropped results it takes both
> > 'ports_stats[pt_id].tx_dropped' & 'stats.oerrors' into account.
> >
> > If you can reproduce it easily, can you please test with following
> > change:
> >
> > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> > index 134d79a55547..49322d07d7d6 100644
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -2056,6 +2056,8 @@ fwd_stats_display(void)
> > fwd_cycles += fs->core_cycles;
> > }
> > for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) {
> > + uint64_t tx_dropped = 0;
> > +
> > pt_id = fwd_ports_ids[i];
> > port = &ports[pt_id];
> >
> > @@ -2077,8 +2079,9 @@ fwd_stats_display(void)
> > total_recv += stats.ipackets;
> > total_xmit += stats.opackets;
> > total_rx_dropped += stats.imissed;
> > - total_tx_dropped += ports_stats[pt_id].tx_dropped;
> > - total_tx_dropped += stats.oerrors;
> > + tx_dropped += ports_stats[pt_id].tx_dropped;
> > + tx_dropped += stats.oerrors;
> > + total_tx_dropped += tx_dropped;
> > total_rx_nombuf += stats.rx_nombuf;
> >
> > printf("\n %s Forward statistics for port %-2d
> %s\n",
> > @@ -2105,8 +2108,8 @@ fwd_stats_display(void)
> >
> > printf(" TX-packets: %-14"PRIu64" TX-dropped:
> > %-14"PRIu64
> > "TX-total: %-"PRIu64"\n",
> > - stats.opackets,
> ports_stats[pt_id].tx_dropped,
> > - stats.opackets +
> ports_stats[pt_id].tx_dropped);
> > + stats.opackets, tx_dropped,
> > + stats.opackets + tx_dropped);
> >
> > if (record_burst_stats) {
> > if (ports_stats[pt_id].rx_stream)
> >
> >
> > >
> > > On Mon, Dec 19, 2022 at 11:17 AM Rushil Gupta <rushilg@google.com
> > <mailto:rushilg@google.com>
> > > <mailto:rushilg@google.com <mailto:rushilg@google.com>>> wrote:
> > >
> > > Hi all
> > > Josh just found out some inconsistencies in the Tx/Rx
> > statistics sum
> > > for all ports. Not sure if we can screenshot here but it goes
> like
> > > this:
> > > Tx-dropped for port0: 447034
> > > Tx-dropped for port1: 0
> > > Accumulated forward statistics for all ports: 807630
> > >
> > > Please note that this issue is only with Tx-dropped (not
> > > Tx-packets/Tx-total).
> > >
> > >
> > > On Wed, Dec 7, 2022 at 8:39 AM Stephen Hemminger
> > > <stephen@networkplumber.org
> > <mailto:stephen@networkplumber.org>
> > <mailto:stephen@networkplumber.org
> > <mailto:stephen@networkplumber.org>>> wrote:
> > > >
> > > > On Wed, 7 Dec 2022 15:09:08 +0000
> > > > Ferruh Yigit <ferruh.yigit@amd.com
> > <mailto:ferruh.yigit@amd.com> <mailto:ferruh.yigit@amd.com
> > <mailto:ferruh.yigit@amd.com>>>
> > > wrote:
> > > >
> > > > > On 11/24/2022 7:33 AM, Junfeng Guo wrote:
> > > > > > Add support for dev_ops of stats_get and stats_reset.
> > > > > >
> > > > > > Queue stats update will be moved into xstat [1], but the
> > basic
> > > stats
> > > > > > items may still be required. So we just keep the
> remaining
> > > ones and
> > > > > > will implement the queue stats via xstats in the coming
> > release.
> > > > > >
> > > > > > [1]
> > > > > > https://elixir.bootlin.com/dpdk/v22.07/
> > <https://elixir.bootlin.com/dpdk/v22.07/>
> > > <https://elixir.bootlin.com/dpdk/v22.07/
> > <https://elixir.bootlin.com/dpdk/v22.07/>> \
> > > > > > source/doc/guides/rel_notes/deprecation.rst#L118
> > > > > >
> > > > > > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com
> > <mailto:xiaoyun.li@intel.com>
> > > <mailto:xiaoyun.li@intel.com <mailto:xiaoyun.li@intel.com>>>
> > > > > > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com
> > <mailto:junfeng.guo@intel.com>
> > > <mailto:junfeng.guo@intel.com <mailto:junfeng.guo@intel.com>>>
> > > > >
> > > > > <...>
> > > > >
> > > > > > +static int
> > > > > > +gve_dev_stats_get(struct rte_eth_dev *dev, struct
> > > rte_eth_stats *stats)
> > > > > > +{
> > > > > > + uint16_t i;
> > > > > > +
> > > > > > + for (i = 0; i < dev->data->nb_tx_queues; i++) {
> > > > > > + struct gve_tx_queue *txq =
> > dev->data->tx_queues[i];
> > > > > > + if (txq == NULL)
> > > > > > + continue;
> > > > > > +
> > > > > > + stats->opackets += txq->packets;
> > > > > > + stats->obytes += txq->bytes;
> > > > > > + stats->oerrors += txq->errors;
> > > > >
> > > > > Hi Junfeng, Qi, Jingjing, Beilei,
> > > > >
> > > > > Above logic looks wrong to me, did you test it?
> > > > >
> > > > > If the 'gve_dev_stats_get()' called multiple times (without
> > > stats reset
> > > > > in between), same values will be keep added to stats.
> > > > > Some hw based implementations does this, because reading
> > from stats
> > > > > registers automatically reset those registers but this
> > shouldn't
> > > be case
> > > > > for this driver.
> > > > >
> > > > > I expect it to be something like:
> > > > >
> > > > > local_stats = 0
> > > > > foreach queue
> > > > > local_stats += queue->stats
> > > > > stats = local_stats
> > > >
> > > > The zero of local_stats is unnecessary.
> > > > The only caller of the PMD stats_get is rte_ethdev_stats_get
> > > > and it zeros the stats structure before calling the PMD.
> > > >
> > > >
> > > > int
> > > > rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats
> *stats)
> > > > {
> > > > struct rte_eth_dev *dev;
> > > >
> > > > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
> > > > dev = &rte_eth_devices[port_id];
> > > >
> > > > memset(stats, 0, sizeof(*stats));
> > > > ...
> > > > stats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;
> > > > return eth_err(port_id,
> (*dev->dev_ops->stats_get)(dev,
> > > stats));
> > > >
> > > > If any PMD has extra memset in their stats get that could be
> > removed.
> > >
> > >
> > >
> > > --
> > >
> > > Joshua Washington | Software Engineer | joshwash@google.com
> > <mailto:joshwash@google.com>
> > > <mailto:joshwash@google.com <mailto:joshwash@google.com>> | (414)
> > 366-4423 <tel:(414)%20366-4423>
> > >
> >
> >
> >
> > --
> >
> > Joshua Washington | Software Engineer | joshwash@google.com
> > <mailto:joshwash@google.com> | (414) 366-4423
> >
>
>
--
Joshua Washington | Software Engineer | joshwash@google.com | (414) 366-4423
--00000000000033c11105f3bf8848
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Tested-by: Joshua Washington <<a href=3D"mailto:joshwas=
h@google.com">joshwash@google.com</a>></div><br><div class=3D"gmail_quot=
e"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jan 31, 2023 at 2:05 AM Fe=
rruh Yigit <<a href=3D"mailto:ferruh.yigit@amd.com">ferruh.yigit@amd.com=
</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">=
On 1/31/2023 1:51 AM, Joshua Washington wrote:<br>
> Hello,<br>
> <br>
> I tested it out, and the updates to testpmd seem to work.<br>
> <br>
<br>
Hi Joshua,<br>
<br>
Thanks for testing, I will send a patch soon.<br>
<br>
But this was testpmd issue, do you have any objection with the net/gve<br>
patch, if not can you please record this with ack/review/tested-by tags,<br=
>
so I can proceed with it.<br>
<br>
> Before applying the second patch:<br>
> =C2=A0 ---------------------- Forward statistics for port 0<br>
> =C2=A0----------------------<br>
> =C2=A0 RX-packets: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0R=
X-dropped: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RX-total: 0<br>
> =C2=A0 TX-packets: 43769238 =C2=A0 =C2=A0 =C2=A0 TX-dropped: 62634 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 TX-total: 43831872<br>
> =C2=A0<br>
> ----------------------------------------------------------------------=
------<br>
> <br>
> =C2=A0 ---------------------- Forward statistics for port 1<br>
> =C2=A0----------------------<br>
> =C2=A0 RX-packets: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0R=
X-dropped: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RX-total: 0<br>
> =C2=A0 TX-packets: 43761119 =C2=A0 =C2=A0 =C2=A0 TX-dropped: 70753 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 TX-total: 43831872<br>
> =C2=A0<br>
> ----------------------------------------------------------------------=
------<br>
> <br>
> =C2=A0 +++++++++++++++ Accumulated forward statistics for all<br>
> ports+++++++++++++++<br>
> =C2=A0 RX-packets: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0R=
X-dropped: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RX-total: 0<br>
> =C2=A0 TX-packets: 87530357 =C2=A0 =C2=A0 =C2=A0 TX-dropped: 157302 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0TX-total: 87687659<br>
> =C2=A0<br>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++=
++++++<br>
> <br>
> 62634=C2=A0+ 70753 =3D 133387 !=3D 157302<br>
> <br>
> After applying the second patch:<br>
> =C2=A0 ---------------------- Forward statistics for port 0<br>
> =C2=A0----------------------<br>
> =C2=A0 RX-packets: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0R=
X-dropped: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RX-total: 0<br>
> =C2=A0 TX-packets: 12590721 =C2=A0 =C2=A0 =C2=A0 TX-dropped: 36638 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 TX-total: 12627359<br>
> =C2=A0<br>
> ----------------------------------------------------------------------=
------<br>
> <br>
> =C2=A0 ---------------------- Forward statistics for port 1<br>
> =C2=A0----------------------<br>
> =C2=A0 RX-packets: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0R=
X-dropped: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RX-total: 0<br>
> =C2=A0 TX-packets: 12596255 =C2=A0 =C2=A0 =C2=A0 TX-dropped: 31746 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 TX-total: 12628001<br>
> =C2=A0<br>
> ----------------------------------------------------------------------=
------<br>
> <br>
> =C2=A0 +++++++++++++++ Accumulated forward statistics for all<br>
> ports+++++++++++++++<br>
> =C2=A0 RX-packets: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0R=
X-dropped: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RX-total: 0<br>
> =C2=A0 TX-packets: 25186976 =C2=A0 =C2=A0 =C2=A0 TX-dropped: 68384 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 TX-total: 25255360<br>
> =C2=A0<br>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++=
++++++<br>
> <br>
> Thanks,<br>
> Josh<br>
> <br>
> On Wed, Jan 18, 2023 at 8:22 AM Ferruh Yigit <<a href=3D"mailto:fer=
ruh.yigit@amd.com" target=3D"_blank">ferruh.yigit@amd.com</a><br>
> <mailto:<a href=3D"mailto:ferruh.yigit@amd.com" target=3D"_blank">f=
erruh.yigit@amd.com</a>>> wrote:<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0On 12/19/2022 7:38 PM, Joshua Washington wrote:<br>
>=C2=A0 =C2=A0 =C2=A0> Hello,<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0> As it turns out, this error actually propagate=
s to the "total"<br>
>=C2=A0 =C2=A0 =C2=A0stats as<br>
>=C2=A0 =C2=A0 =C2=A0> well,=C2=A0which I assume is just calculated b=
y adding TX-packets and<br>
>=C2=A0 =C2=A0 =C2=A0> TX-dropped. Here are the full stats from the e=
xample that Rushil<br>
>=C2=A0 =C2=A0 =C2=A0mentioned:<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 ---------------------- Forward statisti=
cs for port 0<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0----------------------<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 RX-packets: 2453802 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0RX-dropped: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RX-total:=
<br>
>=C2=A0 =C2=A0 =C2=A02453802<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 TX-packets: 34266881 =C2=A0 =C2=A0 =C2=
=A0 TX-dropped: 447034 =C2=A0 =C2=A0 =C2=A0 =C2=A0TX-total:<br>
>=C2=A0 =C2=A0 =C2=A034713915<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0---------------------------------------------------=
-------------------------<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 ---------------------- Forward statisti=
cs for port 1<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0----------------------<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 RX-packets: 34713915 =C2=A0 =C2=A0 =C2=
=A0 RX-dropped: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RX-total:<br>
>=C2=A0 =C2=A0 =C2=A034713915<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 TX-packets: 2453802 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0TX-dropped: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 TX-total:=
<br>
>=C2=A0 =C2=A0 =C2=A02453802<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0---------------------------------------------------=
-------------------------<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 +++++++++++++++ Accumulated forward sta=
tistics for all<br>
>=C2=A0 =C2=A0 =C2=A0> ports+++++++++++++++<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 RX-packets: 37167717 =C2=A0 =C2=A0 =C2=
=A0 RX-dropped: 0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RX-total:<br>
>=C2=A0 =C2=A0 =C2=A037167717<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0 TX-packets: 36720683 =C2=A0 =C2=A0 =C2=
=A0 TX-dropped: 807630 =C2=A0 =C2=A0 =C2=A0 =C2=A0TX-total:<br>
>=C2=A0 =C2=A0 =C2=A037528313<br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0+++++++++++++++++++++++++++++++++++++++++++++++++++=
+++++++++++++++++++++++++<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0> It can be seen that the stats for the individu=
al ports are consistent,<br>
>=C2=A0 =C2=A0 =C2=A0> but the TX-total and TX-dropped are not consis=
tent with the stats for<br>
>=C2=A0 =C2=A0 =C2=A0> the individual ports,=C2=A0as I believe that t=
he TX-total and RX-total<br>
>=C2=A0 =C2=A0 =C2=A0> accumulated stats should be equal.<br>
>=C2=A0 =C2=A0 =C2=A0><br>
> <br>
>=C2=A0 =C2=A0 =C2=A0Hi Joshua, Rushil,<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0As I checked for it, issue may be related to testpm=
d stats display,<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0While displaying per port TX-dropped value, it only=
takes<br>
>=C2=A0 =C2=A0 =C2=A0'ports_stats[pt_id].tx_dropped' into accoun=
t,<br>
>=C2=A0 =C2=A0 =C2=A0but for accumulated TX-dropped results it takes bot=
h<br>
>=C2=A0 =C2=A0 =C2=A0'ports_stats[pt_id].tx_dropped' & '=
stats.oerrors' into account.<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0If you can reproduce it easily, can you please test=
with following<br>
>=C2=A0 =C2=A0 =C2=A0change:<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0diff --git a/app/test-pmd/testpmd.c b/app/tes=
t-pmd/testpmd.c<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0index 134d79a55547..49322d07d7d6 100644<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0--- a/app/test-pmd/testpmd.c<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0+++ b/app/test-pmd/testpmd.c<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0@@ -2056,6 +2056,8 @@ fwd_stats_display(void)=
<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fwd_cycles +=3D fs->core_cycles=
;<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for (i =3D 0; i &=
lt; cur_fwd_config.nb_fwd_ports; i++) {<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0uint64_t tx_dropped =3D 0;<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0+<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0pt_id =3D fwd_ports_ids[i];<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0port =3D &ports[pt_id];<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0@@ -2077,8 +2079,9 @@ fwd_stats_display(void)=
<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0total_recv +=3D stats.ipackets;<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0total_xmit +=3D stats.opackets;<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0total_rx_dropped +=3D stats.imissed;<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0total_tx_dropped +=3D ports_stats[pt_id].tx_dropped;<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0total_tx_dropped +=3D stats.oerrors;<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0tx_dropped +=3D ports_stats[pt_id].tx_dropped;<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0tx_dropped +=3D stats.oerrors;<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0total_tx_dropped +=3D tx_dropped;<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0total_rx_nombuf=C2=A0 +=3D stats.rx_nombuf;<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0printf("\n=C2=A0 %s Forward statistics for port %-2d %s\n=
",<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0@@ -2105,8 +2108,8 @@ fwd_stats_display(void)=
<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0printf("=C2=A0 TX-packets: %-14"PRIu64" TX-drop=
ped:<br>
>=C2=A0 =C2=A0 =C2=A0%-14"PRIu64<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "TX-total: %-"PRIu64"\n&q=
uot;,<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 stats.opackets, ports_stats[pt_id].tx_dr=
opped,<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 stats.opackets + ports_stats[pt_id].tx_d=
ropped);<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 stats.opackets, tx_dropped,<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 stats.opackets + tx_dropped);<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0if (record_burst_stats) {<br>
>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (ports_stats[pt_id].rx_stream)<=
br>
> <br>
> <br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0> On Mon, Dec 19, 2022 at 11:17 AM Rushil Gupta =
<<a href=3D"mailto:rushilg@google.com" target=3D"_blank">rushilg@google.=
com</a><br>
>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailto:rushilg@google.com" ta=
rget=3D"_blank">rushilg@google.com</a>><br>
>=C2=A0 =C2=A0 =C2=A0> <mailto:<a href=3D"mailto:rushilg@google.co=
m" target=3D"_blank">rushilg@google.com</a> <mailto:<a href=3D"mailto:ru=
shilg@google.com" target=3D"_blank">rushilg@google.com</a>>>> wrot=
e:<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0Hi all<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0Josh just found out some in=
consistencies in the Tx/Rx<br>
>=C2=A0 =C2=A0 =C2=A0statistics sum<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0for all ports. Not sure if =
we can screenshot here but it goes like<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0this:<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0Tx-dropped for port0: 44703=
4<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0Tx-dropped for port1: 0<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0Accumulated forward statist=
ics for all ports: 807630<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0Please note that this issue=
is only with Tx-dropped (not<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0Tx-packets/Tx-total).<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0On Wed, Dec 7, 2022 at 8:39=
AM Stephen Hemminger<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0<<a href=3D"mailto:steph=
en@networkplumber.org" target=3D"_blank">stephen@networkplumber.org</a><br>
>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailto:stephen@networkplumber=
.org" target=3D"_blank">stephen@networkplumber.org</a>><br>
>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailto:stephen@networkplumber=
.org" target=3D"_blank">stephen@networkplumber.org</a><br>
>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailto:stephen@networkplumber=
.org" target=3D"_blank">stephen@networkplumber.org</a>>>> wrote:<b=
r>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> On Wed, 7 Dec 2022 15:=
09:08 +0000<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> Ferruh Yigit <<a hr=
ef=3D"mailto:ferruh.yigit@amd.com" target=3D"_blank">ferruh.yigit@amd.com</=
a><br>
>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailto:ferruh.yigit@amd.com" =
target=3D"_blank">ferruh.yigit@amd.com</a>> <mailto:<a href=3D"mailto=
:ferruh.yigit@amd.com" target=3D"_blank">ferruh.yigit@amd.com</a><br>
>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailto:ferruh.yigit@amd.com" =
target=3D"_blank">ferruh.yigit@amd.com</a>>>><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0wrote:<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > On 11/24/2022 7:3=
3 AM, Junfeng Guo wrote:<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > Add support =
for dev_ops of stats_get and stats_reset.<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > ><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > Queue stats =
update will be moved into xstat [1], but the<br>
>=C2=A0 =C2=A0 =C2=A0basic<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0stats<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > items may st=
ill be required. So we just keep the remaining<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0ones and<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > will impleme=
nt the queue stats via xstats in the coming<br>
>=C2=A0 =C2=A0 =C2=A0release.<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > ><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > [1]<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > <a href=3D"h=
ttps://elixir.bootlin.com/dpdk/v22.07/" rel=3D"noreferrer" target=3D"_blank=
">https://elixir.bootlin.com/dpdk/v22.07/</a><br>
>=C2=A0 =C2=A0 =C2=A0<<a href=3D"https://elixir.bootlin.com/dpdk/v22.=
07/" rel=3D"noreferrer" target=3D"_blank">https://elixir.bootlin.com/dpdk/v=
22.07/</a>><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0<<a href=3D"https://elix=
ir.bootlin.com/dpdk/v22.07/" rel=3D"noreferrer" target=3D"_blank">https://e=
lixir.bootlin.com/dpdk/v22.07/</a><br>
>=C2=A0 =C2=A0 =C2=A0<<a href=3D"https://elixir.bootlin.com/dpdk/v22.=
07/" rel=3D"noreferrer" target=3D"_blank">https://elixir.bootlin.com/dpdk/v=
22.07/</a>>> \<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > >=C2=A0 =C2=A0=
=C2=A0source/doc/guides/rel_notes/deprecation.rst#L118<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > ><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > Signed-off-b=
y: Xiaoyun Li <<a href=3D"mailto:xiaoyun.li@intel.com" target=3D"_blank"=
>xiaoyun.li@intel.com</a><br>
>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailto:xiaoyun.li@intel.com" =
target=3D"_blank">xiaoyun.li@intel.com</a>><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailt=
o:xiaoyun.li@intel.com" target=3D"_blank">xiaoyun.li@intel.com</a> <mail=
to:<a href=3D"mailto:xiaoyun.li@intel.com" target=3D"_blank">xiaoyun.li@int=
el.com</a>>>><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > Signed-off-b=
y: Junfeng Guo <<a href=3D"mailto:junfeng.guo@intel.com" target=3D"_blan=
k">junfeng.guo@intel.com</a><br>
>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailto:junfeng.guo@intel.com"=
target=3D"_blank">junfeng.guo@intel.com</a>><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailt=
o:junfeng.guo@intel.com" target=3D"_blank">junfeng.guo@intel.com</a> <ma=
ilto:<a href=3D"mailto:junfeng.guo@intel.com" target=3D"_blank">junfeng.guo=
@intel.com</a>>>><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> ><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > <...><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> ><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +static int<=
br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +gve_dev_sta=
ts_get(struct rte_eth_dev *dev, struct<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0rte_eth_stats *stats)<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +{<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +=C2=A0 =C2=
=A0uint16_t i;<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +=C2=A0 =C2=
=A0for (i =3D 0; i < dev->data->nb_tx_queues; i++) {<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct gve_tx_queue *txq =3D<br>
>=C2=A0 =C2=A0 =C2=A0dev->data->tx_queues[i];<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (txq =3D=3D NULL)<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0continue;<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0stats->opackets +=3D txq->packets;<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0stats->obytes +=3D txq->bytes;<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > > +=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0stats->oerrors +=3D txq->errors;<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> ><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > Hi Junfeng, Qi, J=
ingjing, Beilei,<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> ><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > Above logic looks=
wrong to me, did you test it?<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> ><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > If the 'gve_d=
ev_stats_get()' called multiple times (without<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0stats reset<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > in between), same=
values will be keep added to stats.<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > Some hw based imp=
lementations does this, because reading<br>
>=C2=A0 =C2=A0 =C2=A0from stats<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > registers automat=
ically reset those registers but this<br>
>=C2=A0 =C2=A0 =C2=A0shouldn't<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0be case<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > for this driver.<=
br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> ><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > I expect it to be=
something like:<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> ><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > local_stats =3D 0=
<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > foreach queue<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> >=C2=A0 =C2=A0 =C2=
=A0 =C2=A0local_stats +=3D queue->stats<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> > stats =3D local_s=
tats<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> The zero of local_stat=
s is unnecessary.<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> The only caller of the=
PMD stats_get is rte_ethdev_stats_get<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> and it zeros the stats=
structure before calling the PMD.<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> int<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> rte_eth_stats_get(uint=
16_t port_id, struct rte_eth_stats *stats)<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> {<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0struct rte_eth_dev *dev;<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0dev =3D &rte_eth_devices[port_id];<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0memset(stats, 0, sizeof(*stats));<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> ...<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0stats->rx_nombuf =3D dev->data->rx_mbuf_alloc_failed;=
<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0return eth_err(port_id, (*dev->dev_ops->stats_get)(dev,<=
br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0stats));<br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0> If any PMD has extra m=
emset in their stats get that could be<br>
>=C2=A0 =C2=A0 =C2=A0removed.<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0> --<br>
>=C2=A0 =C2=A0 =C2=A0><br>
>=C2=A0 =C2=A0 =C2=A0> Joshua Washington=C2=A0|=C2=A0Software Enginee=
r |=C2=A0<a href=3D"mailto:joshwash@google.com" target=3D"_blank">joshwash@=
google.com</a><br>
>=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailto:joshwash@google.com" t=
arget=3D"_blank">joshwash@google.com</a>><br>
>=C2=A0 =C2=A0 =C2=A0> <mailto:<a href=3D"mailto:joshwash@google.c=
om" target=3D"_blank">joshwash@google.com</a> <mailto:<a href=3D"mailto:=
joshwash@google.com" target=3D"_blank">joshwash@google.com</a>>>=C2=
=A0|=C2=A0(414)<br>
>=C2=A0 =C2=A0 =C2=A0366-4423 <tel:(414)%20366-4423><br>
>=C2=A0 =C2=A0 =C2=A0> =C2=A0<br>
> <br>
> <br>
> <br>
> -- <br>
> <br>
> Joshua Washington=C2=A0|=C2=A0Software Engineer |=C2=A0<a href=3D"mail=
to:joshwash@google.com" target=3D"_blank">joshwash@google.com</a><br>
> <mailto:<a href=3D"mailto:joshwash@google.com" target=3D"_blank">jo=
shwash@google.com</a>>=C2=A0|=C2=A0<a href=3D"tel:(414)%20366-4423" valu=
e=3D"+14143664423" target=3D"_blank">(414) 366-4423</a><br>
> =C2=A0<br>
<br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
class=3D"gmail_signature"><div dir=3D"ltr"><br><div style=3D"line-height:1=
.5em;padding-top:10px;margin-top:10px;color:rgb(85,85,85);font-family:sans-=
serif"><span style=3D"border-width:2px 0px 0px;border-style:solid;border-co=
lor:rgb(213,15,37);padding-top:2px;margin-top:2px">Joshua Washington=C2=A0|=
</span><span style=3D"border-width:2px 0px 0px;border-style:solid;border-co=
lor:rgb(51,105,232);padding-top:2px;margin-top:2px">=C2=A0Software Engineer=
|</span><span style=3D"border-width:2px 0px 0px;border-style:solid;border-=
color:rgb(0,153,57);padding-top:2px;margin-top:2px">=C2=A0<a href=3D"mailto=
:joshwash@google.com" target=3D"_blank">joshwash@google.com</a>=C2=A0|</spa=
n><span style=3D"border-width:2px 0px 0px;border-style:solid;border-color:r=
gb(238,178,17);padding-top:2px;margin-top:2px">=C2=A0(414) 366-4423</span><=
/div><span style=3D"color:rgb(0,0,0);font-family:Tinos;font-size:medium">=
=C2=A0</span><br></div></div>
--00000000000033c11105f3bf8848--