From: Michael Barker <mikeb01@gmail.com>
To: Ray Kinsella <mdr@ashroe.eu>
Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [PATCH v4] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if.
Date: Mon, 31 Jan 2022 13:10:47 +1300 [thread overview]
Message-ID: <CALwNKeTNj1g0G_iAU0Jz3DuKQ2aNJoeSWD4-ry1XzcOS7L-qUQ@mail.gmail.com> (raw)
In-Reply-To: <87h79srtp9.fsf@mdr78.vserver.site>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
>
> > +++ b/lib/eal/include/rte_compat.h
> > @@ -33,8 +33,11 @@ section(".text.internal")))
> > #elif !defined ALLOW_INTERNAL_API && __has_attribute(diagnose_if) /*
> > For clang */
>
> Why doesn't the __has_attribute take care of this?
> I would have thought that gcc would check the for the attribute, find it
> doesn't support it and ignore the whole thing?
>
It appears that the '-Wgcc-compat' check is too naive and doesn't pick up
the `__has_attribute` or `#if __clang__` and realise that there isn't
really a compatibility issue with the code.
Mike.
[-- Attachment #2: Type: text/html, Size: 1018 bytes --]
next prev parent reply other threads:[~2022-01-31 0:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 23:14 [PATCH] " Michael Barker
2022-01-17 23:23 ` [PATCH v2] " Michael Barker
2022-01-20 14:16 ` Thomas Monjalon
2022-01-23 21:17 ` Michael Barker
2022-01-23 23:53 ` Stephen Hemminger
2022-01-23 21:07 ` [PATCH v3] " Michael Barker
2022-01-23 21:20 ` [PATCH v4] " Michael Barker
2022-01-23 23:55 ` Stephen Hemminger
2022-01-31 0:08 ` Michael Barker
2022-01-25 10:33 ` Ray Kinsella
2022-01-31 0:10 ` Michael Barker [this message]
2022-01-31 0:05 ` [PATCH v5] " Michael Barker
2022-02-12 14:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwNKeTNj1g0G_iAU0Jz3DuKQ2aNJoeSWD4-ry1XzcOS7L-qUQ@mail.gmail.com \
--to=mikeb01@gmail.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).