From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com [209.85.214.169]) by dpdk.org (Postfix) with ESMTP id 56B503975 for ; Tue, 25 Nov 2014 16:17:59 +0100 (CET) Received: by mail-ob0-f169.google.com with SMTP id vb8so590064obc.28 for ; Tue, 25 Nov 2014 07:28:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=2fzjsmKdMo9mqIC3TobC8Dtq116e65j+CQN29anZcDg=; b=gUBjshDFeyhyWaSWdxQNHFs9j/wWkhTlf0EncU/ICynHnKmaMhO1HJIryfH5ayY1Te ifIFpdXqzuIGKfAEJph3o8Tb6PE5hNpzOOCoO9t8C1H6rzJGWeWBIZEfj17Cqe6paShF Ud70Nyd6r7XhTtNoqtDGejsYHWlj1PYN6lTlMXZrQAhwyI/tZi7SPi+FnTPJk6xO7U70 VMh/0GMfYWYhzas2BJQiyJlNtJKm7QZtzCokb6FZ9rGSJEtfWNm5J4lDYPk6L9JEd31Z 2TaWHYU0lUD9Hj6Xp8Xvt+/WmHITwOeoOoJL4sw//Q1JDKFf8eXyFabFUYvufpCcl+8F xWfQ== X-Gm-Message-State: ALoCoQn6DuZCzS1iB9QCQazzenggNeldDLY8NBc3oN8apoCK8mHa9G2j+2/+7ATk1Qa0NoT/nE6T MIME-Version: 1.0 X-Received: by 10.182.76.2 with SMTP id g2mr16343057obw.8.1416929331611; Tue, 25 Nov 2014 07:28:51 -0800 (PST) Received: by 10.202.60.197 with HTTP; Tue, 25 Nov 2014 07:28:51 -0800 (PST) In-Reply-To: <1416959145-7694-1-git-send-email-ssujith@cisco.com> References: <1416959145-7694-1-git-send-email-ssujith@cisco.com> Date: Tue, 25 Nov 2014 16:28:51 +0100 Message-ID: From: David Marchand To: Sujith Sankar Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" , "Prasad Rao \(prrao\)" Subject: Re: [dpdk-dev] [PATCH v5 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 15:17:59 -0000 Sujith, - Sorry, I still have one problem with the patchset. Your patches do not pass checkpatch. I can see indent problems, trailing whitespaces etc... Can you fix this ? - Also, look at patch 6/6, there is a problem with the build option (see my other mail). Thanks for the effort. -- David Marchand On Wed, Nov 26, 2014 at 12:45 AM, Sujith Sankar wrote: > ENIC PMD is the poll-mode driver for the Cisco Systems Inc. VIC to be > used with DPDK suite. > > Sujith Sankar (6): > enicpmd: License text > enicpmd: Makefile > enicpmd: VNIC common code partially shared with ENIC kernel mode > driver > enicpmd: pmd specific code > enicpmd: DPDK-ENIC PMD interface > enicpmd: DPDK changes for accommodating ENIC PMD > > config/common_linuxapp | 5 + > lib/Makefile | 1 + > lib/librte_pmd_enic/LICENSE | 27 + > lib/librte_pmd_enic/Makefile | 67 ++ > lib/librte_pmd_enic/enic.h | 157 ++++ > lib/librte_pmd_enic/enic_clsf.c | 244 ++++++ > lib/librte_pmd_enic/enic_compat.h | 142 ++++ > lib/librte_pmd_enic/enic_etherdev.c | 613 +++++++++++++++ > lib/librte_pmd_enic/enic_main.c | 1266 > ++++++++++++++++++++++++++++++ > lib/librte_pmd_enic/enic_res.c | 221 ++++++ > lib/librte_pmd_enic/enic_res.h | 168 ++++ > lib/librte_pmd_enic/vnic/cq_desc.h | 126 +++ > lib/librte_pmd_enic/vnic/cq_enet_desc.h | 261 ++++++ > lib/librte_pmd_enic/vnic/rq_enet_desc.h | 76 ++ > lib/librte_pmd_enic/vnic/vnic_cq.c | 117 +++ > lib/librte_pmd_enic/vnic/vnic_cq.h | 152 ++++ > lib/librte_pmd_enic/vnic/vnic_dev.c | 1063 +++++++++++++++++++++++++ > lib/librte_pmd_enic/vnic/vnic_dev.h | 202 +++++ > lib/librte_pmd_enic/vnic/vnic_devcmd.h | 774 ++++++++++++++++++ > lib/librte_pmd_enic/vnic/vnic_enet.h | 78 ++ > lib/librte_pmd_enic/vnic/vnic_intr.c | 83 ++ > lib/librte_pmd_enic/vnic/vnic_intr.h | 126 +++ > lib/librte_pmd_enic/vnic/vnic_nic.h | 88 +++ > lib/librte_pmd_enic/vnic/vnic_resource.h | 97 +++ > lib/librte_pmd_enic/vnic/vnic_rq.c | 246 ++++++ > lib/librte_pmd_enic/vnic/vnic_rq.h | 282 +++++++ > lib/librte_pmd_enic/vnic/vnic_rss.c | 85 ++ > lib/librte_pmd_enic/vnic/vnic_rss.h | 61 ++ > lib/librte_pmd_enic/vnic/vnic_stats.h | 86 ++ > lib/librte_pmd_enic/vnic/vnic_wq.c | 245 ++++++ > lib/librte_pmd_enic/vnic/vnic_wq.h | 283 +++++++ > lib/librte_pmd_enic/vnic/wq_enet_desc.h | 114 +++ > mk/rte.app.mk | 4 + > 33 files changed, 7560 insertions(+) > create mode 100644 lib/librte_pmd_enic/LICENSE > create mode 100644 lib/librte_pmd_enic/Makefile > create mode 100644 lib/librte_pmd_enic/enic.h > create mode 100644 lib/librte_pmd_enic/enic_clsf.c > create mode 100644 lib/librte_pmd_enic/enic_compat.h > create mode 100644 lib/librte_pmd_enic/enic_etherdev.c > create mode 100644 lib/librte_pmd_enic/enic_main.c > create mode 100644 lib/librte_pmd_enic/enic_res.c > create mode 100644 lib/librte_pmd_enic/enic_res.h > create mode 100644 lib/librte_pmd_enic/vnic/cq_desc.h > create mode 100644 lib/librte_pmd_enic/vnic/cq_enet_desc.h > create mode 100644 lib/librte_pmd_enic/vnic/rq_enet_desc.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_cq.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_cq.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_dev.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_dev.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_devcmd.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_enet.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_intr.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_intr.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_nic.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_resource.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_rq.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_rq.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_rss.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_rss.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_stats.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_wq.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_wq.h > create mode 100644 lib/librte_pmd_enic/vnic/wq_enet_desc.h > > -- > 1.9.1 > >