From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com
 [209.85.214.181]) by dpdk.org (Postfix) with ESMTP id 9DFCB2EDA
 for <dev@dpdk.org>; Tue,  9 Feb 2016 09:31:28 +0100 (CET)
Received: by mail-ob0-f181.google.com with SMTP id is5so178926376obc.0
 for <dev@dpdk.org>; Tue, 09 Feb 2016 00:31:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc:content-type;
 bh=a44qVgt1x779Pz/ZAnqb2zC4wlzjsPD8jLAqoB24Zu0=;
 b=CWIzDRPjsEkstcsU0VSjI/yVgKWSXWtYyeR+0IpV8YdGqTdtPntU1QXZYcink7A+t9
 ojpE4f52h2wWknjq9h/X4muuxWIxBbctE8JS5VX/6tUz47e4XKpyZv4zGebtaOMQVTX/
 52Sr6nb5+sJlZXWojc/HhRImzkAUtcxX0guW3MGakqQYT+lM0nGcgniW6+0eQDCTa2sN
 8uSZUUOq6g2OIpSIO+eV/Eikm3f3+RH/Em3nxA6H0H7IU3Vb60+bkEmthWyllQ8UbiZS
 VUCh+OChzkLJEkP8wrcng1H2CCfN92VBCa8CCcHyNCAoycwJAVTZ2/CbQCml9Ib3FQpE
 RVuw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc:content-type;
 bh=a44qVgt1x779Pz/ZAnqb2zC4wlzjsPD8jLAqoB24Zu0=;
 b=UDQGT00E3tbo5PRwQ//B8Vh9PNbE9XgyjDXkoBcECaz2CInqz3NtoHfAgb8YyhMbCO
 w4MGLIaOFgdT8E0auPIzuVkR0+zYWgc6lgi+ox8E3A610T/tqXNxUTmaDj2viuSMzff3
 4W5BDqf03KtC3wjRyH7RmU2u0lUn+9ymiNT8YYb8Kf0CTl63VuvyII1gsnGYVRCa6tMx
 0+h+xR0yRbYhv5Ttm596s5GWqNzjLTtrVTOyyI7SKJoriqB4iZ/8Urf3erq4tsr7LBwh
 p7MbJj5HfLeFjQ13SX0ginB3xqk4vami8z8lKs8RSuJ8TY1RPNE6onNv+ySmuc+uOHbs
 xrGA==
X-Gm-Message-State: AG10YOSdNujO3zHFtu/6KrSbFcuMjLq7drvPaShDE8B0z11WxjZj1q3xSOjPGWuDoZVMk4C3UJgwUezDwalLqgy7
X-Received: by 10.182.153.166 with SMTP id vh6mr28303751obb.76.1455006688035; 
 Tue, 09 Feb 2016 00:31:28 -0800 (PST)
MIME-Version: 1.0
Received: by 10.76.180.72 with HTTP; Tue, 9 Feb 2016 00:31:08 -0800 (PST)
In-Reply-To: <56B9627E.6080904@igel.co.jp>
References: <1454694945-18040-1-git-send-email-david.marchand@6wind.com>
 <1454831317-4542-1-git-send-email-david.marchand@6wind.com>
 <1454831317-4542-5-git-send-email-david.marchand@6wind.com>
 <56B9627E.6080904@igel.co.jp>
From: David Marchand <david.marchand@6wind.com>
Date: Tue, 9 Feb 2016 09:31:08 +0100
Message-ID: <CALwxeUs-vj=AMRRDGW_7PmDBBC8TCiYsO5bXpmTkQmaM_eX7zw@mail.gmail.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 4/4] virtio: use pci ioport api
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Feb 2016 08:31:29 -0000

On Tue, Feb 9, 2016 at 4:52 AM, Tetsuya Mukawa <mukawa@igel.co.jp> wrote:
> On 2016/02/07 16:48, David Marchand wrote:
> One more legacy_virtio_resource_init() is defined like below.
>
> #ifdef RTE_EXEC_ENV_LINUXAPP
> <snip>
> #else
> <snip>
> static int
> legacy_virtio_resource_init(struct rte_pci_device *pci_dev __rte_unused)
> {
>         /* no setup required */
>         return 0;
> }
> #endif
>
> Should we change this also?

Yes, I noticed this while doing the patches but forgot to update ...
Thanks.

In the end, I think that we end up with common code in this case for
both bsd and linux.

The only thing remaining in virtio that depends on "#ifdef os" is the
msix detection.
I do not have time to look at this, so I suppose this will have to wait.


-- 
David Marchand