From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f193.google.com (mail-io0-f193.google.com [209.85.223.193]) by dpdk.org (Postfix) with ESMTP id 3DDCADE0 for ; Wed, 30 May 2018 18:04:52 +0200 (CEST) Received: by mail-io0-f193.google.com with SMTP id t5-v6so9662315ioa.8 for ; Wed, 30 May 2018 09:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=XfQ6oQRan7dQiSTOky1CyIbND1lznWNYSeqC21IYwY8=; b=BMCeuvDMaG62ViFydtt1g49IH+fKLR8ADxyNqj476516mD2A8ysPMufQNOxMjv9e65 LU3t8BVy3ONaQR2fXqPKQ9jrbK0FLUeE300gSNh3RPKmgjUxdHnh9t+V6KTaqD7rQ0wu xc8T/WFZSkJRZpsWI7oTH497bacaZG5LUy/krg4NlJ43whXAgThASfxe9Ckw21f6vUZf OLabic7SQZSdkpIXcecX+ANumDKdx6fC+3DY5sVBo/J7ZRHChc971LyXxDCXFM9DCO38 rA/TT5NBfa9CZDwKzWkUtYeh4e7jDx8/dn39jtFGAVrcBWAmg8lx8uebi+R17jXpkbHm KscQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XfQ6oQRan7dQiSTOky1CyIbND1lznWNYSeqC21IYwY8=; b=e2jZQFp+172H0K2c/ICUkNzhnzj2W7f0nhNxFdemFIYUbbqMSHzpYelBZbQX29P6Cf zhc/RLcdlUpO3Xttx0FCODH/Z5xj2Q/9zulGg3VhqshnOgbcGpK8gceUThO+YPpProFP OK7NuJ+WcBid2n6bsACITO+2tV5WDeINJ64lss7g9l3iboCBOhzwZrcouHS1yPIk72Ws /+Kt31OcnewIgg65b4evYprZ1aPrj7+zXGn9yVjQV56vEG/LqVSmJD8Ny6hufMI3YY0b h2cTYZp6pUoBAMnIf3/Ld03/WveCIaOckAGpiCQKtnOw3mxGG/w/vBmuKxxseSDsBl1r wYqg== X-Gm-Message-State: APt69E2VOHQAKdYaSkDxyvbwFNwucV//+/W7tGIng37t5281K7Kckv/y t+8bUKK+lTB1CvGGM5GnnnIv2ZWBZJwmt4JV/PRyrA== X-Google-Smtp-Source: ADUXVKLdrROMpFUlA+oyL8fmLAoYbS2EjmiPQ23AlnQJj8gJKiGuG0brxnlfTz3VyjeIx09/LM4rul8mriwemUPOeyk= X-Received: by 2002:a6b:fa18:: with SMTP id p24-v6mr2736342ioh.134.1527696291459; Wed, 30 May 2018 09:04:51 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:9916:0:0:0:0:0 with HTTP; Wed, 30 May 2018 09:04:31 -0700 (PDT) In-Reply-To: <73FA6D64-52F7-4273-971E-6A1579073631@mellanox.com> References: <20180530144253.8935-1-david.marchand@6wind.com> <73FA6D64-52F7-4273-971E-6A1579073631@mellanox.com> From: David Marchand Date: Wed, 30 May 2018 18:04:31 +0200 Message-ID: To: Yongseok Koh Cc: "dev@dpdk.org" , Adrien Mazarguil , =?UTF-8?Q?N=C3=A9lio_Laranjeiro?= , Thomas Monjalon , Shahaf Shuler Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: only register memory callback when probing a device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 16:04:52 -0000 On Wed, May 30, 2018 at 5:59 PM, Yongseok Koh wrote: >> On May 30, 2018, at 7:42 AM, David Marchand wrote: >> >> The callback should be invoked only for memory that has been registered >> in a device, hence, no need to track cleanup events if no device is >> present. >> >> Bugzilla-ID: 56 >> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") >> >> Signed-off-by: David Marchand >> --- > > Good finding! Thank you so much for the patch. > Patch is good. Just to be sure, I've run traffic with testpmd and also run > multi-process test examples with traffic. It runs well. > > Acked-by: Yongseok Koh Well, this is a quick fix, the mlx5_prepare_shared_data() now does more than initialising the shared data... Might be better to revisit later, but this should do the job for 18.05. Thanks. -- David Marchand