From: David Marchand <david.marchand@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/bsd: fix core detection
Date: Wed, 8 Oct 2014 13:23:49 +0200 [thread overview]
Message-ID: <CALwxeUs7Ocszg=VxxfectL+JrxA7=_6_BGUspB9XMovSqViebQ@mail.gmail.com> (raw)
In-Reply-To: <20141008105355.GA5045@hmsreliant.think-freely.org>
Hello Neil,
On Wed, Oct 8, 2014 at 12:53 PM, Neil Horman <nhorman@tuxdriver.com> wrote:
>
> Though, that said, why are these files diverged in the first place? At
> least as
> far as eal_lcore.c and eal.c are concerned the only differences appear to
> be
> cases of one file being updated and not the other. It seems that, rather
> than
> doing a patch like this to bring bsd up to date with linux, we should just
> de-dup the files, put them in a common location and handle any real
> behavioral
> differences with macros/ifdefs. Is there a reason for separating them?
>
I agree that there should only be one file for those things (and a lot of
other stuff like eal_debug, eal_log etc...).
This is not that easy: I tried once and gave up because the resulting
patchset was huge.
Personally, I don't have time to dig into this.
--
David Marchand
next prev parent reply other threads:[~2014-10-08 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 8:43 David Marchand
2014-10-08 9:20 ` Bruce Richardson
2014-10-08 10:10 ` Zhan, Zhaochen
2014-10-09 18:24 ` Thomas Monjalon
2014-10-08 10:53 ` Neil Horman
2014-10-08 11:23 ` David Marchand [this message]
2014-10-08 19:17 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUs7Ocszg=VxxfectL+JrxA7=_6_BGUspB9XMovSqViebQ@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).