From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id 40E5E5594 for ; Fri, 26 Feb 2016 16:01:09 +0100 (CET) Received: by mail-oi0-f50.google.com with SMTP id j125so64121810oih.0 for ; Fri, 26 Feb 2016 07:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=easuXl7S/GdhcYAUMJA/Vzy7AX1wt1S+pNyQQU/aego=; b=GTFgGrCo/vrR9lLJAsk0/vHjKqIsQIfkXIzhikvSpGffb7UiVfbLZfmcKTNSxNmlf0 1e4QnUlUvayUBoxVUvq5ftgPb+Uj74XoBHkCWduCJ/I6pd9UqZ8mNTCwjEKbCrXpWvWW olL02pvMnrufaoIQOlzeP66vzKxSnHTcKFPbYaI+/5qQUtzE717VKMqkjhZGkGgkfvEL wWbSqpAiunWvBhNkNEOz9qhvAt33LnRyGcsVhdvmNrCrEoAa49/cFXVFUYTxsQd4pgo4 S+BFQd2IxCGayTNuk1/BlKcY9GvgFeWE4ueoa2WcarOVvl99viPlPRca5Y0UECFHojl1 BgwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=easuXl7S/GdhcYAUMJA/Vzy7AX1wt1S+pNyQQU/aego=; b=gNwt5bI9A4ooNQWmfgq5nhOinvKxtvmkVJjDsnTgWGA+ptuULKPaGlzWer8kGgNela 4wjvSZ+t2NGsqtVhhUfIT+wZ8P+9dMuGSldnkCEkYuG+AP7TMnti3HC3obYwOk9i1VLN /6ZQ+3TBho70qlSDBGdIpWwb+0Hdp/Fxexfa4VBBio3zDbAQKnjKfaFk2nKdL7y6/NKD VtUJUSOlebM9YAYK+45GnGfMVkRNelVCDZcx2nZm/046VOv1Yp0zh8KhJfSuBnMnIc4O u2Q6CaMVY2ZoWwuSwgYUMFRcxJMKXHALGiWfwiaaSWMf4znJ+Vsxihk3Ojfh0cBvUbTe 7oxA== X-Gm-Message-State: AD7BkJLHyBMGvuH+vFrldhVAxCasAwQPwA8tud9iS1AG0EPTUzjCPOhAuoZaUwI3eV+mXjuZN5vspuEbyvEWqxi/ X-Received: by 10.202.214.78 with SMTP id n75mr1415178oig.51.1456498868688; Fri, 26 Feb 2016 07:01:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Fri, 26 Feb 2016 07:00:49 -0800 (PST) In-Reply-To: <20160226144852.GC21628@bricha3-MOBL3> References: <1454410216-13333-2-git-send-email-xiao.w.wang@intel.com> <20160225161406.GA22772@bricha3-MOBL3> <4126401.C51dJZWCEs@xps13> <20160226144852.GC21628@bricha3-MOBL3> From: David Marchand Date: Fri, 26 Feb 2016 16:00:49 +0100 Message-ID: To: Bruce Richardson Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 15:01:09 -0000 On Fri, Feb 26, 2016 at 3:48 PM, Bruce Richardson wrote: > On Fri, Feb 26, 2016 at 09:24:06AM +0000, Wang, Xiao W wrote: >> Hi, >> > > Thanks for the discussion, Thomas, do you have any suggestions? >> > >> > I don't understand why you say this feature is specific to fm10k. Can we >> > imagine another NIC having this capability? >> >> As you know, fm10k has a switch logic between the Mac and Phy, every packets >> Sent out from the host will be switched inside the NIC, other NICs don't have >> a switch inside, and the FTAG feature is related to the switch function. >> >> As introduced in the second patch: >> The FM10K family of NICs support the addition of a Fabric Tag (FTAG) to carry >> special information. The FTAG is placed at the beginning of the frame, it contains >> information such as where the packet comes from and goes, and the vlan tag. In >> FTAG based forwarding mode, the switch logic forwards packets according to >> glort (global resource tag) information, rather than the mac and vlan table. >> So this is a feature specific to fm10k. > > If it is fm10k specific, how about just adding a public function to the fm10k > driver to turn it on. The user app will be non-portable across NICs, but > that's the price of using nic-specific features. What about using a devargs ? Something like : -w xxxx:xx:xx.x,enable_ftag=1 The application still needs to know about this to enable it, but that sounds better to me. The only issue is that it can't work with hotplug at the moment. -- David Marchand