From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f196.google.com (mail-io0-f196.google.com [209.85.223.196]) by dpdk.org (Postfix) with ESMTP id 9A1A71E90A for ; Tue, 12 Jun 2018 09:10:13 +0200 (CEST) Received: by mail-io0-f196.google.com with SMTP id d185-v6so26876178ioe.0 for ; Tue, 12 Jun 2018 00:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BScBiLHjz08Ben724ltm1CQ3q8Ll6p49Gjf819fDvbo=; b=Qvng+ANfF9oXPxsXvq3jlm5czxO1kS4bIh/hf4okQ/TvhGqoDPj4aJpDMIVdiaSTcM 1qZv9rRbdK4Dhiq4QLwuzPv43ZmXwIWLtYZbr0w5zjxc540Go3WewozybxobqTNKvD4P Lccl6zll7XkG2usfwgQ3lmGzI9jgbc6GBQSA3xUfgUADJo1jRe1sSO9aPVI+2aB6/E0n PMWaTqkmtu36uUupyYBa7/sPPNG3NCaTLATP5HnWAjoi9APli+iEibdoFI5NVGmKPoQD 459DiiYIdklt7gXGbL6bTJP5aaZO+6oEdQ0VePYE0OWlVJhsTXOOdfhzhGZLuwo2+g8w 90Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BScBiLHjz08Ben724ltm1CQ3q8Ll6p49Gjf819fDvbo=; b=ixJmC7wiOgg7IhZYxPw3PfvCHDeJPZu6hhmn7bXNH2X2GXEQjdu3TJemRpIH9wj4UU QUWjfOvp2MabVq0MdpRVC6jDRt3H12bxKkV5Oq6PZV8tUftO2BfINe1yrKwoMQdQf9yi ZZtMutc2j7wCE1BcDwKHfLq7AMib5/iivcn1gZQgS1olu4DRf4kEIj/C8TOiJSnnRqqd L+ObnoqhpOc31yqoJLs54O0kyEQO3cmMMBM/YV2JbLCkjfXnPGJ1TqWvIdI0mVnrjydr iLasbpQTteVFDV4MnVyr4espWtvAFNy45mHp6GkLbqVaU/79RBDj7dK0cHH7ap4hVnla bEOQ== X-Gm-Message-State: APt69E0p9ir2I+ek3/ZVoMtNGXfLMN5cV/vP9qWtA6Y6s8DjD5QfLXTS vYeYxT0xJZioApf1kBlYdA+WCL3u0N5DYQKdqHdz0A== X-Google-Smtp-Source: ADUXVKL0owGixrK9plDanu2azod7JGryKXQADXJkEKHBtT7Qnam0krJT8X2xbVEqj2OrO/yZI+QXVI6kY0i6DDkmdq0= X-Received: by 2002:a6b:6f0b:: with SMTP id k11-v6mr2328628ioc.62.1528787413220; Tue, 12 Jun 2018 00:10:13 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:b610:0:0:0:0:0 with HTTP; Tue, 12 Jun 2018 00:09:52 -0700 (PDT) In-Reply-To: <1528359323-22885-1-git-send-email-david.marchand@6wind.com> References: <1528359323-22885-1-git-send-email-david.marchand@6wind.com> From: David Marchand Date: Tue, 12 Jun 2018 09:09:52 +0200 Message-ID: To: remy.horton@intel.com, "Iremonger, Bernard" , "Wu, Jingjing" , "Lu, Wenzhuo" Cc: stable@dpdk.org, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add sanity checks when retrieving xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 07:10:14 -0000 Hey guys, On Thu, Jun 7, 2018 at 10:15 AM, David Marchand wrote: > Testpmd should not expect the xstats names and values arrays to be > aligned: neither the arrays sizes, nor the order in which the values are. > > This hid some bugs where pmds would either return wrong values count or > invalid statistics indexes. > > Link: http://dpdk.org/browse/dpdk/commit/?id=5fd4d049692b2fde8bf49c7461b18180a8fd2545 > Link: http://dpdk.org/dev/patchwork/patch/40705/ > > Signed-off-by: David Marchand > --- > > @stable: when this goes in, I recommend backporting this to all existing > branches, as it makes it easier to show this kind of pmds bugs. Can someone have a look please ? Thanks. -- David Marchand