From: David Marchand <david.marchand@6wind.com>
To: Patrick McGleenon <Patrick.McGleenon@owmobility.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] kni: error building with kernel < 3.3 and ether_addr_equal backport
Date: Wed, 5 Mar 2014 17:00:55 +0100 [thread overview]
Message-ID: <CALwxeUsDPpkrdb-ft_55T0ite92=Tp_1QL72mg8Nvk8bzuhiCw@mail.gmail.com> (raw)
In-Reply-To: <9cfac239bfe0489d901fe0158ff227ec@BLUPR05MB200.namprd05.prod.outlook.com>
Hello Patrick,
I encountered this problem as well, we are currently working on a fix.
I have a few concerns, see below, but if you address them, feel free to
contribute a new patch.
On Wed, Mar 5, 2014 at 2:32 PM, Patrick McGleenon <
Patrick.McGleenon@owmobility.com> wrote:
> [..]
> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> index a404c9f..f6f6635 100644
> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> @@ -3528,11 +3528,12 @@ extern void _kc_skb_add_rx_frag(struct sk_buff *,
> int, struct page *,
>
> /*****************************************************************************/
> #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,5,0) )
> #define skb_tx_timestamp(skb) do {} while (0)
> -static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
> +static inline bool kni_ether_addr_equal(const u8 *addr1, const u8 *addr2)
> {
> return !compare_ether_addr(addr1, addr2);
> }
> #else
> +typedef ether_addr_equal kni_ether_addr_equal;
> #define HAVE_FDB_OPS
> #define HAVE_ETHTOOL_GET_TS_INFO
> #endif /* < 3.5.0 */
>
I am not sure this typedef will work.
Did you try to build on kernels >= 3.5 ?
> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h
> b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h
> index 3fb6b14..45f6c4c 100644
> --- a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h
> +++ b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h
> @@ -3107,11 +3107,12 @@ typedef netdev_features_t kni_netdev_features_t;
>
>
> /*****************************************************************************/
> #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,5,0) )
> -static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
> +static inline bool kni_ether_addr_equal(const u8 *addr1, const u8 *addr2)
> {
> return !compare_ether_addr(addr1, addr2);
> }
> #else
> +typedef ether_addr_equal kni_ether_addr_equal;
> #define HAVE_FDB_OPS
> #endif /* < 3.5.0 */
>
Same comment.
Regards,
--
David Marchand
next prev parent reply other threads:[~2014-03-05 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 13:32 Patrick McGleenon
2014-03-05 16:00 ` David Marchand [this message]
2014-03-06 14:53 ` Patrick McGleenon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUsDPpkrdb-ft_55T0ite92=Tp_1QL72mg8Nvk8bzuhiCw@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=Patrick.McGleenon@owmobility.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).