From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f54.google.com (mail-oi0-f54.google.com [209.85.218.54]) by dpdk.org (Postfix) with ESMTP id 99286ADB3 for ; Tue, 24 Feb 2015 12:23:15 +0100 (CET) Received: by mail-oi0-f54.google.com with SMTP id v63so18679682oia.13 for ; Tue, 24 Feb 2015 03:23:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=bCCKs5fZfHADtw2+7bmftaQ3rPmah7O5CCYo5kEKucM=; b=EkglQSrGbQsQ9UGe+e1mAWTVSPsEYbGizrd9z8rZSDkADqrN2b4zhJZYajEeEMS/0/ +UE1PF5FZ3rg+0rx+aH5lZKyJ6OL8OCAEJIy8YgxPulIw1SWqoXGC8f3K57mjjO8WgsG f4ffPJQkG+0VMzKB5czUEQ53uLzUMT5gh25QlSAXQ0qwotdCV83Zz8aBbX2NUnFl80IZ ManU/llDKpDBiZfdXIG5UD2AyPTmvsG1fdvlkIZSwCcT4fuW7DVinOyy9cIq9x24scxv Rkp6ASeL2zzkYylS1EEEf9+Udv3VAeXjLIb3ETvH2rFZOKmzSn374HHF4I9lkZloOnAk S8fQ== X-Gm-Message-State: ALoCoQnmhiF6/81PLFFocHwNws3rWyj0sKsmVYi11IL+TgRdJx3YKD+5Vk90YVEpN+C9CQ5lWfF+ MIME-Version: 1.0 X-Received: by 10.202.182.7 with SMTP id g7mr10055486oif.13.1424776995104; Tue, 24 Feb 2015 03:23:15 -0800 (PST) Received: by 10.76.133.162 with HTTP; Tue, 24 Feb 2015 03:23:15 -0800 (PST) In-Reply-To: <20150224105357.GD8416@bricha3-MOBL3> References: <1424703444-30761-1-git-send-email-bruce.richardson@intel.com> <1424710955-10896-1-git-send-email-bruce.richardson@intel.com> <20150224105357.GD8416@bricha3-MOBL3> Date: Tue, 24 Feb 2015 12:23:15 +0100 Message-ID: From: David Marchand To: Bruce Richardson Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 11:23:16 -0000 Hello Bruce, On Tue, Feb 24, 2015 at 11:53 AM, Bruce Richardson < bruce.richardson@intel.com> wrote: > On Mon, Feb 23, 2015 at 05:02:33PM +0000, Bruce Richardson wrote: > > This patch does some cleanup of the uio mapping code to > > a) fix issue with mmap of PCI bars reported by Tetsuya and confirmed > > by others. > > b) eliminate redundant code and reduce scans of /sys > > > > > > Bruce Richardson (2): > > eal: mmap uio resources using resourceX files > > eal: populate uio_maps from pci mem_resources array > > > > lib/librte_eal/common/include/rte_pci.h | 2 +- > > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 + > > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 173 > +++++++++++------------------ > > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 1 + > > 4 files changed, 66 insertions(+), 111 deletions(-) > > > > -- > > 2.1.0 > > > Given your previous suggestions on the uio_pic_generic code, I'd appreciate > any feedback you could provide on this patchset. Well, I only have one pending question on the use of resourceX files instead of /dev/uioX. You rely on sysfs mmap code for pci resources. Is this really equivalent to uio mmap operations ? If you can ensure me this won't break igb_uio setups, then these patches are ok for me. Thanks for the cleanup in eal_pci_uio.c. -- David Marchand