From: David Marchand <david.marchand@6wind.com>
To: Sujith Sankar <ssujith@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, prrao@cisco.com
Subject: Re: [dpdk-dev] [PATCH v3 6/6] DPDK changes for accommodating ENIC PMD
Date: Mon, 24 Nov 2014 12:03:30 +0100 [thread overview]
Message-ID: <CALwxeUsQ4=jW-OB_AqXVHL8Rx7sAJt+qn8yTYDuW9j-r=e+afw@mail.gmail.com> (raw)
In-Reply-To: <1416758899-1351-7-git-send-email-ssujith@cisco.com>
Hello Sujith,
On Sun, Nov 23, 2014 at 5:08 PM, Sujith Sankar <ssujith@cisco.com> wrote:
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> index c776ddc..6bf8f2e 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> @@ -736,6 +736,7 @@ pci_vfio_map_resource(struct rte_pci_device *dev)
> maps[i].offset = reg.offset;
> maps[i].size = reg.size;
> dev->mem_resource[i].addr = bar_addr;
> + dev->mem_resource[i].len = reg.size;
> }
>
> /* if secondary process, do not set up interrupts */
>
Not sure I understand why you need to overwrite the length value.
This is supposed to be initialised before by "generic" code.
This looks like a hack or a workaround.
Can you elaborate on this change ?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2014-11-24 10:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 16:08 [dpdk-dev] [PATCH v3 0/6] Cisco Systems Inc. VIC Ethernet PMD - " Sujith Sankar
2014-11-23 16:08 ` [dpdk-dev] [PATCH v3 1/6] ENIC PMD License Sujith Sankar
2014-11-23 16:08 ` [dpdk-dev] [PATCH v3 2/6] ENIC PMD Makefile Sujith Sankar
2014-11-23 16:08 ` [dpdk-dev] [PATCH v3 3/6] VNIC common code partially shared with ENIC kernel mode driver Sujith Sankar
2014-11-23 16:08 ` [dpdk-dev] [PATCH v3 4/6] ENIC PMD specific code Sujith Sankar
2014-11-23 16:08 ` [dpdk-dev] [PATCH v3 5/6] DPDK-ENIC PMD interface Sujith Sankar
2014-11-23 16:08 ` [dpdk-dev] [PATCH v3 6/6] DPDK changes for accommodating ENIC PMD Sujith Sankar
2014-11-24 0:17 ` Neil Horman
2014-11-24 5:45 ` Sujith Sankar (ssujith)
2014-11-24 11:33 ` Neil Horman
2014-11-24 16:12 ` Sujith Sankar (ssujith)
2014-11-24 17:19 ` Neil Horman
2014-11-25 6:13 ` Sujith Sankar (ssujith)
2014-11-25 11:30 ` Neil Horman
2014-11-24 11:03 ` David Marchand [this message]
2014-11-24 15:51 ` Sujith Sankar (ssujith)
2014-11-24 16:15 ` David Marchand
2014-11-24 16:27 ` Sujith Sankar (ssujith)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUsQ4=jW-OB_AqXVHL8Rx7sAJt+qn8yTYDuW9j-r=e+afw@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=prrao@cisco.com \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).