From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f179.google.com (mail-ob0-f179.google.com
 [209.85.214.179]) by dpdk.org (Postfix) with ESMTP id E54BA8016
 for <dev@dpdk.org>; Mon, 24 Nov 2014 11:52:43 +0100 (CET)
Received: by mail-ob0-f179.google.com with SMTP id va2so6876467obc.24
 for <dev@dpdk.org>; Mon, 24 Nov 2014 03:03:31 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=e3WGsxGLZnxEWNm1uPb2bAuyBQBd1PsFeWzMdMpNkm8=;
 b=Shjh1KeIPqhFN9y1D90s5q5HulZYzOXOdWAL+TMRivCSlfZDCYtiU6hVuIqTHpNXCA
 YhZBWbQ/yMGFhJqpA7ADBFpKfKWulPkj6MKMe7GanHRZVSS34vlnZtgIG19wpo/V1QSt
 MIrLQ/M7zgXD1gsOHEpaAm6uMB2T7eCn90Ebd1thduMlG0/kIEvXtQv3oQ9z+3TNd9y0
 b6YX9EkgOU91TMTJcsvYqrcY7ErIPdjUqTGKxi/MPHnaCuJvfh0Yu1hE5Ta85fEEVZnX
 vYGVKURuyvb1WQgbPK1Ryy6hsb5Oa5hKDTEZkipWOuAzbE8ITwtsot63CXuvaV/BnMNl
 hPBg==
X-Gm-Message-State: ALoCoQliGbHsM28FRZyguzE39hcd9ty33Yt8/jpEd+/83KTmvN6tR/U4/royiW2LV6rPK3vc115d
MIME-Version: 1.0
X-Received: by 10.202.189.139 with SMTP id n133mr5905521oif.63.1416827010882; 
 Mon, 24 Nov 2014 03:03:30 -0800 (PST)
Received: by 10.202.60.197 with HTTP; Mon, 24 Nov 2014 03:03:30 -0800 (PST)
In-Reply-To: <1416758899-1351-7-git-send-email-ssujith@cisco.com>
References: <1416758899-1351-1-git-send-email-ssujith@cisco.com>
 <1416758899-1351-7-git-send-email-ssujith@cisco.com>
Date: Mon, 24 Nov 2014 12:03:30 +0100
Message-ID: <CALwxeUsQ4=jW-OB_AqXVHL8Rx7sAJt+qn8yTYDuW9j-r=e+afw@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Sujith Sankar <ssujith@cisco.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>, prrao@cisco.com
Subject: Re: [dpdk-dev] [PATCH v3 6/6] DPDK changes for accommodating ENIC
	PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Nov 2014 10:52:44 -0000

Hello Sujith,

On Sun, Nov 23, 2014 at 5:08 PM, Sujith Sankar <ssujith@cisco.com> wrote:

> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> index c776ddc..6bf8f2e 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> @@ -736,6 +736,7 @@ pci_vfio_map_resource(struct rte_pci_device *dev)
>                 maps[i].offset = reg.offset;
>                 maps[i].size = reg.size;
>                 dev->mem_resource[i].addr = bar_addr;
> +               dev->mem_resource[i].len = reg.size;
>         }
>
>         /* if secondary process, do not set up interrupts */
>

Not sure I understand why you need to overwrite the length value.
This is supposed to be initialised before by "generic" code.
This looks like a hack or a workaround.

Can you elaborate on this change ?
Thanks.


-- 
David Marchand