From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id 393D08E94 for ; Thu, 21 Jan 2016 19:07:11 +0100 (CET) Received: by mail-oi0-f50.google.com with SMTP id k206so32009873oia.1 for ; Thu, 21 Jan 2016 10:07:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=S23PBZTSuPaU0XohYjEvKRyFH102qKMpGrPr8yydqoU=; b=nhxO0Q096hhZgVbhEHtZ3pbEdyBtfIrOvWlaxG/nnIcC8pea8pG0dLRm2R1oYiA44n 6RVE+Y7QTXLCJRe9H541iKxS+TcP0LQeQtJG8ndpMHukekuhMRLRqpx0jCkMby9YEgfo qWJhdvTKhbFDS8YmHrtLelacLgMp1QVKX1J8l231VV9mVzMfSrhbKBBpTin6KU29ecEG 3/kguuE2kb8swQVIiBds4qs4jFOWo7xFC+4JaWFm7xSD+S6vqkF+uAm4XY2NWq6DH4vb 2xsmEAN/RIE6HgzeMTy5OnhXBJTA3D2je0/scjI9nEZwAqSSygo+GXA1opRrRO196W3M B3uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=S23PBZTSuPaU0XohYjEvKRyFH102qKMpGrPr8yydqoU=; b=kTWxiudemOsBBjKb/zAng+FF2fz+9BPU/UEtHW9TYGVW0xqSVPYUlhPQCUi4vVHmSP ZO94K3M1VXk5Q6cdQjvIC8Co9W5H3PwxDgIXja84us7aSu2FKbdlfVg1LADuEXBFYhH+ JMc6fqyTZd1LyD7/fQHKTtrjCSve7zY9Pw+L7xjzxtXV1S8adEieuGF+bg3Gx1x65m8y 8OGuEPSzKOaBTkFsZYQVakM42leUCcyrXqt36csVfkXBWuWZ0tfjsOveuvMVbhd7yqZa 74xcXMAfCVpqOiSa9wGoM+rCe0aBGxjm9nwsFhSKqxQuZCWrPr1H6duBdiQNUVdl95S1 Sgug== X-Gm-Message-State: ALoCoQmU0GxWf5Om3NeNHEkGfG8n6eFKZ24hRQc9/sxMgzZkzSzzQeZ06RlPF3HoQUTeVDP1oh41vswDwcZT4wTMo19D7CvWfSkEeOzR4nUsKXy4yT2i9wA= X-Received: by 10.202.175.22 with SMTP id y22mr30449975oie.22.1453399630651; Thu, 21 Jan 2016 10:07:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Thu, 21 Jan 2016 10:06:51 -0800 (PST) In-Reply-To: <20160121163836.0bcd405e@pcviktorin.fit.vutbr.cz> References: <1453377431-25850-3-git-send-email-david.marchand@6wind.com> <20160121163836.0bcd405e@pcviktorin.fit.vutbr.cz> From: David Marchand Date: Thu, 21 Jan 2016 19:06:51 +0100 Message-ID: To: Jan Viktorin , Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [dpdk-dev, 2/2] ethdev: move code to common place in hotplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2016 18:07:11 -0000 On Thu, Jan 21, 2016 at 4:38 PM, Jan Viktorin wrote: > On Thu, 21 Jan 2016 12:57:11 +0100 > David Marchand wrote: > [snip] >> @@ -612,14 +599,25 @@ int >> rte_eth_dev_attach(const char *devargs, uint8_t *port_id) >> { >> struct rte_pci_addr addr; >> + int ret = -1; >> >> if ((devargs == NULL) || (port_id == NULL)) >> - return -EINVAL; >> + goto err; > > This change modifies the return value from -EINVAL to -1. I don't know > whether is this an issue but it looks suspicious. Should not be an issue, as the api does not give details on expected negative return values. Just noticed, this also introduces a new log message that was not displayed before. To be safe, I suppose I should restore this. Thomas, opinion ? Thanks. -- David Marchand