From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-oi0-f51.google.com (mail-oi0-f51.google.com
 [209.85.218.51]) by dpdk.org (Postfix) with ESMTP id 96C616849
 for <dev@dpdk.org>; Fri, 10 Jul 2015 13:25:50 +0200 (CEST)
Received: by oibp128 with SMTP id p128so47840391oib.3
 for <dev@dpdk.org>; Fri, 10 Jul 2015 04:25:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=1FPrRI65VztScmQXtv+Df6zD9XF9iaJEzV6UG72+nc8=;
 b=PzPV9xGi6+t8vp8jVyEvDTPxmjxKjEs8Zbp6stfpsE4wIKAx3OWZKJ02uT1zG0wloI
 ufmIIzMp5d8e4YHWR7ijVQ4wef/t0vYv+SbSHOd5Hl3qJidwUy29jCvqjjGzfkWJifts
 Dwq5TQuV7AOZ4PNbbPaae/+7PzVjZjiUXng5arCR6Hoh2pSG6yYK2O+V0n511NZRW2Eq
 3NN4lHPH6OkZLO3h5NxEUL74opjclOdYRKH0ITpnmKhJzuDrQgB1InGN+OF1wwTQalw+
 wBT5K8GwvgpcKGqtDYI+x1YIS8l7H/mfOy6iU38F3zrqyVJHyTL1J0o2eLMqhCc0s8Ba
 3mrA==
X-Gm-Message-State: ALoCoQl4naP+/nor/QaT6HegrZ3vfCgIP38tiX3k+YbqDKqvE9BGNx6wIy7Swj79pCYJhi/MpJBI
MIME-Version: 1.0
X-Received: by 10.60.78.104 with SMTP id a8mr18496208oex.58.1436527549968;
 Fri, 10 Jul 2015 04:25:49 -0700 (PDT)
Received: by 10.76.84.233 with HTTP; Fri, 10 Jul 2015 04:25:49 -0700 (PDT)
In-Reply-To: <559F83AE.4050409@igel.co.jp>
References: <1436514439-4893-1-git-send-email-michael.qiu@intel.com>
 <559F83AE.4050409@igel.co.jp>
Date: Fri, 10 Jul 2015 13:25:49 +0200
Message-ID: <CALwxeUsTYhjXbsR8XeFuaYeA+nzMHj1esqb_D4nb+49xCD2K7A@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] BugFix: VFIO never works
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jul 2015 11:25:50 -0000

On Fri, Jul 10, 2015 at 10:34 AM, Tetsuya Mukawa <mukawa@igel.co.jp> wrote:

> On 2015/07/10 16:47, Michael Qiu wrote:
> > Commit 35b3313e322b ("pci: merge mapping functions for linux and bsd")
> >
> > introduced a bug that all vfio will be
> > blocked.
> >
> > Root cause is that VFIO_PRESENT is unaccessable in eal
> > common level.
> >
> > This patch is to fix this.
> >
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > ---
> >  lib/librte_eal/common/eal_common_pci.c     |  2 --
> >  lib/librte_eal/common/eal_private.h        |  3 +++
> >  lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 10 ++++++++++
> >  3 files changed, 13 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/librte_eal/common/eal_common_pci.c
> b/lib/librte_eal/common/eal_common_pci.c
> > index 3805aed..f3dc697 100644
> > --- a/lib/librte_eal/common/eal_common_pci.c
> > +++ b/lib/librte_eal/common/eal_common_pci.c
> > @@ -146,10 +146,8 @@ pci_map_device(struct rte_pci_device *dev)
> >       /* try mapping the NIC resources using VFIO if it exists */
> >       switch (dev->kdrv) {
> >       case RTE_KDRV_VFIO:
> > -#ifdef VFIO_PRESENT
> >               if (pci_vfio_is_enabled())
> >                       ret = pci_vfio_map_resource(dev);
> > -#endif
>

This is a common file, vfio is not available on BSD.
I missed that during review.

Did you test build on BSD ?


-- 
David Marchand