From: David Marchand <david.marchand@6wind.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: add missing long-options for short option arguments
Date: Fri, 18 Mar 2016 11:50:41 +0100 [thread overview]
Message-ID: <CALwxeUsXkCcz0b7m4rNuVBUXe8Ph2T4QTGnMmkhRpeT3x4_ugw@mail.gmail.com> (raw)
In-Reply-To: <8F006E73-FEAF-4782-8D88-0050FD97CC1A@intel.com>
On Thu, Mar 3, 2016 at 4:02 PM, Wiles, Keith <keith.wiles@intel.com> wrote:
>>On Thu, Feb 25, 2016 at 11:12 PM, Wiles, Keith <keith.wiles@intel.com> wrote:
>>>>On Thu, Feb 25, 2016 at 01:09:16PM -0600, Keith Wiles wrote:
>>>>> A number of short options for EAL are missing long options
>>>>> and this patch adds those missing options.
>>>>>
>>>>> The missing long options are for:
>>>>> -c add --coremask
>>>>> -d add --driver
>>>>> -l add --corelist
>>>>> -m add --memsize
>>>>> -n add --mem-channels
>>>>> -r add --mem-ranks
>>>>> -v add --version
>>>>> Add an alias for --lcores using --lcore-map
[snip]
>>No strong opinion on this.
>>
>>Just, why "memsize" with no - but "mem-channels" ?
>>And why cut down to mem rather than memory ?
>
> I debated on mem-size, but I noticed in a couple places some used memsize. I can change them to any thing someone wants. If you want memory-channels and memory-ranks I am good with that too.
Ok, since I can see no real argument against, let's go with explicit options :
--memory-size
--memory-channels
--memory-ranks
The best would be then to align all other existing long options (but
keeping compat with existing ones).
Deal ?
--
David Marchand
prev parent reply other threads:[~2016-03-18 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 19:09 Keith Wiles
2016-02-25 21:32 ` Bruce Richardson
2016-02-25 22:12 ` Wiles, Keith
2016-03-03 14:52 ` Wiles, Keith
2016-03-03 14:55 ` David Marchand
2016-03-03 15:02 ` Wiles, Keith
2016-03-18 10:50 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUsXkCcz0b7m4rNuVBUXe8Ph2T4QTGnMmkhRpeT3x4_ugw@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).