From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f172.google.com (mail-ob0-f172.google.com [209.85.214.172]) by dpdk.org (Postfix) with ESMTP id 0D29E2C5F for ; Fri, 18 Mar 2016 11:51:01 +0100 (CET) Received: by mail-ob0-f172.google.com with SMTP id fz5so112575271obc.0 for ; Fri, 18 Mar 2016 03:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YIouI/KKT+jBk4g0O76uknnDI/y57+7DXdvErRse0XY=; b=gL+PqAxP0vrDJCB2q8chngyxa7QB5OyPp1ut9+ObYcoqhihic17H9occ5s43fI+8eT RP+3wOJyvTcJvWgh8qrwNXNLJP3d5NWxsTlYbfZq1RKu9AMF03sWzUAxw8tkfvFBBSKL Qq5RaIlNejMDvk4t7KHHlqH42K/BB3Gdqbyx9EXvCtjw8FP/h7oRZAmXAi+UE4peyzHZ ARH0Hre50cI7vAEB+c1zsHQy5i24iTeUXtO1XhnNV8u6g9oJ0RMx49eP8AORyyIxdDby BTOne7dHr/JfwtoQ7qyDc+7rBK6UDMoiNh8eCxHlx2U5LHGemh6ure4nMYk8a4X8VCxh ph6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YIouI/KKT+jBk4g0O76uknnDI/y57+7DXdvErRse0XY=; b=KyI/c0A0VsrqC9X9c7lwWllZZJELkhFOxdf8vTE+hVGBqEs6f7m4EXAAYa8BGRr3ne STYMByomPtNasGS2JPsrtvYtPyCdFby/EbdFFDJcqW2JyI5YTTqFXRf+HQ55yKcoGqKI e2iLjGgAhIBTevgK6VcXsJNCUEnrEn2SjzXYFyMk9Z7UkV5HCZ3g8TeBwPlc3LJNxGVs YsuZ9UGUTmW2jN5Gfn58e3qTSTJofGsVSe+OxP2EbgRCpLxPBgroE1T2NrOiX5l8dBFz cgzvagvrvGEvgAm9ZPX70rLoE5BDTdAkzUugWDnie/P4WBIvfVmFOtrDKRZdzJ5W+3g2 i4KQ== X-Gm-Message-State: AD7BkJKEkV71+LWeLrXLo9RxILmEkVOqglqniaE1c7NP+ZIAi6pHVNYMOKSjn0HC5Y7H4HR/cdfJhs56+Od/k4IR X-Received: by 10.182.230.136 with SMTP id sy8mr9013932obc.76.1458298260407; Fri, 18 Mar 2016 03:51:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Fri, 18 Mar 2016 03:50:41 -0700 (PDT) In-Reply-To: <8F006E73-FEAF-4782-8D88-0050FD97CC1A@intel.com> References: <1456427356-67147-1-git-send-email-keith.wiles@intel.com> <20160225213203.GB14936@bricha3-MOBL3> <8F006E73-FEAF-4782-8D88-0050FD97CC1A@intel.com> From: David Marchand Date: Fri, 18 Mar 2016 11:50:41 +0100 Message-ID: To: "Wiles, Keith" Cc: "Richardson, Bruce" , "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] eal: add missing long-options for short option arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 10:51:01 -0000 On Thu, Mar 3, 2016 at 4:02 PM, Wiles, Keith wrote: >>On Thu, Feb 25, 2016 at 11:12 PM, Wiles, Keith wrote: >>>>On Thu, Feb 25, 2016 at 01:09:16PM -0600, Keith Wiles wrote: >>>>> A number of short options for EAL are missing long options >>>>> and this patch adds those missing options. >>>>> >>>>> The missing long options are for: >>>>> -c add --coremask >>>>> -d add --driver >>>>> -l add --corelist >>>>> -m add --memsize >>>>> -n add --mem-channels >>>>> -r add --mem-ranks >>>>> -v add --version >>>>> Add an alias for --lcores using --lcore-map [snip] >>No strong opinion on this. >> >>Just, why "memsize" with no - but "mem-channels" ? >>And why cut down to mem rather than memory ? > > I debated on mem-size, but I noticed in a couple places some used memsize. I can change them to any thing someone wants. If you want memory-channels and memory-ranks I am good with that too. Ok, since I can see no real argument against, let's go with explicit options : --memory-size --memory-channels --memory-ranks The best would be then to align all other existing long options (but keeping compat with existing ones). Deal ? -- David Marchand