From: David Marchand <david.marchand@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build
Date: Tue, 3 Mar 2015 10:12:19 +0100 [thread overview]
Message-ID: <CALwxeUscebzq7+iK4HrTrhA+Kf5yCF8sZz+RABx0=txs0D5Xbw@mail.gmail.com> (raw)
In-Reply-To: <1425372295-27839-1-git-send-email-thomas.monjalon@6wind.com>
On Tue, Mar 3, 2015 at 9:44 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> Compilation fails in some distributions because of missing unistd.h
> needed for pread/pwrite (seen with Suse):
> lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2:
> error: implicit declaration of function ‘pread’
>
> Fixes: 4a499c649590 ("eal/linux: enable uio_pci_generic support")
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> index 35d31c5..0b397ca 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> @@ -32,6 +32,7 @@
> */
>
> #include <string.h>
> +#include <unistd.h>
> #include <fcntl.h>
> #include <dirent.h>
> #include <sys/stat.h>
>
>
Acked-by: David Marchand <david.marchand@6wind.com>
--
David Marchand
next prev parent reply other threads:[~2015-03-03 9:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 8:44 Thomas Monjalon
2015-03-03 9:12 ` David Marchand [this message]
2015-03-03 22:23 ` Thomas Monjalon
2015-03-05 9:13 ` Qiu, Michael
2015-03-05 9:28 ` Ananyev, Konstantin
2015-03-05 9:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUscebzq7+iK4HrTrhA+Kf5yCF8sZz+RABx0=txs0D5Xbw@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).