From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f42.google.com (mail-oi0-f42.google.com [209.85.218.42]) by dpdk.org (Postfix) with ESMTP id F3C95B373 for ; Fri, 29 Aug 2014 09:41:18 +0200 (CEST) Received: by mail-oi0-f42.google.com with SMTP id v63so1357598oia.15 for ; Fri, 29 Aug 2014 00:45:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=8DaAgA+VnsZ/ztc8rQ8O6i7ChhyHscaFSWOC25zi10w=; b=VDVoU6qax4eLde7/qCRZMlmJAmqGkYsimvfIyTQ5EOQhYVTKsrpFzfqpdlYTYliXoA 5pDZCZb0YRDDijrtCwOs8R5DI/9z/ZhISgrhoduDkLyEopdDH3dBflE/HJBeNoKIuoqY e5z07BwnRejkWwZUjd4hiZDh/sltMt0u3bO+Fd+Tzx5cec8EZjkH/rLPE46JjnQeBTv9 ctqsJJl6nEFzHqCM/8LsqhB48ph4uosqX+LYpqkk2I5hywTD7SQ/c3netqSLA2ROl5R+ Y/LxxEpIcNrDqVyejFGRuKu6RR2YhCyFW9/yga4iU5OjTI+MSYh84KGwQwq87D76bZr6 SChA== X-Gm-Message-State: ALoCoQnbEbqQimTLsSvEaNGrraBvwTcQaeLP/nKJ7hSnzY/YG/lMspWU32HttohmjwmaZ5/EAN1V MIME-Version: 1.0 X-Received: by 10.182.111.229 with SMTP id il5mr8527936obb.3.1409298329575; Fri, 29 Aug 2014 00:45:29 -0700 (PDT) Received: by 10.202.73.74 with HTTP; Fri, 29 Aug 2014 00:45:29 -0700 (PDT) In-Reply-To: <20140827110657.557e0368@urahara> References: <1409062162-19575-1-git-send-email-david.marchand@6wind.com> <1409062162-19575-2-git-send-email-david.marchand@6wind.com> <20140827110657.557e0368@urahara> Date: Fri, 29 Aug 2014 09:45:29 +0200 Message-ID: From: David Marchand To: Stephen Hemminger Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 01/11] ixgbe: clean log messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2014 07:41:19 -0000 On Wed, Aug 27, 2014 at 8:06 PM, Stephen Hemminger < stephen@networkplumber.org> wrote: > On Wed, 27 Aug 2014 08:53:46 -0500 > Jay Rolette wrote: > > > The updated output is definitely an improvement, but if you'll go with > the > > first solution you described (adding \n in the log macro), it works much > > better for products using DPDK. For developer use, I think it ends up > being > > a wash either way. > > Also for driver consistency, all drivers must do the same thing. I.e the > PMD_INIT_LOG > macro should either add or not add newline in the same way in all drivers. > I fixed virtio and vmxnet3 by just taking extra newlines out of messages > and leaving the macro alone. > Not sure that we can talk about consistency at the moment ... (all the more so as if you only fixed two pmds). Anyway. If we go with this approach, there is still something that won't work. ixgbe shared code uses DEBUGOUT* macros which are called a lot in this shared code. The macros call sites use trailing \n. I suppose I will have a big NO from Intel guys if I remove the trailing \n, so I suppose we can use an alternate macro that calls RTE_LOG rather than PMD_DRV_LOG in ixgbe_os_dep.h. I will also remove any reference to DEBUGOUT* in non-shared code. >>From my point of view, these macro are only here for compat with shared code. By the way, did you look at the other patches of this series ? I want to send a v2 later (maybe not today), so any comment on the other patches are welcome. -- David Marchand