From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 3F3FDCC48 for ; Fri, 17 Jun 2016 17:56:42 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id a66so5525235wme.0 for ; Fri, 17 Jun 2016 08:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=F/tjkzYRSIczdD0QV0yPWVjpE64G0VdTqE3VG8V+KAo=; b=Ys+5kToJMrtbkjTEvUXR4z+xgfBgPzTz4n05LWFIFp3bZYbz6hRywc1uWU1ljJvCKN fQBTq4q/jQ1UfiG/laXaZGFpRzwMVqfzgBa0nEiMM/NiwHQRyKwwNXf3kuidA2LlE9ar VxfElZSaKAUvpw2ICc3GYfGawxeD3jggdGGCHnz0E9swbmW0X8C70GZb4Utr6+IdlU73 JRdEWHhZjxlm88qQCJFpEbaEtr9nWWrwXYV5TCgIPYxYrGmamfIJ/OV02OpwBuyZjQpE Svqs/43tAHZcFy7Rzxq3cetYNKoFXQfyJ8KIvmwf2GLHeqo1d9bmVQ2iJb3bhUlu5ejV xNgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=F/tjkzYRSIczdD0QV0yPWVjpE64G0VdTqE3VG8V+KAo=; b=EqwPD/2b9R7Xn1AN27npcG6Ur2ZqkwFyCcB0E6cI0aeWp24rQO2Y0S0h5+HrInXjLr bHoxJMfKnAfTIz5f9ucYKkIrdN8C7ZhzKHQ/dFXIdPRWZUFnUMkBc5PpQTB/5GxWbuHv 9WRAyzUCq4ph+7+fmOrVck0eN80Ou9I+t5FTaWFcRmrmYC01vNEflij9kxBuxyDYjGtg Vt180mWqawnofUzQB/Chs6NTP0icPVgox06GbayAEb4n3IHwnxAb5Ckya4amFQgMohaK TGIzwJ6pMEo6wBeuVcQ1yTGQwuoS2NbopAq0QFv/1nvBqojv1fga1CtX5O1fxzOqUaXR +1qw== X-Gm-Message-State: ALyK8tLzEchx4dNL2I3IkiUoEL4ienJK2r500MvQQw5OePSUcWK0eSimwMIZadpwgbtWXq2C1Hyiyf0mt45HoaCJ X-Received: by 10.28.47.71 with SMTP id v68mr373645wmv.49.1466179001954; Fri, 17 Jun 2016 08:56:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.16.13 with HTTP; Fri, 17 Jun 2016 08:56:22 -0700 (PDT) In-Reply-To: <1466177124-31709-1-git-send-email-thomas.monjalon@6wind.com> References: <1466177124-31709-1-git-send-email-thomas.monjalon@6wind.com> From: David Marchand Date: Fri, 17 Jun 2016 17:56:22 +0200 Message-ID: To: Thomas Monjalon Cc: reshma.pattan@intel.com, "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] eal: fix thread naming on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 15:56:42 -0000 On Fri, Jun 17, 2016 at 5:25 PM, Thomas Monjalon wrote: > rte_thread_setname was a macro defined only for Linux. > The function rte_thread_setname() can now be used on FreeBSD > as well on Linux. > It is required to build librte_pdump. > > The macro was 0 for old glibc. The function is now returning -1. > The related logs are decreased from error to debug level because > it is not an important failure, just a debug inconvenience. > > Fixes: 278f945402c5 ("pdump: add new library for packet capture") > > Signed-off-by: Thomas Monjalon [snip] > diff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h > index ac15130..1dcfba7 100644 > --- a/lib/librte_eal/common/include/rte_lcore.h > +++ b/lib/librte_eal/common/include/rte_lcore.h > @@ -250,23 +250,16 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp); > /** > * Set thread names. > * > - * Macro to wrap `pthread_setname_np()` with a glibc version check. > - * Only glibc >= 2.12 supports this feature. > + * @note Only glibc >= 2.12 supports this feature. This comment is a bit weird since, this only applies to Linux and not BSD, right ? The rest looks good to me. -- David Marchand