From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id 1FBC05A73 for ; Fri, 27 Mar 2015 13:44:18 +0100 (CET) Received: by oiag65 with SMTP id g65so74711930oia.2 for ; Fri, 27 Mar 2015 05:44:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=wSqh9xhe5OuXNFz3TCX+FTDeu1NJ1N7mK00CsIgoMnc=; b=e4MuWJXxVWRzv8XmfZbGtEgTKpOH2COfxyuZMv4d1l2SPBsa6tUNFUun15Y7VtzTiz UOcxT/TCuWoldYQtZNkrgrwpc4ocfSeUVJr+xUR8/Q9vDmvY+j261hdsYer56G09xdTf cFybqXqAKgX6kvK06+vhNWsyUxS4IlXXUUlmSpYgLIK6cP+3XWA75k4Igs79Wf7qT7oj DhrIiBEAQuB1CYO11c5DAIJvC53uia7KZT2Sp8RGFpJO5m2fWlegF8nPz4PqJRnaEl+K utIYwEVOkdQdROLkeFNUFHZD+IRpTNf6FhuSM/dyfUz9JhZqcNjYX0hH029Bs4DEh3a4 Q6KA== X-Gm-Message-State: ALoCoQngY83w3QJSpmmL064lezPzYUVWeQ7XI5yU6ODIJn4LN3aF6kBvpGSqwRrFausUzzdRNKyW MIME-Version: 1.0 X-Received: by 10.182.128.234 with SMTP id nr10mr15956866obb.62.1427460257486; Fri, 27 Mar 2015 05:44:17 -0700 (PDT) Received: by 10.76.34.35 with HTTP; Fri, 27 Mar 2015 05:44:17 -0700 (PDT) In-Reply-To: <20150323153341.081dd435@miho> References: <20150323153341.081dd435@miho> Date: Fri, 27 Mar 2015 13:44:17 +0100 Message-ID: From: David Marchand To: Simon Kagstrom Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] librte_eal: Allow combining --no-huge with -m XXX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 12:44:18 -0000 Hello Simon, On Mon, Mar 23, 2015 at 3:33 PM, Simon Kagstrom < simon.kagstrom@netinsight.net> wrote: > Useful to run applications in usermode via a test driver. > I would add that this commit removes a constraint on no-huge mode being limited to 64M. > Signed-off-by: Simon Kagstrom > --- > Not sure if there are other implications of this, so please check! > Looked around, I can find no issue with this change. > lib/librte_eal/common/eal_common_options.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/eal_common_options.c > b/lib/librte_eal/common/eal_common_options.c > index 4319549..af865f5 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -850,7 +850,7 @@ eal_check_common_options(struct internal_config > *internal_cfg) > return -1; > } > if (internal_cfg->no_hugetlbfs && > - (mem_parsed || internal_cfg->force_sockets == 1)) { > + (internal_cfg->force_sockets == 1)) { > RTE_LOG(ERR, EAL, "Options -m or --"OPT_SOCKET_MEM" cannot > " > "be specified together with --"OPT_NO_HUGE"\n"); > return -1; > We still can't use --socket-mem in no-huge mode since we can't pin memory to socket at the moment, so the test on force_sockets can remain. However, you missed reference to -m in the log message. Can you remove it ? In which situation did you encounter this limitation and how did you test this change ? This should go in the commit log. Thanks. -- David Marchand