From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com
 [209.85.214.182]) by dpdk.org (Postfix) with ESMTP id CD44E9AA0
 for <dev@dpdk.org>; Tue,  3 Feb 2015 07:33:36 +0100 (CET)
Received: by mail-ob0-f182.google.com with SMTP id nt9so16948089obb.13
 for <dev@dpdk.org>; Mon, 02 Feb 2015 22:33:36 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=Ox2g7heYG20fmoy/sEIEE9g/Y8CICpRPrhfiZrw2Ino=;
 b=hk7Y4hf6uri9J0Tuut8JgYaQgNzYfgrdPsenvT2ReDH1hCv4J9PoBJ4m9FiHbCexxs
 zoLQF3f7d4BgO4F2la2rIqm9KumPqIlnuDfybQz3MF9yWacbwyt+1QdLAZ4M1o2N2DJX
 r2G0Cdtc8gGr+MTdazMF5NyCnCWaJX8Z2jE4+HQjLZRn/a3s1SK80EnW0aB/wsbOkscW
 BlglBtQKbgOVy5UrZydgIRKueDkdZMAXhnJFOz/Fi7tEnfHZ0pQ6+nSWKlvG3N2oDlc/
 F2Rr6Lwb2YiP/3eeIjantPD/JIu276gips0vZLC1fcHLHx5Dke0N6I2OF9ozTPViPUqy
 H7jw==
X-Gm-Message-State: ALoCoQm4YP1WRH/tij6ZQY+Z4/kwsbvBC5+xQCCYpUbpihg19CiZijjVh4vVqt8sLaGpXgLvL9D2
MIME-Version: 1.0
X-Received: by 10.202.75.72 with SMTP id y69mr13565412oia.12.1422945216211;
 Mon, 02 Feb 2015 22:33:36 -0800 (PST)
Received: by 10.76.95.198 with HTTP; Mon, 2 Feb 2015 22:33:36 -0800 (PST)
In-Reply-To: <1422899093-20207-3-git-send-email-thomas.monjalon@6wind.com>
References: <1422554832-30093-1-git-send-email-thomas.monjalon@6wind.com>
 <1422899093-20207-1-git-send-email-thomas.monjalon@6wind.com>
 <1422899093-20207-3-git-send-email-thomas.monjalon@6wind.com>
Date: Tue, 3 Feb 2015 07:33:36 +0100
Message-ID: <CALwxeUsq+oq_LobThh=0nFQJfTMfmmof+dmJOPq=EL3gdh+0Cw@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal: add help option
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2015 06:33:37 -0000

On Mon, Feb 2, 2015 at 6:44 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
[snip]

> @@ -340,6 +342,9 @@ eal_parse_args(int argc, char **argv)
>                         continue;
>
>                 switch (opt) {
> +               case 'h':
> +                       eal_usage(prgname);
> +                       exit(EXIT_SUCCESS);
>                 default:
>                         if (opt < OPT_LONG_MIN_NUM && isprint(opt)) {
>                                 RTE_LOG(ERR, EAL, "Option %c is not
> supported "
>
[snip]


> @@ -534,6 +536,10 @@ eal_parse_args(int argc, char **argv)
>                         continue;
>
>                 switch (opt) {
> +               case 'h':
> +                       eal_usage(prgname);
> +                       exit(EXIT_SUCCESS);
> +
>                 /* force loading of external driver */
>                 case 'd':
>                         solib = malloc(sizeof(*solib));
>

Why not move those two in common parser ?


-- 
David Marchand