From: David Marchand <david.marchand@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 3/3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’
Date: Thu, 5 Mar 2015 14:36:23 +0100 [thread overview]
Message-ID: <CALwxeUswiqJ1zbuHjW7-NJhb8iJj8cXv0-7b5Jg+o2DAWqQEug@mail.gmail.com> (raw)
In-Reply-To: <20150305132332.GC1504@bricha3-MOBL3>
On Thu, Mar 5, 2015 at 2:23 PM, Bruce Richardson <bruce.richardson@intel.com
> wrote:
> On Thu, Mar 05, 2015 at 09:15:39PM +0800, Michael Qiu wrote:
> > include/rte_cpuflags.h:154:2: error: redeclaration of enumerator
> ‘REG_EAX’
> > In file included from /usr/include/signal.h:358:0,
> > from /usr/include/sys/wait.h:30,
> > from /root/dpdk/app/test/test_mp_secondary.c:50:
> > /usr/include/sys/ucontext.h:180:3: note: previous definition of
> ‘REG_EAX’ was here
> >
> > In i686, from REG_EAX to REG_EDX are all defined in
> > /usr/include/sys/ucontext.h
>
Well, this is the same for x86_64.
$ grep -rl '\<REG_EAX\>' /usr/include/
/usr/include/x86_64-linux-gnu/sys/ucontext.h
$ ls -l /usr/include/sys/ucontext.h
lrwxrwxrwx 1 root root 34 Feb 22 12:45 /usr/include/sys/ucontext.h ->
../x86_64-linux-gnu/sys/ucontext.h
So I am not sure I understand why we redefine stuff already available from
the toolchain.
Rather than prefixing, I think we should get rid of this and include the
right header.
--
David Marchand
next prev parent reply other threads:[~2015-03-05 13:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 13:15 [dpdk-dev] [PATCH 0/3] dpdk2.0-rc1 build error fix Michael Qiu
2015-03-05 13:15 ` [dpdk-dev] [PATCH 1/3] librte_hash: Fix unsupported instruction `crc32' in i686 platform Michael Qiu
2015-03-05 16:10 ` Yerden Zhumabekov
2015-03-05 16:34 ` Qiu, Michael
2015-03-05 16:55 ` [dpdk-dev] [PATCH 1/3 v2] " Michael Qiu
2015-03-05 17:02 ` Yerden Zhumabekov
2015-03-05 17:10 ` Thomas Monjalon
2015-03-06 1:39 ` Qiu, Michael
2015-03-07 18:39 ` Thomas Monjalon
2015-03-10 3:55 ` Yerden Zhumabekov
2015-03-19 2:00 ` Qiu, Michael
2015-03-19 8:10 ` Thomas Monjalon
2015-03-09 5:58 ` [dpdk-dev] [PATCH 1/3 v3] " Michael Qiu
2015-03-18 13:20 ` Liu, Yong
2015-03-18 14:59 ` Qiu, Michael
2015-03-05 13:15 ` [dpdk-dev] [PATCH 2/3] app/test: Fix size_t printf formart issue Michael Qiu
2015-03-05 13:22 ` Bruce Richardson
2015-03-05 14:00 ` [dpdk-dev] [PATCH 2/3 v2] app/test: Fix size_t printf format issue Michael Qiu
2015-03-05 17:27 ` Thomas Monjalon
2015-03-06 1:42 ` Qiu, Michael
2015-03-06 3:53 ` [dpdk-dev] [PATCH 2/3 v3] " Michael Qiu
2015-03-05 13:15 ` [dpdk-dev] [PATCH 3/3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’ Michael Qiu
2015-03-05 13:23 ` Bruce Richardson
2015-03-05 13:36 ` David Marchand [this message]
2015-03-05 13:54 ` Qiu, Michael
2015-03-05 13:41 ` Qiu, Michael
2015-03-05 13:23 ` Qiu, Michael
2015-03-05 13:50 ` [dpdk-dev] [PATCH 3/3 v2] =?UTF-8?q?librte=5Feal/common:=20Fix=20redeclaration=20of?= =?UTF-8?q?=20enumerator=20=E2=80=98REG=5FEAX=E2=80=99?= Michael Qiu
2015-03-05 13:54 ` [dpdk-dev] [PATCH 3/3 v2] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’ David Marchand
2015-03-05 14:03 ` Qiu, Michael
2015-03-05 14:38 ` Thomas Monjalon
2015-03-05 16:31 ` Qiu, Michael
2015-03-05 18:24 ` Thomas Monjalon
2015-03-05 13:57 ` [dpdk-dev] [PATCH 3/3 v3] =?UTF-8?q?librte=5Feal/common:=20Fix=20redeclaration=20of?= =?UTF-8?q?=20enumerator=20=E2=80=98REG=5FEAX=E2=80=99?= Michael Qiu
2015-03-06 6:28 ` [dpdk-dev] [PATCH 3/3 v3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’ David Marchand
2015-03-09 17:04 ` [dpdk-dev] [PATCH 0/3] dpdk2.0-rc1 build error fix Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUswiqJ1zbuHjW7-NJhb8iJj8cXv0-7b5Jg+o2DAWqQEug@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).