From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-oi0-f53.google.com (mail-oi0-f53.google.com
 [209.85.218.53]) by dpdk.org (Postfix) with ESMTP id B50675921
 for <dev@dpdk.org>; Thu,  5 Mar 2015 14:36:24 +0100 (CET)
Received: by oiba3 with SMTP id a3so11646452oib.3
 for <dev@dpdk.org>; Thu, 05 Mar 2015 05:36:24 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=cN2BF/Bar5hJqceBtbwJgJ5p1L1Ieyx5Q0pxXPZjUW0=;
 b=hkwf4UJEPZ9khZOGBP+d/nLnPLTZ8zcrD+MTj2PxQXpJiUso7nDPyr8LPOh2L1hBVT
 XkjlH/ihA5AQH7FKe1PwoocjPadSNpzvch4KS4a8QEgCsw8ANjgIx/nlUryoIWqFe1PR
 YBI4AU9cbCyPpQZUlGRp147qeDepkCSbBVLCtGeXmT1VwAeCW+ZLvWEDlwdB6Lb75IZ8
 M23zh30ui5tMrPX646JBFKwlxzerbdK7JLAshP592Fuprqz1U5rLr/TFmHgz8bBpc/7J
 XTHcBMRrNH9lu4rrUOdruUmfu8pcTHQos1gDSgITvfsfujxjfNlDey1dHguDGf365qWq
 pqSQ==
X-Gm-Message-State: ALoCoQm8T+Pq4fTrL4LLoVI0ktzoROjEJmzFt/cn5jYgwU4Ov/m8wUiP0vpvp8VP6LW2XvbdH68l
MIME-Version: 1.0
X-Received: by 10.202.108.137 with SMTP id h131mr6646668oic.90.1425562584018; 
 Thu, 05 Mar 2015 05:36:24 -0800 (PST)
Received: by 10.76.34.35 with HTTP; Thu, 5 Mar 2015 05:36:23 -0800 (PST)
In-Reply-To: <20150305132332.GC1504@bricha3-MOBL3>
References: <1425561339-13300-1-git-send-email-michael.qiu@intel.com>
 <1425561339-13300-4-git-send-email-michael.qiu@intel.com>
 <20150305132332.GC1504@bricha3-MOBL3>
Date: Thu, 5 Mar 2015 14:36:23 +0100
Message-ID: <CALwxeUswiqJ1zbuHjW7-NJhb8iJj8cXv0-7b5Jg+o2DAWqQEug@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev]
	=?utf-8?q?=5BPATCH_3/3=5D_librte=5Feal/common=3A_Fix_r?=
	=?utf-8?q?edeclaration_of_enumerator_=E2=80=98REG=5FEAX=E2=80=99?=
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Mar 2015 13:36:25 -0000

On Thu, Mar 5, 2015 at 2:23 PM, Bruce Richardson <bruce.richardson@intel.co=
m
> wrote:

> On Thu, Mar 05, 2015 at 09:15:39PM +0800, Michael Qiu wrote:
> > include/rte_cpuflags.h:154:2: error: redeclaration of enumerator
> =E2=80=98REG_EAX=E2=80=99
> > In file included from /usr/include/signal.h:358:0,
> >                  from /usr/include/sys/wait.h:30,
> >                  from /root/dpdk/app/test/test_mp_secondary.c:50:
> > /usr/include/sys/ucontext.h:180:3: note: previous definition of
> =E2=80=98REG_EAX=E2=80=99 was here
> >
> > In i686, from REG_EAX to REG_EDX are all defined in
> >       /usr/include/sys/ucontext.h
>

Well, this is the same for x86_64.

$ grep -rl '\<REG_EAX\>' /usr/include/
/usr/include/x86_64-linux-gnu/sys/ucontext.h

$ ls -l /usr/include/sys/ucontext.h
lrwxrwxrwx 1 root root 34 Feb 22 12:45 /usr/include/sys/ucontext.h ->
../x86_64-linux-gnu/sys/ucontext.h

So I am not sure I understand why we redefine stuff already available from
the toolchain.
Rather than prefixing, I think we should get rid of this and include the
right header.


--=20
David Marchand