From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id 57C4011C5 for ; Wed, 8 Jul 2015 14:36:56 +0200 (CEST) Received: by oiyy130 with SMTP id y130so164436678oiy.0 for ; Wed, 08 Jul 2015 05:36:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=RpR6qmZKzERbj6F/3m8TP0DeM5+VkXhmvSXGqraiFxw=; b=DqRrN1VuOuRR28ox4OeX6HI4OmuuHEXMa5pTnEPWhqod89fUK3rsC0t8alNjxK/S4G OY+250L4rw3vlQyHvt7ACR8sBa2GobJmJJCExSm8zzFPjsuAB6MxbRBmZqDAHIisV80b zthLFoPiqNyGhbajWF+BB65GGbI8kWbNAW5PVjcSDxCKl1bOe4p60xoVgzYJly6IgUDc O381W5DOLUaseBYXXwjDncfTt4hdFOwu0Q0j6Xl/SdpznVB4xB1gea8CBt2uyTe3JrxQ dn73cqrf24P80DqLYIdEYcMaphXFHo/kSst9JzCJP+rR2voljKLcPZL9NhPBjBswbLw+ pUoA== X-Gm-Message-State: ALoCoQl8Vhdtkp151IDA7tAq2PISkGwG1QLzA4eb48E4HebDxIj29NdIPnsr2sQzrUIMblt/68af MIME-Version: 1.0 X-Received: by 10.60.33.74 with SMTP id p10mr9700404oei.62.1436359015660; Wed, 08 Jul 2015 05:36:55 -0700 (PDT) Received: by 10.76.84.233 with HTTP; Wed, 8 Jul 2015 05:36:55 -0700 (PDT) In-Reply-To: <1436351693-2349-1-git-send-email-mukawa@igel.co.jp> References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp> <1436351693-2349-1-git-send-email-mukawa@igel.co.jp> Date: Wed, 8 Jul 2015 14:36:55 +0200 Message-ID: From: David Marchand To: Tetsuya Mukawa Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v9 00/12] Clean up pci uio implementations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 12:36:56 -0000 On Wed, Jul 8, 2015 at 12:34 PM, Tetsuya Mukawa wrote: > Currently Linux implementation and BSD implementation have almost same > code about pci uio. This patch series cleans up it. > > PATCH v9 changes: > - Add lost Acked-by and Tested-by signatures. > - Remove NULL checkings before calling rte_free(). > - Fix pci_uio_map_secondary() to remove needless close(). > - Remove needless parameter checkings of pci_uio_alloc_resource() and > pci_uio_map_resource_by_index(). > - Remove needless error checking for return value of > pci_uio_alloc_resource(). > - Introduce pci_uio_free_resource(). > - Remove some comments of pci_uio_map_resource(). > (Thanks to David Marchand) > > Acked-by: David Marchand Thanks for this big cleanup Tetsuya. -- David Marchand