From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f179.google.com (mail-ob0-f179.google.com [209.85.214.179]) by dpdk.org (Postfix) with ESMTP id E78262E81 for ; Wed, 26 Nov 2014 10:21:48 +0100 (CET) Received: by mail-ob0-f179.google.com with SMTP id va2so1892842obc.24 for ; Wed, 26 Nov 2014 01:32:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=fO5wy7FOM3j21RpNoe+Rl6Pr2wEFlARr4P6HoJ4D2Ww=; b=BeP+Zc7Rh/yAWLy4ywIUdja3TkWl47wi5ID1BPHv64YzmQYz7Zdvl1LM1AI9iQWzYx oGPvjxRwVkujYryyqBEWD1MXb6eVhAHnL1NCWdDS+eXUoaTFxMgdpAe4j7pZMptX8moc D43Jz6vZEJ5okxSgiCH34TQ+gLUryR4B9JvoLN29Y+75x/N3GWhthpD9JfALW0XsNoFl PL2r1XJZaevGOtzv7BMBprc38jrYOEn/PuGyo1jlmo8Powc93K8QPRSs58cmripa87bZ 0Mv9dbSNKt43BtlCGlH0hcuFNwt26ygSTqAhuvnEFEy7/+DlJXSQkoz3QGOZCPTyy72X 6nAQ== X-Gm-Message-State: ALoCoQkD/1qKftuU0Xi4n7CiYnGMNJfXLJoPL8sm9KO51I9TaDiqrrS3J2Ej4M9L70blyxWhE2Tx MIME-Version: 1.0 X-Received: by 10.202.189.139 with SMTP id n133mr13130227oif.63.1416994364493; Wed, 26 Nov 2014 01:32:44 -0800 (PST) Received: by 10.202.60.197 with HTTP; Wed, 26 Nov 2014 01:32:44 -0800 (PST) In-Reply-To: <1416953837-15894-1-git-send-email-chaozhu@linux.vnet.ibm.com> References: <1416953837-15894-1-git-send-email-chaozhu@linux.vnet.ibm.com> Date: Wed, 26 Nov 2014 10:32:44 +0100 Message-ID: From: David Marchand To: Chao Zhu Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 00/14] Patches for DPDK to support Power architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Nov 2014 09:21:49 -0000 On Tue, Nov 25, 2014 at 11:17 PM, Chao Zhu wrote: > The set of patches add IBM Power architecture to the DPDK. It adds the > required support to the EAL library. This set of patches doesn't support > full DPDK function on Power processors. To compile on PPC64 architecture, > GCC version >= 4.8 must be used. According to Bruce and Neil's comments, > this v5 patch removed the common configuration files of Powerpc in v4. > Also, it fixed the checkpatch issues in v3. > > The only unsolved checkpatch issue is : > ERROR: space prohibited before open square bracket '[' > > This issue refers to the asm code input/output naming. But I think the > error is invalid. > > I must admit that the architecture abstraction in dpdk is not fully done, but it is more a "core" problem than a problem of this port itself. I am pretty sure that there is still a lot of places in dpdk that rely on the fact that they were written for x86 architecture. Neil's concerns on cpuflags ( http://dpdk.org/ml/archives/dev/2014-November/008769.html) are valid but I think we could go with an incremental approach. Since Chao is commited to add power support to dpdk, we can have this fixed in subsequent patches with this patchset in 1.8. So, this patchset looks good enough to me. Acked-by: David Marchand -- David Marchand