From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 0E3DA3239 for ; Sun, 20 Nov 2016 16:22:51 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id t79so106555824wmt.0 for ; Sun, 20 Nov 2016 07:22:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cBjwzQTDGV+3IAY69tFVTQgzw/WD/D2su4NsgFUNJLM=; b=zts6Rwr5SkkMGQ2CTwzAbgW0YsYLeG8M96Ajxar+RkacHHAV3tyAoT2mVR54cV8gxG JF5JurGXuNXgCv/pSX5LlwnmocwjxVQ7T9hC5o1fAoNohWhjDrRB7soBuV5maeM7Zr0G viwtTXJn5H6RDTPPJU/vfTpnwiE/zVajU/zUXV4JHMFcP9NXk9q/SU1kuDbGUxLJ644z 6yLfROVejjXoGBRK9gWdIXdxyAtjKdMN9WqqC8yaTPHRaCv4RN+zw3x/YKIZet0WBTHd AKAccZPwpyVoAf29EDmdY0ZdC/hQKhZ40Kv0S6Q8mfqsJk4CAb2LoRUsLYXmLy+dCLFG Y4Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cBjwzQTDGV+3IAY69tFVTQgzw/WD/D2su4NsgFUNJLM=; b=OKtgg856e29dD9jdIuE5ZF0q/P1DXlkzK0ClkbItib/VAX6opU/AiRr2UyaS+iwV+w 2yOj2rWwNo8I2wdHwRFt7jMdwAiL8rn5nhdPb0tyESnHzmPWS7bjsWAbkAAQU9Yirfz1 XQC+oBrQw13GPhh1G4LTOMPtLhzbgik6lqnU32kR6nZ/u8n9HTVE6fBIqFkqY6WS3PXe 1Z4U0119rQT/478iP9ctMuhb8Wo92VNwPQDmVUsQG6y7p32fd66mxdS0dWVQdbrp2MKe tn+5BywWTDHWBSX9JVx9MaZFsa1KMVI4FI0151Es4xCgfmFeR/bKHXVAxyXayfVx4STI il9g== X-Gm-Message-State: AKaTC00pDOOGgBCLzk4r370Zjpx1bafaDU1uN6CEQ7FnrPsc0aSocfZL4ku50Bjuie/tm3dxIWmKzfkqAc/wN29i X-Received: by 10.28.13.144 with SMTP id 138mr8137836wmn.120.1479655371718; Sun, 20 Nov 2016 07:22:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.188.6 with HTTP; Sun, 20 Nov 2016 07:22:31 -0800 (PST) In-Reply-To: <1479636327-4166-4-git-send-email-jblunck@infradead.org> References: <1479636327-4166-1-git-send-email-jblunck@infradead.org> <1479636327-4166-4-git-send-email-jblunck@infradead.org> From: David Marchand Date: Sun, 20 Nov 2016 16:22:31 +0100 Message-ID: To: Jan Blunck Cc: "dev@dpdk.org" , Shreyansh Jain Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 4/7] virtio: Don't fill dev_info->driver_name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Nov 2016 15:22:52 -0000 On Sun, Nov 20, 2016 at 11:05 AM, Jan Blunck wrote: > This is overwritten in rte_eth_dev_info_get(). > > Signed-off-by: Jan Blunck > --- > drivers/net/virtio/virtio_ethdev.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 079fd6c..741688e 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > uint64_t tso_mask; > struct virtio_hw *hw = dev->data->dev_private; > > - if (dev->pci_dev) > - dev_info->driver_name = dev->driver->pci_drv.driver.name; > - else > - dev_info->driver_name = "virtio_user PMD"; > dev_info->max_rx_queues = > RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES); > dev_info->max_tx_queues = > -- > 2.7.4 > I posted something similar [1], so looks good to me :-) [1]: http://dpdk.org/dev/patchwork/patch/16991/ -- David Marchand