From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) by dpdk.org (Postfix) with ESMTP id B7CCD5F72 for ; Thu, 13 Sep 2018 18:43:23 +0200 (CEST) Received: by mail-yb1-f194.google.com with SMTP id v10-v6so3533206ybm.8 for ; Thu, 13 Sep 2018 09:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CVAR2u2d6ZbPiJmCQfnGRMJk10j4c0l84/R4rCLM+94=; b=KvofE7qpE4VNoYOURrk1misScdWHElQC2HbrKeNV9ktKmTpAAID1wFYaLv1/5rK4Lu mhSICJP/WmJ7zkYY8cxPkZ5zeYYkf6sHsOyN5z35fqq1Da2p/4wby9jmcVo/C7Vi9ZAG SzMSe14v1vu9mz2UEysiejtKYS3X7C2ef79dMSdvAVeu6CMiP5TIWSKrWFWMtcOMzb3O CpvMW5IY1uoSCu76VG53+TU6bUQW+ncew3uYAVsBLzPL/9Q0av5Ijdn87uJqXyitFUBd B5beiAqI8Icnkp4Yxapu2q8oilRrtqz24towAh5+E6EJTZs1msaVGHwVpBdw/xaOARzI NK+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CVAR2u2d6ZbPiJmCQfnGRMJk10j4c0l84/R4rCLM+94=; b=GqCYYRpE1yNgWv9NTxQnQXmht+kAnnrSdv4S8vKJJopdiWNh2SJBOyUm3KejCC58Y4 /u9hd8li0Bm6YbACq5PR+PMCajH8zhYBEQe1yYIyhQqqoC85GdT9ZtsdpvO2XB66VAgk F9r4cXso7y49o7XRkeJN0VTz1aqkQ0jmKwb0kIz62gp7xUrCSZPrYtjE+Z3mrDsFSgok ZsE8ZWHhBazYhws0H8UyUsDHdytiTS1MTwHph4cDXLEnPOwlH71JaGdy/04Sb27YU+6p IaFInQSy0o0DAyOar33+bh5gX0s2zt2kqBxYz9bJiXWliIs/X8gtGBx6Vecb+ut9yYLp WgvA== X-Gm-Message-State: APzg51CyoSyebW98KMy1DeQEkLA6tiLALWeeyfmJPIlXa6c9wTI9xEt8 gAjjgQlbYEhF2a86GJEZbNYQt2Wr9vT0ivDAPPtt+A== X-Google-Smtp-Source: ANB0VdYPtHK3S/op7Jlw571mAZGvMifAm8qjUCSu+m87BMpqqGx0ySeRY+soVdvn3SeboeSPLm5cE86/35t0u6hbozA= X-Received: by 2002:a25:ce91:: with SMTP id x139-v6mr3867175ybe.301.1536857002855; Thu, 13 Sep 2018 09:43:22 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:4bc3:0:0:0:0:0 with HTTP; Thu, 13 Sep 2018 09:43:02 -0700 (PDT) In-Reply-To: <1536739583-29166-2-git-send-email-rasland@mellanox.com> References: <1536739583-29166-1-git-send-email-rasland@mellanox.com> <1536739583-29166-2-git-send-email-rasland@mellanox.com> From: David Marchand Date: Thu, 13 Sep 2018 18:43:02 +0200 Message-ID: To: Raslan Darawsheh Cc: "Wu, Jingjing" , Thomas Monjalon , dev@dpdk.org, Shahaf Shuler , xuemingl@mellanox.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 16:43:24 -0000 On Wed, Sep 12, 2018 at 10:06 AM, Raslan Darawsheh wrote: > use the generic function to dump packets for several forwarding > engines. Rather than patching some engines, how about putting this in rx/tx callbacks ? A bit like something I sent earlier ? http://patches.dpdk.org/patch/44465/ -- David Marchand