From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com [209.85.214.169]) by dpdk.org (Postfix) with ESMTP id E43EF3975 for ; Tue, 25 Nov 2014 10:54:36 +0100 (CET) Received: by mail-ob0-f169.google.com with SMTP id vb8so167024obc.28 for ; Tue, 25 Nov 2014 02:05:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=pcEcTluObRE5WV7nj72K/fABU+WV3gKb/zdsYCgX1vg=; b=GZd6s+akQxSTsEXR3kFHLcnquDXzwg3XYC3Pia2rWLHwmyp1vAE9r5l5Mvxri7q3Dh MFnxX3w7IL0ukH0qMXtz3Jn1PjGwDQL4jXmUamfeaWG1jssUxkk7ASTaevS5miPpy9MF sfLaGNHvQ83Pef20fgR6HcHEqMCp6TzTesFYkjEg/7zOGkzmGhwn//eZVO8OJiONRPjb akjdyHnVwGtNBvUHbGa4+bKfCS2Fgk2jcXMzvuebAgiPMBoku62QaLj3nAe3Q8vORLGG EL/lS8dz2EUhO9WWB/TTu9CGYpPi3dGqDPF53LDt4ncbbQN2pp6lCXlJLwE7BcwaF/PV 9/og== X-Gm-Message-State: ALoCoQm1nSF4IefQBcKWQzLMpcRPK0TCCbsRdPEZjVnX1Mk+MteG8ahnrM6VRCNg3U5HU29+8z+K MIME-Version: 1.0 X-Received: by 10.202.45.198 with SMTP id t189mr13698199oit.68.1416909928170; Tue, 25 Nov 2014 02:05:28 -0800 (PST) Received: by 10.202.60.197 with HTTP; Tue, 25 Nov 2014 02:05:28 -0800 (PST) In-Reply-To: <1416933018-23415-1-git-send-email-ssujith@cisco.com> References: <1416933018-23415-1-git-send-email-ssujith@cisco.com> Date: Tue, 25 Nov 2014 11:05:28 +0100 Message-ID: From: David Marchand To: Sujith Sankar Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" , "Prasad Rao \(prrao\)" Subject: Re: [dpdk-dev] [PATCH v4 0/6] Cisco Systems Inc. VIC Ethernet PMD - ENIC PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 09:54:37 -0000 Hello Sujith, - This is a comment for the whole patchset. Patch subjects and commitlogs should comply with the "Contribute by sending patches" section of http://dpdk.org/dev. I would say, all your patches should be prefixed with "enic: ". - By the way, can you add some performance numbers as a reference in the cover letter ? Thanks. -- David Marchand On Tue, Nov 25, 2014 at 5:30 PM, Sujith Sankar wrote: > ENIC PMD is the poll-mode driver for the Cisco Systems Inc. VIC to be > used with DPDK suite. > > Sujith Sankar (6): > ENIC PMD License > ENIC PMD Makefile > VNIC common code partially shared with ENIC kernel mode driver > ENIC PMD specific code > DPDK-ENIC PMD interface > DPDK changes for accommodating ENIC PMD > > config/common_linuxapp | 5 + > lib/Makefile | 1 + > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 1 + > lib/librte_pmd_enic/LICENSE | 27 + > lib/librte_pmd_enic/Makefile | 67 ++ > lib/librte_pmd_enic/enic.h | 157 ++++ > lib/librte_pmd_enic/enic_clsf.c | 244 ++++++ > lib/librte_pmd_enic/enic_compat.h | 142 ++++ > lib/librte_pmd_enic/enic_etherdev.c | 613 ++++++++++++++ > lib/librte_pmd_enic/enic_main.c | 1266 > ++++++++++++++++++++++++++++ > lib/librte_pmd_enic/enic_res.c | 221 +++++ > lib/librte_pmd_enic/enic_res.h | 168 ++++ > lib/librte_pmd_enic/vnic/cq_desc.h | 126 +++ > lib/librte_pmd_enic/vnic/cq_enet_desc.h | 261 ++++++ > lib/librte_pmd_enic/vnic/rq_enet_desc.h | 76 ++ > lib/librte_pmd_enic/vnic/vnic_cq.c | 117 +++ > lib/librte_pmd_enic/vnic/vnic_cq.h | 152 ++++ > lib/librte_pmd_enic/vnic/vnic_dev.c | 1063 +++++++++++++++++++++++ > lib/librte_pmd_enic/vnic/vnic_dev.h | 202 +++++ > lib/librte_pmd_enic/vnic/vnic_devcmd.h | 774 +++++++++++++++++ > lib/librte_pmd_enic/vnic/vnic_enet.h | 78 ++ > lib/librte_pmd_enic/vnic/vnic_intr.c | 83 ++ > lib/librte_pmd_enic/vnic/vnic_intr.h | 126 +++ > lib/librte_pmd_enic/vnic/vnic_nic.h | 88 ++ > lib/librte_pmd_enic/vnic/vnic_resource.h | 97 +++ > lib/librte_pmd_enic/vnic/vnic_rq.c | 246 ++++++ > lib/librte_pmd_enic/vnic/vnic_rq.h | 282 +++++++ > lib/librte_pmd_enic/vnic/vnic_rss.c | 85 ++ > lib/librte_pmd_enic/vnic/vnic_rss.h | 61 ++ > lib/librte_pmd_enic/vnic/vnic_stats.h | 86 ++ > lib/librte_pmd_enic/vnic/vnic_wq.c | 245 ++++++ > lib/librte_pmd_enic/vnic/vnic_wq.h | 283 +++++++ > lib/librte_pmd_enic/vnic/wq_enet_desc.h | 114 +++ > mk/rte.app.mk | 4 + > 34 files changed, 7561 insertions(+) > create mode 100644 lib/librte_pmd_enic/LICENSE > create mode 100644 lib/librte_pmd_enic/Makefile > create mode 100644 lib/librte_pmd_enic/enic.h > create mode 100644 lib/librte_pmd_enic/enic_clsf.c > create mode 100644 lib/librte_pmd_enic/enic_compat.h > create mode 100644 lib/librte_pmd_enic/enic_etherdev.c > create mode 100644 lib/librte_pmd_enic/enic_main.c > create mode 100644 lib/librte_pmd_enic/enic_res.c > create mode 100644 lib/librte_pmd_enic/enic_res.h > create mode 100644 lib/librte_pmd_enic/vnic/cq_desc.h > create mode 100644 lib/librte_pmd_enic/vnic/cq_enet_desc.h > create mode 100644 lib/librte_pmd_enic/vnic/rq_enet_desc.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_cq.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_cq.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_dev.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_dev.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_devcmd.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_enet.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_intr.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_intr.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_nic.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_resource.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_rq.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_rq.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_rss.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_rss.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_stats.h > create mode 100644 lib/librte_pmd_enic/vnic/vnic_wq.c > create mode 100644 lib/librte_pmd_enic/vnic/vnic_wq.h > create mode 100644 lib/librte_pmd_enic/vnic/wq_enet_desc.h > > -- > 1.9.1 > >