From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com
 [209.85.214.181]) by dpdk.org (Postfix) with ESMTP id CBD61593A
 for <dev@dpdk.org>; Wed, 11 Mar 2015 09:59:33 +0100 (CET)
Received: by obcwp18 with SMTP id wp18so7453665obc.1
 for <dev@dpdk.org>; Wed, 11 Mar 2015 01:59:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=6WHz1XI5QUf1v/owtqNd9ZS/G7GOyhf9VA1XJW4+rGg=;
 b=NTvEpaMZtnJHQE2UOnlj8J9iV1RXw+gZ9FOieWDTijDFgPSvmCNaoHqhYRoggnymwT
 w5KlCxF2YzNduWAfiVKLu1HDBobfct1h6OPfMGqhnjqdOWbmAB9ixFZqrYrgUSX3+Rky
 cJlmzCWkJvhqIiRog/JtZLgoJEPKIxdgZBkb04eIv2yxpjYekmyNOD0E2DwSBfAFODXZ
 z5qTTyzWiwFRWKFSAKk9DGsxoKAQ43P+9gN62m16c+kaYQi7N/f+Dwa/oV69ZY+M0bZ2
 O5ghGBnNPzL8uzqhjNU248RRbt+Q5BBjTyzJME3GZ2cyjB2Nl1tB+SiJ/Wde4r/hPFXx
 VcXw==
X-Gm-Message-State: ALoCoQkQ/VHQFFs1ZdCGDniuP0ZchWVIFV+BTzcSYiECURRPQ2l9Jb+K4DY1h0h5GwmlUMCEwxZ0
MIME-Version: 1.0
X-Received: by 10.182.251.138 with SMTP id zk10mr29659014obc.72.1426064373181; 
 Wed, 11 Mar 2015 01:59:33 -0700 (PDT)
Received: by 10.76.34.35 with HTTP; Wed, 11 Mar 2015 01:59:33 -0700 (PDT)
In-Reply-To: <1426063436-15939-1-git-send-email-yong.liu@intel.com>
References: <1426063436-15939-1-git-send-email-yong.liu@intel.com>
Date: Wed, 11 Mar 2015 09:59:33 +0100
Message-ID: <CALwxeUt59X_rj0_tXb9y4NEd6wB2UOJg5As4qF+vBmXuTEaEoQ@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Yong Liu <yong.liu@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/test-pmd: fix rte_pci_tailq not
 initialized before used
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2015 08:59:34 -0000

Hello Marvin,

I think this fix will break ivshmem init.
pci_init was moved when introducing ivshmem_init.

If you have a setup for this, can you check ivshmem init with your fix ?

Thanks.

-- 
David Marchand

On Wed, Mar 11, 2015 at 9:43 AM, Yong Liu <yong.liu@intel.com> wrote:

> Function rte_eal_pci_init will cast pci resource list and used for insert
> probed device later. But all tailq initialized in function
> rte_eal_tailqs_init, so rte_eal_pci_init must be called after it.
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c
> b/lib/librte_eal/linuxapp/eal/eal.c
> index bd770cf..576f9f8 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -755,9 +755,6 @@ rte_eal_init(int argc, char **argv)
>
>         rte_config_init();
>
> -       if (rte_eal_pci_init() < 0)
> -               rte_panic("Cannot init PCI\n");
> -
>  #ifdef RTE_LIBRTE_IVSHMEM
>         if (rte_eal_ivshmem_init() < 0)
>                 rte_panic("Cannot init IVSHMEM\n");
> @@ -792,6 +789,9 @@ rte_eal_init(int argc, char **argv)
>         if (rte_eal_timer_init() < 0)
>                 rte_panic("Cannot init HPET or TSC timers\n");
>
> +       if (rte_eal_pci_init() < 0)
> +               rte_panic("Cannot init PCI\n");
> +
>         eal_check_mem_on_local_socket();
>
>         rte_eal_mcfg_complete();
> --
> 1.9.3
>
>