DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH] enic: silence log message
Date: Mon, 9 Feb 2015 13:21:46 +0100
Message-ID: <CALwxeUt87snj1=fbc4UyV9fbR_aYUN5FmU2v7tF3CBrk4M3OEQ@mail.gmail.com> (raw)
In-Reply-To: <1423416981-5168-2-git-send-email-stephen@networkplumber.org>

On Sun, Feb 8, 2015 at 6:36 PM, Stephen Hemminger <
stephen@networkplumber.org> wrote:

> From: Stephen Hemminger <shemming@brocade.com>
>
> Silence is normal. drivers should speak only when spoken to and not
> be chatty.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/librte_pmd_enic/enic_main.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_pmd_enic/enic_main.c
> b/lib/librte_pmd_enic/enic_main.c
> index 48fdca2..dad8922 100644
> --- a/lib/librte_pmd_enic/enic_main.c
> +++ b/lib/librte_pmd_enic/enic_main.c
> @@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic)
>         struct rte_pci_device *pdev = enic->pdev;
>         int err = -1;
>
> -       dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
> -
>         enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
>         enic->bar0.len = pdev->mem_resource[0].len;
>

NAK.

The main problem is that enic pmd is using printf to write logs.
So the pmd should be fixed so that dev_* macros use RTE_LOG.

Silence is good when it is the default behaviour.
But I prefer we can change this at runtime, rather than strip the log
messages, especially for init.


-- 
David Marchand

  reply	other threads:[~2015-02-09 12:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-08 17:36 Stephen Hemminger
2015-02-08 17:36 ` Stephen Hemminger
2015-02-09 12:21   ` David Marchand [this message]
2015-02-09 16:11     ` Stephen Hemminger
2015-02-15  6:13       ` Sujith Sankar (ssujith)
2015-02-15  6:29         ` Sujith Sankar (ssujith)
  -- strict thread matches above, loose matches on Subject: below --
2015-02-08 17:35 Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALwxeUt87snj1=fbc4UyV9fbR_aYUN5FmU2v7tF3CBrk4M3OEQ@mail.gmail.com' \
    --to=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=shemming@brocade.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git