From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com
 [209.85.214.173]) by dpdk.org (Postfix) with ESMTP id DD6C358E8
 for <dev@dpdk.org>; Mon,  9 Feb 2015 13:21:46 +0100 (CET)
Received: by mail-ob0-f173.google.com with SMTP id uy5so24748338obc.4
 for <dev@dpdk.org>; Mon, 09 Feb 2015 04:21:46 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=X3hxQtbsfTyasag9/l9CqO1mEM/Uy9XEPsvOC5EtRV4=;
 b=m6l6RnUaNKzURVM1lcAMAaxuAxzkCKAIb6MdudZTzXqZPmEK7FHLT1FTAilILcSDpq
 57Pt1nNwtWrdx/CYiFt8pQGJDezy10XxnM1bTj2QWchGVnagmDW786fN+Tec7pHh7GLL
 tTKE0xSQw4b5VxxS1OLWTsANptoQVV8x2oNv/OPgh5P78/f+0+tTyB/GTIPCv9LEOIFz
 YSh/4ZerSzf/HmXwO00m2yGidGxd8kB1JElw4T8lwJd40sSe2LNmiAYMLd89iSlTcY6a
 bkQFaHWK32sJGPsWsTMZZnBArt9QBJ+gXbcdsznczpFHNcX74WJHGYG8BLK2BvKNIFH4
 D8qQ==
X-Gm-Message-State: ALoCoQn2yDm6kUp0Y2wlnUTIQq7emIdkUEFx0KwsRv4kedWD3uCIo4Qf/EL+nFlhmI/RDTcNS6vP
MIME-Version: 1.0
X-Received: by 10.60.103.242 with SMTP id fz18mr11413283oeb.14.1423484506355; 
 Mon, 09 Feb 2015 04:21:46 -0800 (PST)
Received: by 10.76.95.198 with HTTP; Mon, 9 Feb 2015 04:21:46 -0800 (PST)
In-Reply-To: <1423416981-5168-2-git-send-email-stephen@networkplumber.org>
References: <1423416981-5168-1-git-send-email-stephen@networkplumber.org>
 <1423416981-5168-2-git-send-email-stephen@networkplumber.org>
Date: Mon, 9 Feb 2015 13:21:46 +0100
Message-ID: <CALwxeUt87snj1=fbc4UyV9fbR_aYUN5FmU2v7tF3CBrk4M3OEQ@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH] enic: silence log message
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Feb 2015 12:21:47 -0000

On Sun, Feb 8, 2015 at 6:36 PM, Stephen Hemminger <
stephen@networkplumber.org> wrote:

> From: Stephen Hemminger <shemming@brocade.com>
>
> Silence is normal. drivers should speak only when spoken to and not
> be chatty.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/librte_pmd_enic/enic_main.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_pmd_enic/enic_main.c
> b/lib/librte_pmd_enic/enic_main.c
> index 48fdca2..dad8922 100644
> --- a/lib/librte_pmd_enic/enic_main.c
> +++ b/lib/librte_pmd_enic/enic_main.c
> @@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic)
>         struct rte_pci_device *pdev = enic->pdev;
>         int err = -1;
>
> -       dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
> -
>         enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
>         enic->bar0.len = pdev->mem_resource[0].len;
>

NAK.

The main problem is that enic pmd is using printf to write logs.
So the pmd should be fixed so that dev_* macros use RTE_LOG.

Silence is good when it is the default behaviour.
But I prefer we can change this at runtime, rather than strip the log
messages, especially for init.


-- 
David Marchand