From: David Marchand <david.marchand@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] i40e: Steps and required configurations of how to achieve the best performance!
Date: Wed, 17 Sep 2014 10:33:46 +0200 [thread overview]
Message-ID: <CALwxeUtGDiGv_JaEfFs8cFL4ByVt_SOktx03tCC8H2B72gj-YA@mail.gmail.com> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A793414@SHSMSX104.ccr.corp.intel.com>
Hello,
Some questions/comments :
On Wed, Sep 17, 2014 at 6:18 AM, Zhang, Helin <helin.zhang@intel.com> wrote:
> -- *Extended Tag: Enabled
> Note that 'Extended Tag' might not be seen in some BIOS, see 'compile
> settings' for doing that at runtime.
>
I am not sure I understand this point.
Either you have a bios that configures extended tag and you don't need
anything in the dpdk or your bios does not support it and you must set it
at runtime ?
Then why not just set it at runtime and we avoid touching bios config ?
5. Compile Settings:
> -- Change below configuration items in config files
> CONFIG_RTE_PCI_CONFIG=y
> CONFIG_RTE_PCI_EXTENDED_TAG="on"
>
Why have this build option for what looks to be a runtime decision ?
Why don't we have RTE_PCI_CONFIG always set and extended tag to "on" ?
(which means that we can get rid of these build options)
Looking at igb_uio code, I am a bit concerned that this option affects all
"igb_uio" pci devices in dpdk.
Can you ensure me that any pci device going through igb_uio (em, igb, ixgbe
etc... devices) will behave well with this option enabled ?
It would be better to have a per-device (or per-pmd) option.
Plus, build option should really be avoided for any feature in dpdk (and we
have a lot of cleanup work about this ...).
> CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=y
>
Why is it disabled as a default ?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2014-09-17 8:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 4:18 Zhang, Helin
2014-09-17 8:33 ` David Marchand [this message]
2014-09-17 8:50 ` Zhang, Helin
2014-09-17 14:03 ` David Marchand
2014-09-18 2:39 ` Zhang, Helin
2014-09-18 8:57 ` David Marchand
2014-09-19 3:43 ` Zhang, Helin
2014-10-15 9:41 ` Thomas Monjalon
2014-10-16 0:43 ` Zhang, Helin
2015-02-09 12:12 ` David Marchand
2015-02-10 0:27 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUtGDiGv_JaEfFs8cFL4ByVt_SOktx03tCC8H2B72gj-YA@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).